diff mbox series

[v4,1/1] usb: informative message if no controller

Message ID 20240618190729.15201-1-heinrich.schuchardt@canonical.com
State Accepted
Commit 4477e425d5e11cd279410c76fb189f8d9e2f4704
Delegated to: Marek Vasut
Headers show
Series [v4,1/1] usb: informative message if no controller | expand

Commit Message

Heinrich Schuchardt June 18, 2024, 7:07 p.m. UTC 
The message 'No working controllers found' provides no clue that this
refers to USB controllers.

Provide a message that refers to USB.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
v4:
	correct commit message (remove log_info() reference)
v3:
	plural controllers
v2:
	add 'found' at end of message
	keep printf
---
 drivers/usb/host/usb-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut June 19, 2024, 4:15 a.m. UTC | #1 
On 6/18/24 9:07 PM, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
> 
> Provide a message that refers to USB.

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
index cd3a07e4c37..bfec303e7af 100644
--- a/drivers/usb/host/usb-uclass.c
+++ b/drivers/usb/host/usb-uclass.c
@@ -387,7 +387,7 @@  int usb_init(void)
 
 	/* if we were not able to find at least one working bus, bail out */
 	if (controllers_initialized == 0)
-		printf("No working controllers found\n");
+		printf("No USB controllers found\n");
 
 	return usb_started ? 0 : -ENOENT;
 }