| Message ID | 20240614005309.34433-7-marek.vasut+renesas@mailbox.org |
|---|---|
| State | Accepted |
| Commit | 2c2d7c2bab0ec6e4cd93db242822a57986680917 |
| Delegated to: | Mattijs Korpershoek |
| Headers | show |
| Series | usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass | expand |
Hi Marek, Thank you for the patch. On ven., juin 14, 2024 at 02:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Implement .handle_interrupts callback as a replacement for deprecated > dm_usb_gadget_handle_interrupts() function. The new callback allows > for each DM capable USB gadget controller driver to define its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com> > Cc: Felipe Balbi <felipe.balbi@linux.intel.com> > Cc: Lukasz Majewski <lukma@denx.de> > Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Cc: Nishanth Menon <nm@ti.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > Cc: Tom Rini <trini@konsulko.com> > Cc: u-boot@lists.denx.de > --- > drivers/usb/mtu3/mtu3_plat.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c > index ca86b58dfcd..f8e14eabfb2 100644 > --- a/drivers/usb/mtu3/mtu3_plat.c > +++ b/drivers/usb/mtu3/mtu3_plat.c > @@ -223,15 +223,6 @@ static const struct udevice_id ssusb_of_match[] = { > }; > > #if CONFIG_IS_ENABLED(DM_USB_GADGET) > -int dm_usb_gadget_handle_interrupts(struct udevice *dev) > -{ > - struct mtu3 *mtu = dev_get_priv(dev); > - > - mtu3_irq(0, mtu); > - > - return 0; > -} > - > static int mtu3_gadget_probe(struct udevice *dev) > { > struct ssusb_mtk *ssusb = dev_to_ssusb(dev->parent); > @@ -250,10 +241,24 @@ static int mtu3_gadget_remove(struct udevice *dev) > return 0; > } > > +static int mtu3_gadget_handle_interrupts(struct udevice *dev) > +{ > + struct mtu3 *mtu = dev_get_priv(dev); > + > + mtu3_irq(0, mtu); > + > + return 0; > +} > + > +static const struct usb_gadget_generic_ops mtu3_gadget_ops = { > + .handle_interrupts = mtu3_gadget_handle_interrupts, > +}; > + > U_BOOT_DRIVER(mtu3_peripheral) = { > .name = "mtu3-peripheral", > .id = UCLASS_USB_GADGET_GENERIC, > .of_match = ssusb_of_match, > + .ops = &mtu3_gadget_ops, > .probe = mtu3_gadget_probe, > .remove = mtu3_gadget_remove, > .priv_auto = sizeof(struct mtu3), > -- > 2.43.0
diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index ca86b58dfcd..f8e14eabfb2 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -223,15 +223,6 @@ static const struct udevice_id ssusb_of_match[] = { }; #if CONFIG_IS_ENABLED(DM_USB_GADGET) -int dm_usb_gadget_handle_interrupts(struct udevice *dev) -{ - struct mtu3 *mtu = dev_get_priv(dev); - - mtu3_irq(0, mtu); - - return 0; -} - static int mtu3_gadget_probe(struct udevice *dev) { struct ssusb_mtk *ssusb = dev_to_ssusb(dev->parent); @@ -250,10 +241,24 @@ static int mtu3_gadget_remove(struct udevice *dev) return 0; } +static int mtu3_gadget_handle_interrupts(struct udevice *dev) +{ + struct mtu3 *mtu = dev_get_priv(dev); + + mtu3_irq(0, mtu); + + return 0; +} + +static const struct usb_gadget_generic_ops mtu3_gadget_ops = { + .handle_interrupts = mtu3_gadget_handle_interrupts, +}; + U_BOOT_DRIVER(mtu3_peripheral) = { .name = "mtu3-peripheral", .id = UCLASS_USB_GADGET_GENERIC, .of_match = ssusb_of_match, + .ops = &mtu3_gadget_ops, .probe = mtu3_gadget_probe, .remove = mtu3_gadget_remove, .priv_auto = sizeof(struct mtu3),
Implement .handle_interrupts callback as a replacement for deprecated dm_usb_gadget_handle_interrupts() function. The new callback allows for each DM capable USB gadget controller driver to define its own IRQ handling implementation without colliding with other controller drivers. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com> Cc: Felipe Balbi <felipe.balbi@linux.intel.com> Cc: Lukasz Majewski <lukma@denx.de> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> Cc: Nishanth Menon <nm@ti.com> Cc: Simon Glass <sjg@chromium.org> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Cc: Tom Rini <trini@konsulko.com> Cc: u-boot@lists.denx.de --- drivers/usb/mtu3/mtu3_plat.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)