mbox series

[v3,0/2] pinctrl: zynqmp: Support muxing individual pins

Message ID 20240610223550.2449230-1-sean.anderson@linux.dev
Headers show
Series pinctrl: zynqmp: Support muxing individual pins | expand

Message

Sean Anderson June 10, 2024, 10:35 p.m. UTC 
This series adds support for muxing individual pins, instead of
requiring groups to be muxed together. See [1] for additional
discussion.

[1] https://lore.kernel.org/linux-arm-kernel/5bb0dc7e-4c89-4f3d-abc6-41ae9ded5ae9@linux.dev/

Changes in v3:
- Express groups/pins exclusivity using oneOf
- Fix zynqmp_pinmux_set_mux and zynqmp_pinconf_group_set not handling
  "pin" groups (thanks Sai Krishna).

Changes in v2:
- Use __set_bit instead of set_bit
- Use size_add when calculating the number of kcalloc members
- Expand commit message with some more motivation

Sean Anderson (2):
  dt-bindings: pinctrl: xilinx: Add support for function with pins
  pinctrl: zynqmp: Support muxing individual pins

 .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 349 +++++++++---------
 drivers/pinctrl/pinctrl-zynqmp.c              |  83 +++--
 2 files changed, 234 insertions(+), 198 deletions(-)

Comments

Michal Simek June 11, 2024, 7:30 a.m. UTC | #1 
On 6/11/24 00:35, Sean Anderson wrote:
> This series adds support for muxing individual pins, instead of
> requiring groups to be muxed together. See [1] for additional
> discussion.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/5bb0dc7e-4c89-4f3d-abc6-41ae9ded5ae9@linux.dev/
> 
> Changes in v3:
> - Express groups/pins exclusivity using oneOf
> - Fix zynqmp_pinmux_set_mux and zynqmp_pinconf_group_set not handling
>    "pin" groups (thanks Sai Krishna).
> 
> Changes in v2:
> - Use __set_bit instead of set_bit
> - Use size_add when calculating the number of kcalloc members
> - Expand commit message with some more motivation
> 
> Sean Anderson (2):
>    dt-bindings: pinctrl: xilinx: Add support for function with pins
>    pinctrl: zynqmp: Support muxing individual pins
> 
>   .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 349 +++++++++---------
>   drivers/pinctrl/pinctrl-zynqmp.c              |  83 +++--
>   2 files changed, 234 insertions(+), 198 deletions(-)
> 

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Linus Walleij June 17, 2024, 8:48 a.m. UTC | #2 
On Tue, Jun 11, 2024 at 12:37 AM Sean Anderson <sean.anderson@linux.dev> wrote:

> This series adds support for muxing individual pins, instead of
> requiring groups to be muxed together. See [1] for additional
> discussion.
>
> [1] https://lore.kernel.org/linux-arm-kernel/5bb0dc7e-4c89-4f3d-abc6-41ae9ded5ae9@linux.dev/
>
> Changes in v3:
> - Express groups/pins exclusivity using oneOf
> - Fix zynqmp_pinmux_set_mux and zynqmp_pinconf_group_set not handling
>   "pin" groups (thanks Sai Krishna).

OK Xilinx are happy, I'm OK with it.

Patches applied!

Yours,
Linus Walleij