| Message ID | 20240606023704.3931561-1-yangyingliang@huawei.com |
|---|---|
| Headers | show |
| Series | pinctrl: fix possible memory leak when pinctrl_enable() fails | expand |
On Thu, Jun 06, 2024 at 10:37:01AM +0800, Yang Yingliang wrote: > In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(), > the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release() > can not be called, it leads memory leak. > > And some driver calls pinctrl_register_and_init() which is not devm_ managed, > it also leads memory leak if pinctrl_enable() fails. > > To fix this, introduce pinctrl_uninit_controller(), call it in the error path to > free memory and replace pinctrl_register_and_init with devm_pinctrl_register_and_init. > > v1 -> v2: > Check pinctrl_enable() return value in pcs_probe() in patch #2 > > Yang Yingliang (3): > pinctrl: core: fix possible memory leak when pinctrl_enable() fails > pinctrl: single: fix possible memory leak when pinctrl_enable() fails > pinctrl: ti: ti-iodelay: fix possible memory leak when > pinctrl_enable() fails Thanks so much! Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> regards, dan carpenter
On Thu, Jun 6, 2024 at 4:39 AM Yang Yingliang <yangyingliang@huawei.com> wrote: > In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(), > the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release() > can not be called, it leads memory leak. > > And some driver calls pinctrl_register_and_init() which is not devm_ managed, > it also leads memory leak if pinctrl_enable() fails. > > To fix this, introduce pinctrl_uninit_controller(), call it in the error path to > free memory and replace pinctrl_register_and_init with devm_pinctrl_register_and_init. > > v1 -> v2: > Check pinctrl_enable() return value in pcs_probe() in patch #2 Patches applied as nonurgent fixes. Thanks Yang! Yours, Linus Walleij
In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(), the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release() can not be called, it leads memory leak. And some driver calls pinctrl_register_and_init() which is not devm_ managed, it also leads memory leak if pinctrl_enable() fails. To fix this, introduce pinctrl_uninit_controller(), call it in the error path to free memory and replace pinctrl_register_and_init with devm_pinctrl_register_and_init. v1 -> v2: Check pinctrl_enable() return value in pcs_probe() in patch #2 Yang Yingliang (3): pinctrl: core: fix possible memory leak when pinctrl_enable() fails pinctrl: single: fix possible memory leak when pinctrl_enable() fails pinctrl: ti: ti-iodelay: fix possible memory leak when pinctrl_enable() fails drivers/pinctrl/core.c | 12 +++++++++++- drivers/pinctrl/pinctrl-single.c | 7 ++++--- drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 11 ++++++----- 3 files changed, 21 insertions(+), 9 deletions(-)