mbox series

[0/7] watchdog_reset cleanup

Message ID 20240528111325.2163560-1-rasmus.villemoes@prevas.dk
Headers show
Series watchdog_reset cleanup | expand

Message

Rasmus Villemoes May 28, 2024, 11:13 a.m. UTC 
watchdog_reset is no more. That is, it is no longer called from
anywhere, so any leftover definitions are just dead weight, and
references in comments need to be updated.

I don't have access to any m68k, sh or powerpc boards. Only lightly
compile-tested.

Apart from the two sh4 patches, these are independent of each other
and can be applied individually.

Cc: Angelo Dureghello <angelo@kernel-space.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Huan Wang <alison.wang@nxp.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Rasmus Villemoes (7):
  m68k: remove dead code
  wdt-uclass: watchdog_reset cleanup
  serial: ns16550: fix comment to mention schedule instead of
    watchdog_reset
  sh4: move reset_cpu() from watchdog.c to cpu.c
  sh4: remove watchdog.c file
  powerpc: mpc83xx: remove unused watchdog_reset() function
  powerpc: mpc85xx: remove dead watchdog-related code

 arch/m68k/cpu/mcf52x2/cpu.c    | 108 ---------------------------------
 arch/powerpc/cpu/mpc83xx/cpu.c |  15 -----
 arch/powerpc/cpu/mpc85xx/cpu.c |  31 ----------
 arch/sh/cpu/sh4/Makefile       |   2 +-
 arch/sh/cpu/sh4/cpu.c          |  10 +++
 arch/sh/cpu/sh4/watchdog.c     |  61 -------------------
 drivers/serial/ns16550.c       |   8 +--
 drivers/watchdog/wdt-uclass.c  |  19 +-----
 include/watchdog.h             |   3 -
 9 files changed, 17 insertions(+), 240 deletions(-)
 delete mode 100644 arch/sh/cpu/sh4/watchdog.c

Comments

Angelo Dureghello May 29, 2024, 7:35 a.m. UTC | #1 
Hi Rasmus,


On 28/05/24 1:13 PM, Rasmus Villemoes wrote:
> watchdog_reset is no more. That is, it is no longer called from
> anywhere, so any leftover definitions are just dead weight, and
> references in comments need to be updated.
>
> I don't have access to any m68k, sh or powerpc boards. Only lightly
> compile-tested.
>
> Apart from the two sh4 patches, these are independent of each other
> and can be applied individually.

Thanks for the cleanup,

Acked-by: Angelo Dureghello <angelo@kernel-space.org>


> Cc: Angelo Dureghello <angelo@kernel-space.org>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> Rasmus Villemoes (7):
>    m68k: remove dead code
>    wdt-uclass: watchdog_reset cleanup
>    serial: ns16550: fix comment to mention schedule instead of
>      watchdog_reset
>    sh4: move reset_cpu() from watchdog.c to cpu.c
>    sh4: remove watchdog.c file
>    powerpc: mpc83xx: remove unused watchdog_reset() function
>    powerpc: mpc85xx: remove dead watchdog-related code
>
>   arch/m68k/cpu/mcf52x2/cpu.c    | 108 ---------------------------------
>   arch/powerpc/cpu/mpc83xx/cpu.c |  15 -----
>   arch/powerpc/cpu/mpc85xx/cpu.c |  31 ----------
>   arch/sh/cpu/sh4/Makefile       |   2 +-
>   arch/sh/cpu/sh4/cpu.c          |  10 +++
>   arch/sh/cpu/sh4/watchdog.c     |  61 -------------------
>   drivers/serial/ns16550.c       |   8 +--
>   drivers/watchdog/wdt-uclass.c  |  19 +-----
>   include/watchdog.h             |   3 -
>   9 files changed, 17 insertions(+), 240 deletions(-)
>   delete mode 100644 arch/sh/cpu/sh4/watchdog.c
>
Stefan Roese June 16, 2024, 10:13 a.m. UTC | #2 
On 5/28/24 13:13, Rasmus Villemoes wrote:
> watchdog_reset is no more. That is, it is no longer called from
> anywhere, so any leftover definitions are just dead weight, and
> references in comments need to be updated.
> 
> I don't have access to any m68k, sh or powerpc boards. Only lightly
> compile-tested.
> 
> Apart from the two sh4 patches, these are independent of each other
> and can be applied individually.
> 
> Cc: Angelo Dureghello <angelo@kernel-space.org>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Thanks for continuing the cleanup here:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> Rasmus Villemoes (7):
>    m68k: remove dead code
>    wdt-uclass: watchdog_reset cleanup
>    serial: ns16550: fix comment to mention schedule instead of
>      watchdog_reset
>    sh4: move reset_cpu() from watchdog.c to cpu.c
>    sh4: remove watchdog.c file
>    powerpc: mpc83xx: remove unused watchdog_reset() function
>    powerpc: mpc85xx: remove dead watchdog-related code
> 
>   arch/m68k/cpu/mcf52x2/cpu.c    | 108 ---------------------------------
>   arch/powerpc/cpu/mpc83xx/cpu.c |  15 -----
>   arch/powerpc/cpu/mpc85xx/cpu.c |  31 ----------
>   arch/sh/cpu/sh4/Makefile       |   2 +-
>   arch/sh/cpu/sh4/cpu.c          |  10 +++
>   arch/sh/cpu/sh4/watchdog.c     |  61 -------------------
>   drivers/serial/ns16550.c       |   8 +--
>   drivers/watchdog/wdt-uclass.c  |  19 +-----
>   include/watchdog.h             |   3 -
>   9 files changed, 17 insertions(+), 240 deletions(-)
>   delete mode 100644 arch/sh/cpu/sh4/watchdog.c
> 

Viele Grüße,
Stefan Roese
Stefan Roese June 16, 2024, 10:18 a.m. UTC | #3 
On 5/28/24 13:13, Rasmus Villemoes wrote:
> watchdog_reset is no more. That is, it is no longer called from
> anywhere, so any leftover definitions are just dead weight, and
> references in comments need to be updated.
> 
> I don't have access to any m68k, sh or powerpc boards. Only lightly
> compile-tested.
> 
> Apart from the two sh4 patches, these are independent of each other
> and can be applied individually.
> 
> Cc: Angelo Dureghello <angelo@kernel-space.org>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Applied to u-boot-watchdog/next

Thanks,
Stefan

> Rasmus Villemoes (7):
>    m68k: remove dead code
>    wdt-uclass: watchdog_reset cleanup
>    serial: ns16550: fix comment to mention schedule instead of
>      watchdog_reset
>    sh4: move reset_cpu() from watchdog.c to cpu.c
>    sh4: remove watchdog.c file
>    powerpc: mpc83xx: remove unused watchdog_reset() function
>    powerpc: mpc85xx: remove dead watchdog-related code
> 
>   arch/m68k/cpu/mcf52x2/cpu.c    | 108 ---------------------------------
>   arch/powerpc/cpu/mpc83xx/cpu.c |  15 -----
>   arch/powerpc/cpu/mpc85xx/cpu.c |  31 ----------
>   arch/sh/cpu/sh4/Makefile       |   2 +-
>   arch/sh/cpu/sh4/cpu.c          |  10 +++
>   arch/sh/cpu/sh4/watchdog.c     |  61 -------------------
>   drivers/serial/ns16550.c       |   8 +--
>   drivers/watchdog/wdt-uclass.c  |  19 +-----
>   include/watchdog.h             |   3 -
>   9 files changed, 17 insertions(+), 240 deletions(-)
>   delete mode 100644 arch/sh/cpu/sh4/watchdog.c
> 

Viele Grüße,
Stefan Roese