diff mbox series

[2/3] arm: dts: rockchip: rock-5a: enable USB3 OTG port

Message ID 20240615074639.1686-2-naoki@radxa.com
State New
Delegated to: Kever Yang
Headers show
Series [1/3] rockchip: rock-3a: rock5a: rock5b: add USB GADGET related configs | expand

Commit Message

FUKAUMI Naoki June 15, 2024, 7:46 a.m. UTC
enable USB3 OTG (upper) port for ums and rockusb commands on ROCK 5A.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Jonas Karlman June 16, 2024, 9:34 a.m. UTC | #1
On 2024-06-15 09:46, FUKAUMI Naoki wrote:
> enable USB3 OTG (upper) port for ums and rockusb commands on ROCK 5A.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> index efba0c359b..5ae1a3cdd9 100644
> --- a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> @@ -9,3 +9,19 @@
>  	cap-mmc-highspeed;
>  	mmc-hs200-1_8v;
>  };
> +
> +&u2phy0 {
> +	status = "okay";
> +};
> +
> +&u2phy0_otg {
> +	status = "okay";
> +};
> +
> +&usbdp_phy0 {
> +	status = "okay";
> +};
> +
> +&usb_host0_xhci {
> +	status = "okay";
> +};

Instead of adding new nodes to the u-boot.dtsi-file, please pick related
commits for dts/upstream tree when possible and remove any merged nodes.

E.g do something like following:
- base on u-boot-rockchip-next-20240615
- run: dts/update-dts-subtree.sh pick c233f1327b04279454217b826ebf648bd4bc6b8f
- run: dts/update-dts-subtree.sh pick 402af187821d4e38a6c687e868b26ba22cb82886
- remove u2phy1/usbdp_phy1/usb_host1_xhci from rock-5b u-boot.dtsi
and instead include those commits in a v2 :-)

Related devicetree-rebasing commits:

arm64: dts: rockchip: add upper USB3 port to rock-5a:
https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/commit/?id=c233f1327b04279454217b826ebf648bd4bc6b8f

arm64: dts: rockchip: add lower USB3 port to rock-5b
https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/commit/?id=402af187821d4e38a6c687e868b26ba22cb82886

Regards,
Jonas
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
index efba0c359b..5ae1a3cdd9 100644
--- a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
+++ b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
@@ -9,3 +9,19 @@ 
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;
 };
+
+&u2phy0 {
+	status = "okay";
+};
+
+&u2phy0_otg {
+	status = "okay";
+};
+
+&usbdp_phy0 {
+	status = "okay";
+};
+
+&usb_host0_xhci {
+	status = "okay";
+};