| Message ID | 20240614115340.4091211-1-d-gole@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [V2] arm: dts: k3-am625-beagleplay: Add symlinks for boot binaries | expand |
On Jun 14, 2024 at 17:23:40 +0530, Dhruva Gole wrote: > Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to > anyway rename these files to get the platform to boot up. > This just makes it more intuitive and convenient. > > Signed-off-by: Dhruva Gole <d-gole@ti.com> > --- > > Changes: > Add symlink for u-boot.img as well as per Manorit's suggestion. > > Link to prev. patch: > https://lore.kernel.org/u-boot/20240614084052.4029849-1-d-gole@ti.com/ > > Cc: Manorit Chawdhry <m-chawdhry@ti.com> > Cc: Nishant Menon <nm@ti.com> > Cc: Robert Nelson <robertcnelson@gmail.com> > [...] NAK. Please do not apply this patch, it seems that u-boot.img file didn't need a symlink in the first place as it was getting generated without a symlink. I am not sure why u-boot.img is special in this regard but tispl and tiboot3 still require the symlinks. I'll resend the first correct patch again. Please excuse the noise.
diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi index fb2032068d1c..77e6292d790f 100644 --- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi +++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi @@ -71,6 +71,7 @@ ti-spl_unsigned { filename = "tispl.bin_unsigned"; + symlink = "tispl.bin"; pad-byte = <0xff>; fit { @@ -157,6 +158,7 @@ u-boot_unsigned { filename = "u-boot.img_unsigned"; + symlink = "u-boot.img"; pad-byte = <0xff>; fit { diff --git a/arch/arm/dts/k3-am625-r5-beagleplay.dts b/arch/arm/dts/k3-am625-r5-beagleplay.dts index 9db58f093c8c..da6746e009d5 100644 --- a/arch/arm/dts/k3-am625-r5-beagleplay.dts +++ b/arch/arm/dts/k3-am625-r5-beagleplay.dts @@ -79,6 +79,7 @@ &binman { tiboot3-am62x-gp-evm.bin { filename = "tiboot3-am62x-gp-evm.bin"; + symlink = "tiboot3.bin"; ti-secure-rom { content = <&u_boot_spl_unsigned>, <&ti_fs_gp>, <&combined_tifs_cfg_gp>, <&combined_dm_cfg_gp>;
Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole <d-gole@ti.com> --- Changes: Add symlink for u-boot.img as well as per Manorit's suggestion. Link to prev. patch: https://lore.kernel.org/u-boot/20240614084052.4029849-1-d-gole@ti.com/ Cc: Manorit Chawdhry <m-chawdhry@ti.com> Cc: Nishant Menon <nm@ti.com> Cc: Robert Nelson <robertcnelson@gmail.com> arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 2 ++ arch/arm/dts/k3-am625-r5-beagleplay.dts | 1 + 2 files changed, 3 insertions(+) base-commit: 1ebd659cf020843fd8e8ef90d85a66941cbab6ec