| Message ID | 20240614033812.51312-1-animeshagarwal28@gmail.com |
|---|---|
| Headers | show |
| Series | ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema | expand |
On 14/06/2024 05:38, Animesh Agarwal wrote: > Hey all, > This patch series converts two of the thirteen realtek audio codec > bindings which are still in txt format to DT schema. I have chosen > these bindings as they have in tree DTS files. ... and the point of DTS is? To validate the DTS against bindings and see if they match. You received such feedback already. Best regards, Krzysztof
On Fri, Jun 14, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 14/06/2024 05:38, Animesh Agarwal wrote: > > Hey all, > > This patch series converts two of the thirteen realtek audio codec > > bindings which are still in txt format to DT schema. I have chosen > > these bindings as they have in tree DTS files. > > ... and the point of DTS is? > > To validate the DTS against bindings and see if they match. > > You received such feedback already. Hi Krzysztof, I'm afraid I don't understand your comment here. Animesh is saying that we are now looking only on bindings that are actually used in the dts files. We are no longer converting .txt files which have bindings not used in dts files.
On 17/06/2024 13:18, Daniel Baluta wrote: > On Fri, Jun 14, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 14/06/2024 05:38, Animesh Agarwal wrote: >>> Hey all, >>> This patch series converts two of the thirteen realtek audio codec >>> bindings which are still in txt format to DT schema. I have chosen >>> these bindings as they have in tree DTS files. >> >> ... and the point of DTS is? >> >> To validate the DTS against bindings and see if they match. >> >> You received such feedback already. > > Hi Krzysztof, > > I'm afraid I don't understand your comment here. > > Animesh is saying that we are now looking only on bindings that are > actually used in the dts files. Yes and then one should compare the DTS with the binding, because old bindings are often incomplete. Best regards, Krzysztof
On Mon, Jun 17, 2024 at 3:09 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 17/06/2024 13:18, Daniel Baluta wrote: > > On Fri, Jun 14, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On 14/06/2024 05:38, Animesh Agarwal wrote: > >>> Hey all, > >>> This patch series converts two of the thirteen realtek audio codec > >>> bindings which are still in txt format to DT schema. I have chosen > >>> these bindings as they have in tree DTS files. > >> > >> ... and the point of DTS is? > >> > >> To validate the DTS against bindings and see if they match. > >> > >> You received such feedback already. > > > > Hi Krzysztof, > > > > I'm afraid I don't understand your comment here. > > > > Animesh is saying that we are now looking only on bindings that are > > actually used in the dts files. > > Yes and then one should compare the DTS with the binding, because old > bindings are often incomplete. Got it. Means that if DTS has more properties or so we should document them in the yaml file. One thing is that the bindings/properties should have never been added in the dts without documenting them, but that's another story. OK, thanks for clarifications we will follow this advice.