diff mbox series

[libstdc++,testsuite] xfail double-prec from_chars for float128_t

Message ID orzfrrhsih.fsf@lxoliva.fsfla.org
State New
Headers show
Series [libstdc++,testsuite] xfail double-prec from_chars for float128_t | expand

Commit Message

Alexandre Oliva June 12, 2024, 1:14 a.m. UTC
Tests involving float128_t were xfailed or otherwise worked around for
vxworks on aarch64.  The same issue came up on rtems.  This patch
adjusts them similarly.

Regstrapping on x86_64-linux-gnu.  Also tested with gcc-13 on
aarch64-rtems6.  Ok to install?

(I'd have expected the fast_float limitation to come up with aarch64-elf
and any other aarch64 targets, but since I haven't observed it there,
I'm avoiding aarch64-*-*.)


for  libstdc++-v3/ChangeLog

	* testsuite/20_util/from_chars/8.cc: Skip float128_t testing
	on aarch64-rtems*.
	* testsuite/20_util/to_chars/float128_c++23.cc: Xfail run on
	aarch64-rtems*.
---
 libstdc++-v3/testsuite/20_util/from_chars/8.cc     |    2 +-
 .../testsuite/20_util/to_chars/float128_c++23.cc   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Wakely June 12, 2024, 7:18 a.m. UTC | #1
On Wed, 12 Jun 2024, 02:14 Alexandre Oliva, <oliva@adacore.com> wrote:

>
> Tests involving float128_t were xfailed or otherwise worked around for
> vxworks on aarch64.  The same issue came up on rtems.  This patch
> adjusts them similarly.
>
> Regstrapping on x86_64-linux-gnu.  Also tested with gcc-13 on
> aarch64-rtems6.  Ok to install?
>

OK


> (I'd have expected the fast_float limitation to come up with aarch64-elf
> and any other aarch64 targets, but since I haven't observed it there,
> I'm avoiding aarch64-*-*.)
>
>
> for  libstdc++-v3/ChangeLog
>
>         * testsuite/20_util/from_chars/8.cc: Skip float128_t testing
>         on aarch64-rtems*.
>         * testsuite/20_util/to_chars/float128_c++23.cc: Xfail run on
>         aarch64-rtems*.
> ---
>  libstdc++-v3/testsuite/20_util/from_chars/8.cc     |    2 +-
>  .../testsuite/20_util/to_chars/float128_c++23.cc   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/from_chars/8.cc
> b/libstdc++-v3/testsuite/20_util/from_chars/8.cc
> index a6343422c5a91..bacad89943b5f 100644
> --- a/libstdc++-v3/testsuite/20_util/from_chars/8.cc
> +++ b/libstdc++-v3/testsuite/20_util/from_chars/8.cc
> @@ -17,7 +17,7 @@
>
>  // { dg-do run { target c++23 } }
>  // { dg-add-options ieee }
> -// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target
> aarch64-*-vxworks* } }
> +// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target
> aarch64-*-vxworks* aarch64-*-rtems* } }
>
>  #include <charconv>
>  #include <string>
> diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
> b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
> index ca00761ee7c98..6cb9cadcd2041 100644
> --- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
> +++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
> @@ -19,7 +19,7 @@
>  // { dg-require-effective-target ieee_floats }
>  // { dg-require-effective-target size32plus }
>  // { dg-add-options ieee }
> -// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* } }
> +// { dg-xfail-run-if "from_chars limited to double-precision" {
> aarch64-*-vxworks* aarch64-*-rtems* } }
>
>  #include <charconv>
>  #include <stdfloat>
>
> --
> Alexandre Oliva, happy hacker            https://FSFLA.org/blogs/lxo/
>    Free Software Activist                   GNU Toolchain Engineer
> More tolerance and less prejudice are key for inclusion and diversity
> Excluding neuro-others for not behaving ""normal"" is *not* inclusive
>
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/20_util/from_chars/8.cc b/libstdc++-v3/testsuite/20_util/from_chars/8.cc
index a6343422c5a91..bacad89943b5f 100644
--- a/libstdc++-v3/testsuite/20_util/from_chars/8.cc
+++ b/libstdc++-v3/testsuite/20_util/from_chars/8.cc
@@ -17,7 +17,7 @@ 
 
 // { dg-do run { target c++23 } }
 // { dg-add-options ieee }
-// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-vxworks* } }
+// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-vxworks* aarch64-*-rtems* } }
 
 #include <charconv>
 #include <string>
diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
index ca00761ee7c98..6cb9cadcd2041 100644
--- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
+++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
@@ -19,7 +19,7 @@ 
 // { dg-require-effective-target ieee_floats }
 // { dg-require-effective-target size32plus }
 // { dg-add-options ieee }
-// { dg-xfail-run-if "from_chars limited to double-precision" { aarch64-*-vxworks* } }
+// { dg-xfail-run-if "from_chars limited to double-precision" { aarch64-*-vxworks* aarch64-*-rtems* } }
 
 #include <charconv>
 #include <stdfloat>