| Message ID | 20240607115304.86028-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [KIRK,1/1] README: Document passing environment variables | expand |
Hi! LGTM Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> On 6/7/24 13:53, Petr Vorel wrote: > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > README.md | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/README.md b/README.md > index 72e5c56..cb69049 100644 > --- a/README.md > +++ b/README.md > @@ -104,6 +104,10 @@ Some basic commands are the following: > --sut ssh:host=myhost.com:user=root:key_file=myhost_id_rsa \ > --run-suite syscalls --workers 16 > > + # pass environment variables (list of key=value separated by ':') > + ./kirk --framework ltp --run-suite net.features \ > + --env 'VIRT_PERF_THRESHOLD=180:LTP_NET_FEATURES_IGNORE_PERFORMANCE_FAILURE=1' > + > It's possible to run a single command before running testing suites using > `--run-command` option as following: > Andrea
Hi Andrea, > Hi! > LGTM > Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> Thanks, merged as https://github.com/linux-test-project/kirk/commit/5e8c8064a0b2cee465f2a1dca1cfebef5ade36a2 BTW I wonder if recent kirk commits (SSH fixes) are strong enough to release kirk and update LTP. WDYT? Or do you wait for ltx improvements before releasing new version? Kind regards, Petr
On 6/10/24 11:32, Petr Vorel wrote: > Hi Andrea, > >> Hi! >> LGTM >> Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> > Thanks, merged as > https://github.com/linux-test-project/kirk/commit/5e8c8064a0b2cee465f2a1dca1cfebef5ade36a2 > > BTW I wonder if recent kirk commits (SSH fixes) are strong enough to release > kirk and update LTP. WDYT? Or do you wait for ltx improvements before releasing > new version? > > Kind regards, > Petr There were really minor updates in kirk. We can probably create a new version after more features will be added, but I have no idea when. Andrea
> On 6/10/24 11:32, Petr Vorel wrote: > > Hi Andrea, > > > Hi! > > > LGTM > > > Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> > > Thanks, merged as > > https://github.com/linux-test-project/kirk/commit/5e8c8064a0b2cee465f2a1dca1cfebef5ade36a2 > > BTW I wonder if recent kirk commits (SSH fixes) are strong enough to release > > kirk and update LTP. WDYT? Or do you wait for ltx improvements before releasing > > new version? > > Kind regards, > > Petr > There were really minor updates in kirk. We can probably create a new > version after more features will be added, but I have no idea when. OK, thanks for info. From the description they looks as a real bug fixes which would users appreciated. Kind regards, Petr > Andrea
On 6/10/24 12:57, Petr Vorel wrote: >> On 6/10/24 11:32, Petr Vorel wrote: >>> Hi Andrea, >>>> Hi! >>>> LGTM >>>> Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> >>> Thanks, merged as >>> https://github.com/linux-test-project/kirk/commit/5e8c8064a0b2cee465f2a1dca1cfebef5ade36a2 >>> BTW I wonder if recent kirk commits (SSH fixes) are strong enough to release >>> kirk and update LTP. WDYT? Or do you wait for ltx improvements before releasing >>> new version? >>> Kind regards, >>> Petr >> There were really minor updates in kirk. We can probably create a new >> version after more features will be added, but I have no idea when. > OK, thanks for info. From the description they looks as a real bug fixes which > would users appreciated. > > Kind regards, > Petr > >> Andrea Yeah, now that I'm taking a closer look I think you are right. Let's make a new kirk version then. Thank, Andrea
diff --git a/README.md b/README.md index 72e5c56..cb69049 100644 --- a/README.md +++ b/README.md @@ -104,6 +104,10 @@ Some basic commands are the following: --sut ssh:host=myhost.com:user=root:key_file=myhost_id_rsa \ --run-suite syscalls --workers 16 + # pass environment variables (list of key=value separated by ':') + ./kirk --framework ltp --run-suite net.features \ + --env 'VIRT_PERF_THRESHOLD=180:LTP_NET_FEATURES_IGNORE_PERFORMANCE_FAILURE=1' + It's possible to run a single command before running testing suites using `--run-command` option as following:
Signed-off-by: Petr Vorel <pvorel@suse.cz> --- README.md | 4 ++++ 1 file changed, 4 insertions(+)