| Message ID | 20240607-md-drivers-pwm-v1-1-27237a2bec6a@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | pwm: add missing MODULE_DESCRIPTION() macros | expand |
Hello, On Fri, Jun 07, 2024 at 09:02:33AM -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > This addresses all of the issues in driver/pwm > > Let me know if you want any of the individual module changes > segregated into separate patches. Looks good to me, I applied it to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next Thanks Uwe
Il 07/06/24 18:02, Jeff Johnson ha scritto: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > This addresses all of the issues in driver/pwm > > Let me know if you want any of the individual module changes > segregated into separate patches. > --- > drivers/pwm/pwm-imx1.c | 1 + > drivers/pwm/pwm-imx27.c | 1 + > drivers/pwm/pwm-intel-lgm.c | 1 + > drivers/pwm/pwm-mediatek.c | 1 + > drivers/pwm/pwm-pxa.c | 1 + > drivers/pwm/pwm-samsung.c | 1 + > drivers/pwm/pwm-spear.c | 1 + > drivers/pwm/pwm-visconti.c | 1 + > 8 files changed, 8 insertions(+) > ..snip.. > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index 19a87873ad60..0b5d68a90e83 100644 > --- a/drivers/pwm/pwm-mediatek.c > +++ b/drivers/pwm/pwm-mediatek.c > @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = { > module_platform_driver(pwm_mediatek_driver); > > MODULE_AUTHOR("John Crispin <blogic@openwrt.org>"); > +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver"); MediaTek SoCs have got two different PWM IPs, one of which is used exclusively for the Display PWM, and it is located in the DDP block. So, there are two PWM IPs in one SoC: - A general purpose PWM IP - A DDP PWM IP This driver is for the general purpose PWM IP.. so, please, can we change this to "MediaTek general purpose Pulse Width Modulator driver"? After which, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > MODULE_LICENSE("GPL v2");
Hello, On Mon, Jun 10, 2024 at 10:06:49AM +0200, AngeloGioacchino Del Regno wrote: > Il 07/06/24 18:02, Jeff Johnson ha scritto: > > [...] > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > > index 19a87873ad60..0b5d68a90e83 100644 > > --- a/drivers/pwm/pwm-mediatek.c > > +++ b/drivers/pwm/pwm-mediatek.c > > @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = { > > module_platform_driver(pwm_mediatek_driver); > > MODULE_AUTHOR("John Crispin <blogic@openwrt.org>"); > > +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver"); > > MediaTek SoCs have got two different PWM IPs, one of which is used exclusively > for the Display PWM, and it is located in the DDP block. > > So, there are two PWM IPs in one SoC: > - A general purpose PWM IP > - A DDP PWM IP > > This driver is for the general purpose PWM IP.. so, please, can we change this > to "MediaTek general purpose Pulse Width Modulator driver"? > > After which, > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Looks like a reasonable request. @Jeff: Can you please resend with the suggested change, I dropped the patch from for-next now. Best regards Uwe
On 6/10/2024 1:06 AM, AngeloGioacchino Del Regno wrote: > Il 07/06/24 18:02, Jeff Johnson ha scritto: >> make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >> --- >> This addresses all of the issues in driver/pwm >> >> Let me know if you want any of the individual module changes >> segregated into separate patches. >> --- >> drivers/pwm/pwm-imx1.c | 1 + >> drivers/pwm/pwm-imx27.c | 1 + >> drivers/pwm/pwm-intel-lgm.c | 1 + >> drivers/pwm/pwm-mediatek.c | 1 + >> drivers/pwm/pwm-pxa.c | 1 + >> drivers/pwm/pwm-samsung.c | 1 + >> drivers/pwm/pwm-spear.c | 1 + >> drivers/pwm/pwm-visconti.c | 1 + >> 8 files changed, 8 insertions(+) >> > > ..snip.. > >> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c >> index 19a87873ad60..0b5d68a90e83 100644 >> --- a/drivers/pwm/pwm-mediatek.c >> +++ b/drivers/pwm/pwm-mediatek.c >> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = { >> module_platform_driver(pwm_mediatek_driver); >> >> MODULE_AUTHOR("John Crispin <blogic@openwrt.org>"); >> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver"); > > MediaTek SoCs have got two different PWM IPs, one of which is used exclusively > for the Display PWM, and it is located in the DDP block. > > So, there are two PWM IPs in one SoC: > - A general purpose PWM IP > - A DDP PWM IP > > This driver is for the general purpose PWM IP.. so, please, can we change this > to "MediaTek general purpose Pulse Width Modulator driver"? > > After which, > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> MODULE_LICENSE("GPL v2"); > Sure, I'll update these in v2
On 6/10/2024 2:05 AM, Uwe Kleine-König wrote: > Hello, > > On Mon, Jun 10, 2024 at 10:06:49AM +0200, AngeloGioacchino Del Regno wrote: >> Il 07/06/24 18:02, Jeff Johnson ha scritto: >>> [...] >>> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c >>> index 19a87873ad60..0b5d68a90e83 100644 >>> --- a/drivers/pwm/pwm-mediatek.c >>> +++ b/drivers/pwm/pwm-mediatek.c >>> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = { >>> module_platform_driver(pwm_mediatek_driver); >>> MODULE_AUTHOR("John Crispin <blogic@openwrt.org>"); >>> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver"); >> >> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively >> for the Display PWM, and it is located in the DDP block. >> >> So, there are two PWM IPs in one SoC: >> - A general purpose PWM IP >> - A DDP PWM IP >> >> This driver is for the general purpose PWM IP.. so, please, can we change this >> to "MediaTek general purpose Pulse Width Modulator driver"? >> >> After which, >> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Looks like a reasonable request. > > @Jeff: Can you please resend with the suggested change, I dropped the > patch from for-next now. No problem, v2 sent. /jeff
diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c index 1d2aae2d278f..d5535d208005 100644 --- a/drivers/pwm/pwm-imx1.c +++ b/drivers/pwm/pwm-imx1.c @@ -194,5 +194,6 @@ static struct platform_driver pwm_imx1_driver = { }; module_platform_driver(pwm_imx1_driver); +MODULE_DESCRIPTION("i.MX1 and i.MX21 Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>"); diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index e1412116ef65..9e2bbf5b4a8c 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -352,5 +352,6 @@ static struct platform_driver imx_pwm_driver = { }; module_platform_driver(imx_pwm_driver); +MODULE_DESCRIPTION("i.MX27 and later i.MX SoCs Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>"); diff --git a/drivers/pwm/pwm-intel-lgm.c b/drivers/pwm/pwm-intel-lgm.c index f9cc7c17c8f0..084c71a0a11b 100644 --- a/drivers/pwm/pwm-intel-lgm.c +++ b/drivers/pwm/pwm-intel-lgm.c @@ -230,4 +230,5 @@ static struct platform_driver lgm_pwm_driver = { }; module_platform_driver(lgm_pwm_driver); +MODULE_DESCRIPTION("Intel LGM Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c index 19a87873ad60..0b5d68a90e83 100644 --- a/drivers/pwm/pwm-mediatek.c +++ b/drivers/pwm/pwm-mediatek.c @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = { module_platform_driver(pwm_mediatek_driver); MODULE_AUTHOR("John Crispin <blogic@openwrt.org>"); +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index bb7bb48b2e6d..430bd6a709e9 100644 --- a/drivers/pwm/pwm-pxa.c +++ b/drivers/pwm/pwm-pxa.c @@ -208,4 +208,5 @@ static struct platform_driver pwm_driver = { module_platform_driver(pwm_driver); +MODULE_DESCRIPTION("PXA Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index efb60c9f0cb3..7adf4f2b1049 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -644,6 +644,7 @@ static struct platform_driver pwm_samsung_driver = { }; module_platform_driver(pwm_samsung_driver); +MODULE_DESCRIPTION("Samsung Pulse Width Modulator driver"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Tomasz Figa <tomasz.figa@gmail.com>"); MODULE_ALIAS("platform:samsung-pwm"); diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c index 6c6f3b38c835..4f372279f313 100644 --- a/drivers/pwm/pwm-spear.c +++ b/drivers/pwm/pwm-spear.c @@ -255,6 +255,7 @@ static struct platform_driver spear_pwm_driver = { module_platform_driver(spear_pwm_driver); +MODULE_DESCRIPTION("ST Microelectronics SPEAr Pulse Width Modulator driver"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Shiraz Hashim <shiraz.linux.kernel@gmail.com>"); MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.com>"); diff --git a/drivers/pwm/pwm-visconti.c b/drivers/pwm/pwm-visconti.c index 9e55380957be..28fae4979e3f 100644 --- a/drivers/pwm/pwm-visconti.c +++ b/drivers/pwm/pwm-visconti.c @@ -170,6 +170,7 @@ static struct platform_driver visconti_pwm_driver = { }; module_platform_driver(visconti_pwm_driver); +MODULE_DESCRIPTION("Toshiba Visconti Pulse Width Modulator driver"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>"); MODULE_ALIAS("platform:pwm-visconti");
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- This addresses all of the issues in driver/pwm Let me know if you want any of the individual module changes segregated into separate patches. --- drivers/pwm/pwm-imx1.c | 1 + drivers/pwm/pwm-imx27.c | 1 + drivers/pwm/pwm-intel-lgm.c | 1 + drivers/pwm/pwm-mediatek.c | 1 + drivers/pwm/pwm-pxa.c | 1 + drivers/pwm/pwm-samsung.c | 1 + drivers/pwm/pwm-spear.c | 1 + drivers/pwm/pwm-visconti.c | 1 + 8 files changed, 8 insertions(+) --- base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4 change-id: 20240607-md-drivers-pwm-8f4d8dde88d0