| Message ID | 20240607093055.160537-1-martin.kalcok@canonical.com |
|---|---|
| State | Accepted |
| Commit | 8b405f45d5f1fd112d19526e609e6669038f8974 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [ovs-dev,v2] ovsdb-client: Add "COLUMN" arg to help for 'dump'. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Fri, Jun 07, 2024 at 11:30:55AM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping a specific column's contents if the user supplies the > column's name as a fourth positional argument. > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> Acked-by: Simon Horman <horms@ovn.org>
On Fri, Jun 07, 2024 at 11:30:55AM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping a specific column's contents if the user supplies the > column's name as a fourth positional argument. > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> Thanks Martin, Applied. - ovsdb-client: Add "COLUMN" arg to help for 'dump'. https://github.com/openvswitch/ovs/commit/8b405f45d5f1
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index cf2ecfd08..b7b189c7e 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -451,9 +451,9 @@ usage(void) " wait until DATABASE reaches STATE " "(\"added\" or \"connected\" or \"removed\")\n" " in DATBASE on SERVER.\n" - "\n dump [SERVER] [DATABASE] [TABLE]\n" - " dump contents of TABLE (or all tables) in DATABASE on SERVER\n" - " to stdout\n" + "\n dump [SERVER] [DATABASE] [TABLE [COLUMN]...]\n" + " dump contents of COLUMNs, TABLE (or all tables) in DATABASE\n" + " on SERVER to stdout\n" "\n backup [SERVER] [DATABASE] > SNAPSHOT\n" " dump database contents in the form of a database file\n" "\n [--force] restore [SERVER] [DATABASE] < SNAPSHOT\n"
Help text for 'ovsdb-client dump' does not mention that it's capable of dumping a specific column's contents if the user supplies the column's name as a fourth positional argument. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> --- ovsdb/ovsdb-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)