| Message ID | 20240603132721.6522-1-hal.feng@starfivetech.com |
|---|---|
| Headers | show |
| Series | Sync StarFive JH7110 clock and reset dt-bindings with Linux | expand |
Hi Hal, Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for JH7110 ? -E On Mon, Jun 3, 2024 at 6:57 AM Hal Feng <hal.feng@starfivetech.com> wrote: > > There are differences in clock / reset dt-bindings between U-Boot and > Linux. Sync them, so it is feasible to use OF_UPSTREAM for StarFive > JH7110 SoC. > > Hal Feng (4): > dt-bindings: clock: jh7110: Sync with Linux > dt-bindings: reset: jh7110: Sync with Linux > clk: starfive: jh7110: Sync clock definitions with Linux > riscv: dts: jh7110: Sync clock and reset definitions with Linux > > .../dts/jh7110-starfive-visionfive-2.dtsi | 6 +- > arch/riscv/dts/jh7110-u-boot.dtsi | 2 +- > arch/riscv/dts/jh7110.dtsi | 28 +-- > drivers/clk/starfive/clk-jh7110-pll.c | 6 +- > drivers/clk/starfive/clk-jh7110.c | 44 ++--- > .../dt-bindings/clock/starfive,jh7110-crg.h | 180 +++++++++++------- > .../dt-bindings/reset/starfive,jh7110-crg.h | 144 ++++++++------ > 7 files changed, 243 insertions(+), 167 deletions(-) > > > base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0 > -- > 2.43.2 >
> On 04.06.24 04:32, E Shattow wrote: > Hi Hal, > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > JH7110 ? Yeah, I will try to do it recently, although I am not sure whether the U-Boot drivers and Linux drivers are compatible so that they can use the same DT. Best regards, Hal > > > On Mon, Jun 3, 2024 at 6:57 AM Hal Feng <hal.feng@starfivetech.com> wrote: > > > > There are differences in clock / reset dt-bindings between U-Boot and > > Linux. Sync them, so it is feasible to use OF_UPSTREAM for StarFive > > JH7110 SoC. > > > > Hal Feng (4): > > dt-bindings: clock: jh7110: Sync with Linux > > dt-bindings: reset: jh7110: Sync with Linux > > clk: starfive: jh7110: Sync clock definitions with Linux > > riscv: dts: jh7110: Sync clock and reset definitions with Linux > > > > .../dts/jh7110-starfive-visionfive-2.dtsi | 6 +- > > arch/riscv/dts/jh7110-u-boot.dtsi | 2 +- > > arch/riscv/dts/jh7110.dtsi | 28 +-- > > drivers/clk/starfive/clk-jh7110-pll.c | 6 +- > > drivers/clk/starfive/clk-jh7110.c | 44 ++--- > > .../dt-bindings/clock/starfive,jh7110-crg.h | 180 +++++++++++------- > > .../dt-bindings/reset/starfive,jh7110-crg.h | 144 ++++++++------ > > 7 files changed, 243 insertions(+), 167 deletions(-) > > > > > > base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0 > > -- > > 2.43.2 > >
On Wed, Jun 05, 2024 at 01:56:13AM +0000, Hal Feng wrote: > > On 04.06.24 04:32, E Shattow wrote: > > Hi Hal, > > > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > > JH7110 ? > > Yeah, I will try to do it recently, although I am not sure whether the U-Boot > drivers and Linux drivers are compatible so that they can use the same DT. They must be compatible so that they can use the same DT, U-Boot needs updating if it doesn't match.
On Wed, Jun 05, 2024 at 08:35:15AM -0600, Tom Rini wrote: > On Wed, Jun 05, 2024 at 01:56:13AM +0000, Hal Feng wrote: > > > On 04.06.24 04:32, E Shattow wrote: > > > Hi Hal, > > > > > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > > > JH7110 ? > > > > Yeah, I will try to do it recently, although I am not sure whether the U-Boot > > drivers and Linux drivers are compatible so that they can use the same DT. > > They must be compatible so that they can use the same DT, U-Boot needs > updating if it doesn't match. Other than the naming, I think they are compatible. IIRC there were some issues where U-Boot originally used different numbers to linux, but this was fixed in commit 9a12e304dd ("dt-bindings: clock: jh7110: Modify clock id to be same with Linux").
> On 05.06.24 23:38, Conor Dooley wrote: > On Wed, Jun 05, 2024 at 08:35:15AM -0600, Tom Rini wrote: > > On Wed, Jun 05, 2024 at 01:56:13AM +0000, Hal Feng wrote: > > > > On 04.06.24 04:32, E Shattow wrote: > > > > Hi Hal, > > > > > > > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM > > > > for > > > > JH7110 ? > > > > > > Yeah, I will try to do it recently, although I am not sure whether > > > the U-Boot drivers and Linux drivers are compatible so that they can use the > same DT. > > > > They must be compatible so that they can use the same DT, U-Boot needs > > updating if it doesn't match. > > Other than the naming, I think they are compatible. IIRC there were some issues > where U-Boot originally used different numbers to linux, but this was fixed in > commit 9a12e304dd ("dt-bindings: clock: jh7110: Modify clock id to be same > with Linux"). I found the Linux DT of VisionFive 2 can not be applied to U-Boot directly. Some issues need to be fixed such as making drivers compatible with Linux DT, unifying DT names. I am preparing a new patchset. When I finish coding and testing, I will send it out. Best regards, Hal