diff mbox series

[4/4] dt-bindings: gpio: aspeed,sgpio: Require #interrupt-cells

Message ID 20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-4-91c42976833b@codeconstruct.com.au
State New
Headers show
Series dt-bindings: gpio: aspeed,sgpio: Miscellaneous cleanups | expand

Commit Message

Andrew Jeffery May 29, 2024, 5:13 a.m. UTC
It shouldn't have been the case that it wasn't required. The kernel
devicetrees already specified it where compatible nodes were defined,
and u-boot pulls in the kernel devicetrees, so this should have minimal
practical impact.

Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
 Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski May 29, 2024, 7:28 a.m. UTC | #1
On 29/05/2024 07:13, Andrew Jeffery wrote:
> It shouldn't have been the case that it wasn't required. The kernel
> devicetrees already specified it where compatible nodes were defined,
> and u-boot pulls in the kernel devicetrees, so this should have minimal
> practical impact.
> 

This should be squashed with previous patch.

Best regards,
Krzysztof
Andrew Jeffery May 30, 2024, 12:54 a.m. UTC | #2
On Wed, 2024-05-29 at 09:28 +0200, Krzysztof Kozlowski wrote:
> On 29/05/2024 07:13, Andrew Jeffery wrote:
> > It shouldn't have been the case that it wasn't required. The kernel
> > devicetrees already specified it where compatible nodes were defined,
> > and u-boot pulls in the kernel devicetrees, so this should have minimal
> > practical impact.
> > 
> 
> This should be squashed with previous patch.
> 

Sure, will do.

Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
index 02c02ef97565..433b50bd5484 100644
--- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
@@ -62,6 +62,7 @@  required:
   - clocks
   - interrupts
   - interrupt-controller
+  - '#interrupt-cells'
   - gpio-controller
   - '#gpio-cells'
   - ngpios