| Message ID | 20240527014759.6586-1-yw987194828@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | sysdeps/x86_64/dl-machine.h: Add space for ease of retrieval | expand |
* Xin Wang: > A space is added before the left bracket of the ia64 elf_machine_rela > function, in order to harmonize with the rest of the implementation of > the function and to make it easier to retrieve the function. > > Signed-off-by: Xin Wang <yw987194828@gmail.com> --- > sysdeps/x86_64/dl-machine.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h > index ff5d45f7cb..1088267691 100644 > --- a/sysdeps/x86_64/dl-machine.h > +++ b/sysdeps/x86_64/dl-machine.h > @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc, > MAP is the object containing the reloc. */ > > static inline void __attribute__((always_inline)) > -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[], > +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], > const ElfW(Rela) *reloc, const ElfW(Sym) *sym, > const struct r_found_version *version, > void *const reloc_addr_arg, int skip_ifunc) { Please re-indent the following lines as well. Thanks, Florian
On Mai 27 2024, Florian Weimer wrote: > * Xin Wang: > >> A space is added before the left bracket of the ia64 elf_machine_rela >> function, in order to harmonize with the rest of the implementation of >> the function and to make it easier to retrieve the function. >> >> Signed-off-by: Xin Wang <yw987194828@gmail.com> > --- >> sysdeps/x86_64/dl-machine.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h >> index ff5d45f7cb..1088267691 100644 >> --- a/sysdeps/x86_64/dl-machine.h >> +++ b/sysdeps/x86_64/dl-machine.h >> @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc, >> MAP is the object containing the reloc. */ >> >> static inline void __attribute__((always_inline)) >> -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[], >> +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], >> const ElfW(Rela) *reloc, const ElfW(Sym) *sym, >> const struct r_found_version *version, >> void *const reloc_addr_arg, int skip_ifunc) { > > Please re-indent the following lines as well. Including the misplaced brace.
On Mon, 2024-05-27 at 15:15 +0200, Andreas Schwab wrote: > On Mai 27 2024, Florian Weimer wrote: > > > * Xin Wang: > > > > > A space is added before the left bracket of the ia64 elf_machine_rela Please reword the commit message: ia64 is not supported by Glibc (as at now) and it's completely different from x86_64. > > > function, in order to harmonize with the rest of the implementation of > > > the function and to make it easier to retrieve the function. > > > > > > Signed-off-by: Xin Wang <yw987194828@gmail.com> > > --- > > > sysdeps/x86_64/dl-machine.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h > > > index ff5d45f7cb..1088267691 100644 > > > --- a/sysdeps/x86_64/dl-machine.h > > > +++ b/sysdeps/x86_64/dl-machine.h > > > @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc, > > > MAP is the object containing the reloc. */ > > > > > > static inline void __attribute__((always_inline)) > > > -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[], > > > +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], > > > const ElfW(Rela) *reloc, const ElfW(Sym) *sym, > > > const struct r_found_version *version, > > > void *const reloc_addr_arg, int skip_ifunc) { > > > > Please re-indent the following lines as well. > > Including the misplaced brace. >
diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h index ff5d45f7cb..1088267691 100644 --- a/sysdeps/x86_64/dl-machine.h +++ b/sysdeps/x86_64/dl-machine.h @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc, MAP is the object containing the reloc. */ static inline void __attribute__((always_inline)) -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[], +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], const ElfW(Rela) *reloc, const ElfW(Sym) *sym, const struct r_found_version *version, void *const reloc_addr_arg, int skip_ifunc) {
A space is added before the left bracket of the ia64 elf_machine_rela function, in order to harmonize with the rest of the implementation of the function and to make it easier to retrieve the function. Signed-off-by: Xin Wang <yw987194828@gmail.com> --- sysdeps/x86_64/dl-machine.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)