| Message ID | 20240520185617.16702-1-fnordahl@ubuntu.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev] tests: Ignore ovs-vswitchd received packet on unknown port. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Mon, May 20, 2024 at 8:56 PM Frode Nordahl <fnordahl@ubuntu.com> wrote: > The ovs-vswitchd daemon may in some situations, typically during > teardown, log a warning level message 'received packet on unknown > port ...'. > > Ignore this message. > > Reported-at: https://launchpad.net/bugs/2066194 > Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> > Hi Frode, thank you for the fix, I have one concern, could we potentially hide some bug by ignoring this message? I know that during teardown it's harmful because the port might be already gone. --- > tests/ovn-macros.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at > index 32ab3b69f..3606b5fe3 100644 > --- a/tests/ovn-macros.at > +++ b/tests/ovn-macros.at > @@ -101,6 +101,7 @@ m4_define([OVN_CLEANUP_SBOX],[ > /receive tunnel port not found*/d > /Failed to locate tunnel to reach main chassis/d > /Transaction causes multiple rows.*MAC_Binding/d > + /received packet on unknown port/d > " $sbox]) > ]) > > -- > 2.43.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Thanks, Ales
On Wed, May 22, 2024 at 9:48 AM Ales Musil <amusil@redhat.com> wrote: > > > On Mon, May 20, 2024 at 8:56 PM Frode Nordahl <fnordahl@ubuntu.com> wrote: > >> The ovs-vswitchd daemon may in some situations, typically during >> teardown, log a warning level message 'received packet on unknown >> port ...'. >> >> Ignore this message. >> >> Reported-at: https://launchpad.net/bugs/2066194 >> Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> >> > > Hi Frode, > > thank you for the fix, I have one concern, could we potentially hide some > bug by ignoring this message? > I know that during teardown it's harmful because the port might be already > gone. > Hello, Ales, Thank you for taking the time to review! That is a good question, I did indeed have the same thought, but the way the macros are currently laid out this was the only place to do it. Adding it to this specific test also feels wrong as it appears this message could potentially be emitted for every test given the right conditions. For this specific failure it appears to me that the message is benign, but we never know what else might crop up in the future. What would you think about performing the log check prior to teardown as opposed to after teardown as we do now? Or perhaps we could do both with different sets of ignored lists? -- Frode Nordahl > --- >> tests/ovn-macros.at | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at >> index 32ab3b69f..3606b5fe3 100644 >> --- a/tests/ovn-macros.at >> +++ b/tests/ovn-macros.at >> @@ -101,6 +101,7 @@ m4_define([OVN_CLEANUP_SBOX],[ >> /receive tunnel port not found*/d >> /Failed to locate tunnel to reach main chassis/d >> /Transaction causes multiple rows.*MAC_Binding/d >> + /received packet on unknown port/d >> " $sbox]) >> ]) >> >> -- >> 2.43.0 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Thanks, > Ales > -- > > Ales Musil > > Senior Software Engineer - OVN Core > > Red Hat EMEA <https://www.redhat.com> > > amusil@redhat.com > <https://red.ht/sig> >
On Wed, May 22, 2024 at 9:59 AM Frode Nordahl <fnordahl@ubuntu.com> wrote: > > > On Wed, May 22, 2024 at 9:48 AM Ales Musil <amusil@redhat.com> wrote: > >> >> >> On Mon, May 20, 2024 at 8:56 PM Frode Nordahl <fnordahl@ubuntu.com> >> wrote: >> >>> The ovs-vswitchd daemon may in some situations, typically during >>> teardown, log a warning level message 'received packet on unknown >>> port ...'. >>> >>> Ignore this message. >>> >>> Reported-at: https://launchpad.net/bugs/2066194 >>> Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> >>> >> >> Hi Frode, >> >> thank you for the fix, I have one concern, could we potentially hide some >> bug by ignoring this message? >> I know that during teardown it's harmful because the port might be >> already gone. >> > > Hello, Ales, Thank you for taking the time to review! > > That is a good question, I did indeed have the same thought, but the way > the macros are currently laid out this was the only place to do it. Adding > it to this specific test also feels wrong as it appears this message could > potentially be emitted for every test given the right conditions. > > For this specific failure it appears to me that the message is benign, but > we never know what else might crop up in the future. > > What would you think about performing the log check prior to teardown as > opposed to after teardown as we do now? Or perhaps we could do both with > different sets of ignored lists? > > Actually looking at the list that we already have there is already "receive tunnel port not found" which feels to be similar to this. Having two separate sets might work out, however we would need to check in the second call for the same stuff + some extra, but from this point of view it might be safer. > > -- > Frode Nordahl > > >> --- >>> tests/ovn-macros.at | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at >>> index 32ab3b69f..3606b5fe3 100644 >>> --- a/tests/ovn-macros.at >>> +++ b/tests/ovn-macros.at >>> @@ -101,6 +101,7 @@ m4_define([OVN_CLEANUP_SBOX],[ >>> /receive tunnel port not found*/d >>> /Failed to locate tunnel to reach main chassis/d >>> /Transaction causes multiple rows.*MAC_Binding/d >>> + /received packet on unknown port/d >>> " $sbox]) >>> ]) >>> >>> -- >>> 2.43.0 >>> >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>> >>> >> Thanks, >> Ales >> -- >> >> Ales Musil >> >> Senior Software Engineer - OVN Core >> >> Red Hat EMEA <https://www.redhat.com> >> >> amusil@redhat.com >> <https://red.ht/sig> >> > Thanks, Ales
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index 32ab3b69f..3606b5fe3 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -101,6 +101,7 @@ m4_define([OVN_CLEANUP_SBOX],[ /receive tunnel port not found*/d /Failed to locate tunnel to reach main chassis/d /Transaction causes multiple rows.*MAC_Binding/d + /received packet on unknown port/d " $sbox]) ])
The ovs-vswitchd daemon may in some situations, typically during teardown, log a warning level message 'received packet on unknown port ...'. Ignore this message. Reported-at: https://launchpad.net/bugs/2066194 Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> --- tests/ovn-macros.at | 1 + 1 file changed, 1 insertion(+)