mbox series

[v4,0/2] rockchip rk3399 port initialization fixes

Message ID 20240413004120.1099089-1-dlemoal@kernel.org
Headers show
Series rockchip rk3399 port initialization fixes | expand

Message

Damien Le Moal April 13, 2024, 12:41 a.m. UTC
A couple of patches to have the rockchip rk3399 host controller port
initialization follow the PCI specifications around PERST# signal timing
handling.

Changes from v3:
 - Fixed commit messages as suggested by Bjorn.

Changes from v2:
 - Use PCIE_T_PVPERL_MS macro in patch 1 (and remove useless comments).
 - Split second msleep() addition into patch 2 as suggested by Bjorn.

Changes from v1:
 - Add more specification details to the commit message.
 - Add missing msleep(100) after PERST# is deasserted.

Damien Le Moal (2):
  PCI: rockchip-host: Fix rockchip_pcie_host_init_port() PERST# handling
  PCI: rockchip-host: Wait 100ms after reset before starting configuration

 drivers/pci/controller/pcie-rockchip-host.c | 3 +++
 drivers/pci/pci.h                           | 7 +++++++
 2 files changed, 10 insertions(+)

Comments

Bjorn Helgaas May 15, 2024, 9:14 p.m. UTC | #1
On Sat, Apr 13, 2024 at 09:41:18AM +0900, Damien Le Moal wrote:
> A couple of patches to have the rockchip rk3399 host controller port
> initialization follow the PCI specifications around PERST# signal timing
> handling.
> 
> Changes from v3:
>  - Fixed commit messages as suggested by Bjorn.
> 
> Changes from v2:
>  - Use PCIE_T_PVPERL_MS macro in patch 1 (and remove useless comments).
>  - Split second msleep() addition into patch 2 as suggested by Bjorn.
> 
> Changes from v1:
>  - Add more specification details to the commit message.
>  - Add missing msleep(100) after PERST# is deasserted.
> 
> Damien Le Moal (2):
>   PCI: rockchip-host: Fix rockchip_pcie_host_init_port() PERST# handling
>   PCI: rockchip-host: Wait 100ms after reset before starting configuration
> 
>  drivers/pci/controller/pcie-rockchip-host.c | 3 +++
>  drivers/pci/pci.h                           | 7 +++++++
>  2 files changed, 10 insertions(+)

Both applied by Krzysztof with Mani's Reviewed-by to
pci/controller/rockchip, but his outgoing mail queue got stuck.  It's
really too late, but trying to squeeze this into v6.10.
Krzysztof Wilczy��ski May 17, 2024, 11:19 a.m. UTC | #2
> A couple of patches to have the rockchip rk3399 host controller port
> initialization follow the PCI specifications around PERST# signal timing
> handling.

Applied to controller/rockchip, thank you!

[01/02] PCI: rockchip-host: Fix rockchip_pcie_host_init_port() PERST# handling
        https://git.kernel.org/pci/pci/c/3392b74f3065
[02/02] PCI: rockchip-host: Wait 100ms after reset before starting configuration
        https://git.kernel.org/pci/pci/c/46a610678fef

	Krzysztof