| Message ID | cover.1715688003.git.lorenzo@kernel.org |
|---|---|
| Headers | show |
| Series | Introduce Automated Frequency Coordination (AFC) support | expand |
On Tue, May 14, 2024 at 5:38 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > Introduce Automated Frequency Coordination (AFC) support for UNII-5 and UNII-7 > 6GHz bands. > Update Transmit Power Envelope (TPE) IE according to the reply from AFC > coordinator on UNII-5 or UNII-7 6GHz bands. > AFCD and AFC hostapd client are tested with AFC DUT Test Harness [0]. > > Changes since v5: > -rebased on top of hostapd main branch > Changes since v4: > - fix curl header parsing > - increase afc buffer size > - fix afc-reply.txt > - add some more error logging > - add sanity check for some afc config file data > Changes since v3: > - fix compilation errors when IEEE80211_AX is not enabled > - fix a leftover crash stopping the interface > - make sure rx buffer is null-terminated > Changes since v2: > - multiple fixes testing with AFC DUT Test Harness > Changes since v1: > - use unix socket instead of a tcp one > Changes since rfc: > - move curl connection to a dedicated afc daemon > > Lorenzo Bianconi (4): > hostapd: afcd: add AFC daemon support > hostapd: export hostapd_is_usable_chans utility routine > hostapd: ap: add AFC client support > hostapd: update TPE IE according to AFC > > afc/.gitignore | 1 + > afc/Makefile | 31 ++ > afc/afc-reply.txt | 219 +++++++++ > afc/afcd.c | 305 ++++++++++++ > hostapd/Makefile | 8 + > hostapd/config_file.c | 261 +++++++++++ > hostapd/defconfig | 3 + > hostapd/hostapd.conf | 42 ++ > src/ap/afc.c | 1033 +++++++++++++++++++++++++++++++++++++++++ > src/ap/ap_config.c | 16 + > src/ap/ap_config.h | 47 ++ > src/ap/hostapd.c | 16 + > src/ap/hostapd.h | 54 +++ > src/ap/hw_features.c | 4 +- > src/ap/hw_features.h | 6 + > src/ap/ieee802_11.c | 47 +- > 16 files changed, 2074 insertions(+), 19 deletions(-) > create mode 100644 afc/.gitignore > create mode 100644 afc/Makefile > create mode 100644 afc/afc-reply.txt > create mode 100644 afc/afcd.c > create mode 100644 src/ap/afc.c I have done some basic tests and it is working fine, left a couple of minor comments.
> On Tue, May 14, 2024 at 5:38 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > > Introduce Automated Frequency Coordination (AFC) support for UNII-5 and UNII-7 > > 6GHz bands. > > Update Transmit Power Envelope (TPE) IE according to the reply from AFC > > coordinator on UNII-5 or UNII-7 6GHz bands. > > AFCD and AFC hostapd client are tested with AFC DUT Test Harness [0]. > > > > Changes since v5: > > -rebased on top of hostapd main branch > > Changes since v4: > > - fix curl header parsing > > - increase afc buffer size > > - fix afc-reply.txt > > - add some more error logging > > - add sanity check for some afc config file data > > Changes since v3: > > - fix compilation errors when IEEE80211_AX is not enabled > > - fix a leftover crash stopping the interface > > - make sure rx buffer is null-terminated > > Changes since v2: > > - multiple fixes testing with AFC DUT Test Harness > > Changes since v1: > > - use unix socket instead of a tcp one > > Changes since rfc: > > - move curl connection to a dedicated afc daemon > > > > Lorenzo Bianconi (4): > > hostapd: afcd: add AFC daemon support > > hostapd: export hostapd_is_usable_chans utility routine > > hostapd: ap: add AFC client support > > hostapd: update TPE IE according to AFC > > > > afc/.gitignore | 1 + > > afc/Makefile | 31 ++ > > afc/afc-reply.txt | 219 +++++++++ > > afc/afcd.c | 305 ++++++++++++ > > hostapd/Makefile | 8 + > > hostapd/config_file.c | 261 +++++++++++ > > hostapd/defconfig | 3 + > > hostapd/hostapd.conf | 42 ++ > > src/ap/afc.c | 1033 +++++++++++++++++++++++++++++++++++++++++ > > src/ap/ap_config.c | 16 + > > src/ap/ap_config.h | 47 ++ > > src/ap/hostapd.c | 16 + > > src/ap/hostapd.h | 54 +++ > > src/ap/hw_features.c | 4 +- > > src/ap/hw_features.h | 6 + > > src/ap/ieee802_11.c | 47 +- > > 16 files changed, 2074 insertions(+), 19 deletions(-) > > create mode 100644 afc/.gitignore > > create mode 100644 afc/Makefile > > create mode 100644 afc/afc-reply.txt > > create mode 100644 afc/afcd.c > > create mode 100644 src/ap/afc.c > I have done some basic tests and it is working fine, left a couple of > minor comments. Hi Krishna, thx for testing it. I guess we can address them with a follow-up patch if there are no other comments. What do you think? Regards, Lorenzo
On Wed, May 15, 2024 at 2:08 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > On Tue, May 14, 2024 at 5:38 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > > > > Introduce Automated Frequency Coordination (AFC) support for UNII-5 and UNII-7 > > > 6GHz bands. > > > Update Transmit Power Envelope (TPE) IE according to the reply from AFC > > > coordinator on UNII-5 or UNII-7 6GHz bands. > > > AFCD and AFC hostapd client are tested with AFC DUT Test Harness [0]. > > > > > > Changes since v5: > > > -rebased on top of hostapd main branch > > > Changes since v4: > > > - fix curl header parsing > > > - increase afc buffer size > > > - fix afc-reply.txt > > > - add some more error logging > > > - add sanity check for some afc config file data > > > Changes since v3: > > > - fix compilation errors when IEEE80211_AX is not enabled > > > - fix a leftover crash stopping the interface > > > - make sure rx buffer is null-terminated > > > Changes since v2: > > > - multiple fixes testing with AFC DUT Test Harness > > > Changes since v1: > > > - use unix socket instead of a tcp one > > > Changes since rfc: > > > - move curl connection to a dedicated afc daemon > > > > > > Lorenzo Bianconi (4): > > > hostapd: afcd: add AFC daemon support > > > hostapd: export hostapd_is_usable_chans utility routine > > > hostapd: ap: add AFC client support > > > hostapd: update TPE IE according to AFC > > > > > > afc/.gitignore | 1 + > > > afc/Makefile | 31 ++ > > > afc/afc-reply.txt | 219 +++++++++ > > > afc/afcd.c | 305 ++++++++++++ > > > hostapd/Makefile | 8 + > > > hostapd/config_file.c | 261 +++++++++++ > > > hostapd/defconfig | 3 + > > > hostapd/hostapd.conf | 42 ++ > > > src/ap/afc.c | 1033 +++++++++++++++++++++++++++++++++++++++++ > > > src/ap/ap_config.c | 16 + > > > src/ap/ap_config.h | 47 ++ > > > src/ap/hostapd.c | 16 + > > > src/ap/hostapd.h | 54 +++ > > > src/ap/hw_features.c | 4 +- > > > src/ap/hw_features.h | 6 + > > > src/ap/ieee802_11.c | 47 +- > > > 16 files changed, 2074 insertions(+), 19 deletions(-) > > > create mode 100644 afc/.gitignore > > > create mode 100644 afc/Makefile > > > create mode 100644 afc/afc-reply.txt > > > create mode 100644 afc/afcd.c > > > create mode 100644 src/ap/afc.c > > I have done some basic tests and it is working fine, left a couple of > > minor comments. > > Hi Krishna, > > thx for testing it. I guess we can address them with a follow-up patch if there > are no other comments. What do you think? > Sure, those are only minor comments, I can submit them myself later if needed. ACK for merging from my side. Cheers.