| Message ID | 20240507175132.1456512-16-raymond.mao@linaro.org |
|---|---|
| State | RFC |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Integrate MbedTLS v3.6 LTS with U-Boot | expand |
Hi Raymond, On Tue, 7 May 2024 at 20:58, Raymond Mao <raymond.mao@linaro.org> wrote: > > Update the PKCS7 test suites for multiple certs. Please explain why. Does this belong to U-Boot or the patch should be sent to mbedTLS directly? Thanks /Ilias > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > --- > Changes in v2 > - None. > > .../external/mbedtls/tests/suites/test_suite_pkcs7.data | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > index d3b83cdf0aa..2dd1c56109f 100644 > --- a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > +++ b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > @@ -14,9 +14,9 @@ PKCS7 Signed Data Parse with zero signers > depends_on:MBEDTLS_MD_CAN_SHA256 > pkcs7_parse:"data_files/pkcs7_data_no_signers.der":MBEDTLS_PKCS7_SIGNED_DATA > > -PKCS7 Signed Data Parse Fail with multiple certs #4 > +PKCS7 Signed Data Parse Pass with multiple certs #4 > depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C > -pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_ERR_PKCS7_FEATURE_UNAVAILABLE > +pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_PKCS7_SIGNED_DATA > > PKCS7 Signed Data Parse Fail with corrupted cert #5.0 > depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C > -- > 2.25.1 >
Hi Ilias, On Wed, 8 May 2024 at 10:33, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > Hi Raymond, > > On Tue, 7 May 2024 at 20:58, Raymond Mao <raymond.mao@linaro.org> wrote: > > > > Update the PKCS7 test suites for multiple certs. > > Please explain why. Does this belong to U-Boot or the patch should be > sent to mbedTLS directly? > > It is sent to MbedTLS upstream as well. The patch here is to keep the codebase consistent with the upstream, and for the people who want to run the MbedTLS test suite under U-Boot, until they are merged to MbedTLS upstream. Regards, Raymond Thanks > /Ilias > > > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > > --- > > Changes in v2 > > - None. > > > > .../external/mbedtls/tests/suites/test_suite_pkcs7.data | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > > index d3b83cdf0aa..2dd1c56109f 100644 > > --- a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > > +++ b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data > > @@ -14,9 +14,9 @@ PKCS7 Signed Data Parse with zero signers > > depends_on:MBEDTLS_MD_CAN_SHA256 > > > pkcs7_parse:"data_files/pkcs7_data_no_signers.der":MBEDTLS_PKCS7_SIGNED_DATA > > > > -PKCS7 Signed Data Parse Fail with multiple certs #4 > > +PKCS7 Signed Data Parse Pass with multiple certs #4 > > depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C > > > -pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_ERR_PKCS7_FEATURE_UNAVAILABLE > > > +pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_PKCS7_SIGNED_DATA > > > > PKCS7 Signed Data Parse Fail with corrupted cert #5.0 > > depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C > > -- > > 2.25.1 > > >
diff --git a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data index d3b83cdf0aa..2dd1c56109f 100644 --- a/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data +++ b/lib/mbedtls/external/mbedtls/tests/suites/test_suite_pkcs7.data @@ -14,9 +14,9 @@ PKCS7 Signed Data Parse with zero signers depends_on:MBEDTLS_MD_CAN_SHA256 pkcs7_parse:"data_files/pkcs7_data_no_signers.der":MBEDTLS_PKCS7_SIGNED_DATA -PKCS7 Signed Data Parse Fail with multiple certs #4 +PKCS7 Signed Data Parse Pass with multiple certs #4 depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C -pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_ERR_PKCS7_FEATURE_UNAVAILABLE +pkcs7_parse:"data_files/pkcs7_data_multiple_certs_signed.der":MBEDTLS_PKCS7_SIGNED_DATA PKCS7 Signed Data Parse Fail with corrupted cert #5.0 depends_on:MBEDTLS_MD_CAN_SHA256:MBEDTLS_RSA_C
Update the PKCS7 test suites for multiple certs. Signed-off-by: Raymond Mao <raymond.mao@linaro.org> --- Changes in v2 - None. .../external/mbedtls/tests/suites/test_suite_pkcs7.data | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)