mbox series

[v3,0/5] Minor improvements and cleanups to ext4 mballoc

Message ID 20240424061904.987525-1-shikemeng@huaweicloud.com
Headers show
Series Minor improvements and cleanups to ext4 mballoc | expand

Message

Kemeng Shi April 24, 2024, 6:18 a.m. UTC
v2->v3:
-Coleect RVB from Jan
-Remove more unneeded "cr =" in comment

v1->v2:
-Collect RVB from Jan and Ojaswin
-Rewrite changelog of "ext4: call ext4_mb_mark_free_simple to free
continuous bits in found chunk"
-Remove "cr =" in comment of criteria name as criteria name has CR_
prfefix now.
-Only open codeing repeated checks in next_linear_group

This series contains some minor improvements and cleanups to ext4
mballoc. No failure is found in "kvm-xfstests smoke" test and unit
test. More details can be found in respective patches. Thanks!

Kemeng Shi (5):
  ext4: keep "prefetch_grp" and "nr" consistent
  ext4: add test_mb_mark_used_cost to estimate cost of mb_mark_used
  ext4: call ext4_mb_mark_free_simple to free continuous bits in found
    chunk
  ext4: use correct criteria name instead stale integer number in
    comment
  ext4: open coding repeated check in next_linear_group

 fs/ext4/ext4.h         |  9 +++--
 fs/ext4/mballoc-test.c | 52 +++++++++++++++++++++++++
 fs/ext4/mballoc.c      | 86 ++++++++++++++++++++++--------------------
 fs/ext4/mballoc.h      |  4 +-
 4 files changed, 106 insertions(+), 45 deletions(-)

Comments

Theodore Ts'o May 7, 2024, 11:03 p.m. UTC | #1
On Wed, 24 Apr 2024 14:18:59 +0800, Kemeng Shi wrote:
> v2->v3:
> -Coleect RVB from Jan
> -Remove more unneeded "cr =" in comment
> 
> v1->v2:
> -Collect RVB from Jan and Ojaswin
> -Rewrite changelog of "ext4: call ext4_mb_mark_free_simple to free
> continuous bits in found chunk"
> -Remove "cr =" in comment of criteria name as criteria name has CR_
> prfefix now.
> -Only open codeing repeated checks in next_linear_group
> 
> [...]

Applied, thanks!

[1/5] ext4: keep "prefetch_grp" and "nr" consistent
      commit: 9c97c34a998a01bc0cf970b1685456bc2ea16b64
[2/5] ext4: add test_mb_mark_used_cost to estimate cost of mb_mark_used
      commit: d0b88624f81f272626c767f4b715f4b690fcbed2
[3/5] ext4: call ext4_mb_mark_free_simple to free continuous bits in found chunk
      commit: d1a3924e43a35860ed7edaeec7f901a1ade2ac37
[4/5] ext4: use correct criteria name instead stale integer number in comment
      commit: 2caffb6a277bb0f2a482a2eb824d012d5f45f4d0
[5/5] ext4: open coding repeated check in next_linear_group
      commit: da5704eef7037a5bc84a56519729d93d10a0e0a0

Best regards,