diff mbox series

[v3,2/2] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block

Message ID 20240213142941.161217-3-biju.das.jz@bp.renesas.com
State Not Applicable, archived
Headers show
Series Document RZ/G2UL CRU and CSI support | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Biju Das Feb. 13, 2024, 2:29 p.m. UTC
Document the CRU IP found in Renesas RZ/G2UL SoC.

The CRU block on the RZ/G2UL SoC is identical to one found on the
RZ/G2L SoC, but it does not support parallel input.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2->v3:
 * Added Ack from Conor Dooley and Rb tag from Geert.
v1->v2:
 * Dropped the description from if/else block.
 * Dropped driver reference from commit description.
---
 .../bindings/media/renesas,rzg2l-cru.yaml     | 35 ++++++++++++++++---
 1 file changed, 31 insertions(+), 4 deletions(-)

Comments

Biju Das May 2, 2024, 10:51 a.m. UTC | #1
Hi All,

Gentle ping. Looks like it missed out in previous kernel cycle.

Are we happy with this patch?

Cheers,
Biju

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Tuesday, February 13, 2024 2:30 PM
> Subject: [PATCH v3 2/2] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block
> 
> Document the CRU IP found in Renesas RZ/G2UL SoC.
> 
> The CRU block on the RZ/G2UL SoC is identical to one found on the RZ/G2L SoC, but it does not
> support parallel input.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
>  * Added Ack from Conor Dooley and Rb tag from Geert.
> v1->v2:
>  * Dropped the description from if/else block.
>  * Dropped driver reference from commit description.
> ---
>  .../bindings/media/renesas,rzg2l-cru.yaml     | 35 ++++++++++++++++---
>  1 file changed, 31 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> index 1e72b8808d24..bc1245127025 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> @@ -19,6 +19,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - renesas,r9a07g043-cru       # RZ/G2UL
>            - renesas,r9a07g044-cru       # RZ/G2{L,LC}
>            - renesas,r9a07g054-cru       # RZ/V2L
>        - const: renesas,rzg2l-cru
> @@ -87,10 +88,6 @@ properties:
>            Input port node, describing the Image Processing module connected to the
>            CSI-2 receiver.
> 
> -    required:
> -      - port@0
> -      - port@1
> -
>  required:
>    - compatible
>    - reg
> @@ -102,6 +99,36 @@ required:
>    - reset-names
>    - power-domains
> 
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a07g044-cru
> +              - renesas,r9a07g054-cru
> +    then:
> +      properties:
> +        ports:
> +          required:
> +            - port@0
> +            - port@1
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a07g043-cru
> +    then:
> +      properties:
> +        ports:
> +          properties:
> +            port@0: false
> +
> +          required:
> +            - port@1
> +
>  additionalProperties: false
> 
>  examples:
> --
> 2.25.1
Biju Das June 3, 2024, 1:12 p.m. UTC | #2
Hi All,

Gentle ping. This patch has been Reviewed by DT/Renesas SoC maintainer. Still not in the tree.

Cheers,
Biju

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Thursday, May 2, 2024 11:51 AM
> Subject: RE: [PATCH v3 2/2] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU
> block
> 
> Hi All,
> 
> Gentle ping. Looks like it missed out in previous kernel cycle.
> 
> Are we happy with this patch?
> 
> Cheers,
> Biju
> 
> > -----Original Message-----
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Sent: Tuesday, February 13, 2024 2:30 PM
> > Subject: [PATCH v3 2/2] media: dt-bindings: renesas,rzg2l-cru:
> > Document Renesas RZ/G2UL CRU block
> >
> > Document the CRU IP found in Renesas RZ/G2UL SoC.
> >
> > The CRU block on the RZ/G2UL SoC is identical to one found on the
> > RZ/G2L SoC, but it does not support parallel input.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2->v3:
> >  * Added Ack from Conor Dooley and Rb tag from Geert.
> > v1->v2:
> >  * Dropped the description from if/else block.
> >  * Dropped driver reference from commit description.
> > ---
> >  .../bindings/media/renesas,rzg2l-cru.yaml     | 35 ++++++++++++++++---
> >  1 file changed, 31 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > index 1e72b8808d24..bc1245127025 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
> > @@ -19,6 +19,7 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > +          - renesas,r9a07g043-cru       # RZ/G2UL
> >            - renesas,r9a07g044-cru       # RZ/G2{L,LC}
> >            - renesas,r9a07g054-cru       # RZ/V2L
> >        - const: renesas,rzg2l-cru
> > @@ -87,10 +88,6 @@ properties:
> >            Input port node, describing the Image Processing module connected to the
> >            CSI-2 receiver.
> >
> > -    required:
> > -      - port@0
> > -      - port@1
> > -
> >  required:
> >    - compatible
> >    - reg
> > @@ -102,6 +99,36 @@ required:
> >    - reset-names
> >    - power-domains
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - renesas,r9a07g044-cru
> > +              - renesas,r9a07g054-cru
> > +    then:
> > +      properties:
> > +        ports:
> > +          required:
> > +            - port@0
> > +            - port@1
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - renesas,r9a07g043-cru
> > +    then:
> > +      properties:
> > +        ports:
> > +          properties:
> > +            port@0: false
> > +
> > +          required:
> > +            - port@1
> > +
> >  additionalProperties: false
> >
> >  examples:
> > --
> > 2.25.1
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
index 1e72b8808d24..bc1245127025 100644
--- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
@@ -19,6 +19,7 @@  properties:
   compatible:
     items:
       - enum:
+          - renesas,r9a07g043-cru       # RZ/G2UL
           - renesas,r9a07g044-cru       # RZ/G2{L,LC}
           - renesas,r9a07g054-cru       # RZ/V2L
       - const: renesas,rzg2l-cru
@@ -87,10 +88,6 @@  properties:
           Input port node, describing the Image Processing module connected to the
           CSI-2 receiver.
 
-    required:
-      - port@0
-      - port@1
-
 required:
   - compatible
   - reg
@@ -102,6 +99,36 @@  required:
   - reset-names
   - power-domains
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - renesas,r9a07g044-cru
+              - renesas,r9a07g054-cru
+    then:
+      properties:
+        ports:
+          required:
+            - port@0
+            - port@1
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - renesas,r9a07g043-cru
+    then:
+      properties:
+        ports:
+          properties:
+            port@0: false
+
+          required:
+            - port@1
+
 additionalProperties: false
 
 examples: