| Message ID | 20240430144424.1191923-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v3] ci: Keep the container version pinned. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 4/30/24 16:44, Ales Musil wrote: > The Ubuntu 24.04 brought some issues that are not really straight > forward to fix. Keep the Ubuntu version on 22.04 for now to keep > the CI working. > > At the same time Fedora updated Clang to version 18, which is > throwing compilation error that need to be fixed in OvS first. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > utilities/containers/fedora/Dockerfile | 2 +- > utilities/containers/ubuntu/Dockerfile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/containers/fedora/Dockerfile b/utilities/containers/fedora/Dockerfile > index bf3c293fc..9b8386aae 100755 > --- a/utilities/containers/fedora/Dockerfile > +++ b/utilities/containers/fedora/Dockerfile > @@ -1,4 +1,4 @@ > -FROM quay.io/fedora/fedora:latest > +FROM quay.io/fedora/fedora:39 > > ARG CONTAINERS_PATH > > diff --git a/utilities/containers/ubuntu/Dockerfile b/utilities/containers/ubuntu/Dockerfile > index 1371b3f70..ac1e6a5bf 100755 > --- a/utilities/containers/ubuntu/Dockerfile > +++ b/utilities/containers/ubuntu/Dockerfile > @@ -1,4 +1,4 @@ > -FROM registry.hub.docker.com/library/ubuntu:latest > +FROM registry.hub.docker.com/library/ubuntu:22.04 > > ARG CONTAINERS_PATH > I think, we should also pin the version in build-linux-rpm job in .github/workflows/test.yml. Best regards, Ilya Maximets.
Acked-by: Mark Michelson <mmichels@redhat.com> I pushed this to main and branch-24.03. On 4/30/24 10:44, Ales Musil wrote: > The Ubuntu 24.04 brought some issues that are not really straight > forward to fix. Keep the Ubuntu version on 22.04 for now to keep > the CI working. > > At the same time Fedora updated Clang to version 18, which is > throwing compilation error that need to be fixed in OvS first. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > utilities/containers/fedora/Dockerfile | 2 +- > utilities/containers/ubuntu/Dockerfile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/containers/fedora/Dockerfile b/utilities/containers/fedora/Dockerfile > index bf3c293fc..9b8386aae 100755 > --- a/utilities/containers/fedora/Dockerfile > +++ b/utilities/containers/fedora/Dockerfile > @@ -1,4 +1,4 @@ > -FROM quay.io/fedora/fedora:latest > +FROM quay.io/fedora/fedora:39 > > ARG CONTAINERS_PATH > > diff --git a/utilities/containers/ubuntu/Dockerfile b/utilities/containers/ubuntu/Dockerfile > index 1371b3f70..ac1e6a5bf 100755 > --- a/utilities/containers/ubuntu/Dockerfile > +++ b/utilities/containers/ubuntu/Dockerfile > @@ -1,4 +1,4 @@ > -FROM registry.hub.docker.com/library/ubuntu:latest > +FROM registry.hub.docker.com/library/ubuntu:22.04 > > ARG CONTAINERS_PATH >
diff --git a/utilities/containers/fedora/Dockerfile b/utilities/containers/fedora/Dockerfile index bf3c293fc..9b8386aae 100755 --- a/utilities/containers/fedora/Dockerfile +++ b/utilities/containers/fedora/Dockerfile @@ -1,4 +1,4 @@ -FROM quay.io/fedora/fedora:latest +FROM quay.io/fedora/fedora:39 ARG CONTAINERS_PATH diff --git a/utilities/containers/ubuntu/Dockerfile b/utilities/containers/ubuntu/Dockerfile index 1371b3f70..ac1e6a5bf 100755 --- a/utilities/containers/ubuntu/Dockerfile +++ b/utilities/containers/ubuntu/Dockerfile @@ -1,4 +1,4 @@ -FROM registry.hub.docker.com/library/ubuntu:latest +FROM registry.hub.docker.com/library/ubuntu:22.04 ARG CONTAINERS_PATH
The Ubuntu 24.04 brought some issues that are not really straight forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. At the same time Fedora updated Clang to version 18, which is throwing compilation error that need to be fixed in OvS first. Signed-off-by: Ales Musil <amusil@redhat.com> --- utilities/containers/fedora/Dockerfile | 2 +- utilities/containers/ubuntu/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)