Message ID | 20240426113756.3962234-1-mika.westerberg@linux.intel.com |
---|---|
State | Changes Requested |
Headers | show |
Series | package/tbtools: new package | expand |
Hi Mika, On Mon, Apr 29, 2024 at 02:04:02PM GMT, Mika Westerberg wrote: > This is a collection of tools for Linux Thunderbolt/USB4 development, > debugging and validation. > > Signed-off-by: Mika Westerberg <mika.westerberg at linux.intel.com> > --- > package/Config.in | 1 + > package/tbtools/Config.in | 9 +++++++++ > package/tbtools/tbtools.mk | 12 ++++++++++++ > 3 files changed, 22 insertions(+) > create mode 100644 package/tbtools/Config.in > create mode 100644 package/tbtools/tbtools.mk > > diff --git a/package/Config.in b/package/Config.in > index cdbf3577f8e1..e346917649a8 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -157,6 +157,7 @@ menu "Debugging, profiling and benchmark" > source "package/stress-ng/Config.in" > source "package/sysdig/Config.in" > source "package/sysprof/Config.in" > + source "package/tbtools/Config.in" > source "package/tcf-agent/Config.in" > source "package/trace-cmd/Config.in" > source "package/trinity/Config.in" > diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in > new file mode 100644 > index 000000000000..d2a1405eb5e8 > --- /dev/null > +++ b/package/tbtools/Config.in > @@ -0,0 +1,9 @@ > +config BR2_PACKAGE_TBTOOLS > + bool "tbtools" > + depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS Tested this and theres a dependency on libudev which should be declared here. Also, currently the 32-bit build fails (for x86 at least), so I'd suggest BR2_ARCH_IS_64 for now to prevent breakage. > + select BR2_PACKAGE_HOST_RUSTC > + help > + tbtools is a collection of tools for Linux Thunderbolt/USB4 > + development, debugging and validation. > + > + https://github.com/intel/tbtools > diff --git a/package/tbtools/tbtools.mk b/package/tbtools/tbtools.mk > new file mode 100644 > index 000000000000..61986ca8d311 > --- /dev/null > +++ b/package/tbtools/tbtools.mk > @@ -0,0 +1,12 @@ > +################################################################################ > +# > +# tbtools > +# > +################################################################################ > + > +TBTOOLS_VERSION = v0.3.2 > +TBTOOLS_SITE = $(call github,intel,tbtools,$(TBTOOLS_VERSION)) > +TBTOOLS_LICENSE = MIT > +TBTOOLS_LICENSE_FILES = LICENSE > + > +$(eval $(cargo-package)) > -- > 2.43.0 >
Hi Aapo, On Mon, Apr 29, 2024 at 02:23:56PM +0300, Aapo Vienamo wrote: > Hi Mika, > > On Mon, Apr 29, 2024 at 02:04:02PM GMT, Mika Westerberg wrote: > > This is a collection of tools for Linux Thunderbolt/USB4 development, > > debugging and validation. > > > > Signed-off-by: Mika Westerberg <mika.westerberg at linux.intel.com> > > --- > > package/Config.in | 1 + > > package/tbtools/Config.in | 9 +++++++++ > > package/tbtools/tbtools.mk | 12 ++++++++++++ > > 3 files changed, 22 insertions(+) > > create mode 100644 package/tbtools/Config.in > > create mode 100644 package/tbtools/tbtools.mk > > > > diff --git a/package/Config.in b/package/Config.in > > index cdbf3577f8e1..e346917649a8 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -157,6 +157,7 @@ menu "Debugging, profiling and benchmark" > > source "package/stress-ng/Config.in" > > source "package/sysdig/Config.in" > > source "package/sysprof/Config.in" > > + source "package/tbtools/Config.in" > > source "package/tcf-agent/Config.in" > > source "package/trace-cmd/Config.in" > > source "package/trinity/Config.in" > > diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in > > new file mode 100644 > > index 000000000000..d2a1405eb5e8 > > --- /dev/null > > +++ b/package/tbtools/Config.in > > @@ -0,0 +1,9 @@ > > +config BR2_PACKAGE_TBTOOLS > > + bool "tbtools" > > + depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS > > Tested this and theres a dependency on libudev which should be declared > here. Also, currently the 32-bit build fails (for x86 at least), so I'd > suggest BR2_ARCH_IS_64 for now to prevent breakage. Thanks for testing! I for some reason did not see issue with libudev but okay :) If I add following in v2, would it work for you? diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in index d2a1405eb5..2627ea8bfc 100644 --- a/package/tbtools/Config.in +++ b/package/tbtools/Config.in @@ -1,6 +1,8 @@ config BR2_PACKAGE_TBTOOLS bool "tbtools" depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + depends on BR2_PACKAGE_HAS_UDEV + depends on BR2_ARCH_IS_64 select BR2_PACKAGE_HOST_RUSTC help tbtools is a collection of tools for Linux Thunderbolt/USB4
On Mon, Apr 29, 2024 at 02:36:37PM GMT, Mika Westerberg wrote: > Hi Aapo, > > On Mon, Apr 29, 2024 at 02:23:56PM +0300, Aapo Vienamo wrote: > > Hi Mika, > > > > On Mon, Apr 29, 2024 at 02:04:02PM GMT, Mika Westerberg wrote: > > > This is a collection of tools for Linux Thunderbolt/USB4 development, > > > debugging and validation. > > > > > > Signed-off-by: Mika Westerberg <mika.westerberg at linux.intel.com> > > > --- > > > package/Config.in | 1 + > > > package/tbtools/Config.in | 9 +++++++++ > > > package/tbtools/tbtools.mk | 12 ++++++++++++ > > > 3 files changed, 22 insertions(+) > > > create mode 100644 package/tbtools/Config.in > > > create mode 100644 package/tbtools/tbtools.mk > > > > > > diff --git a/package/Config.in b/package/Config.in > > > index cdbf3577f8e1..e346917649a8 100644 > > > --- a/package/Config.in > > > +++ b/package/Config.in > > > @@ -157,6 +157,7 @@ menu "Debugging, profiling and benchmark" > > > source "package/stress-ng/Config.in" > > > source "package/sysdig/Config.in" > > > source "package/sysprof/Config.in" > > > + source "package/tbtools/Config.in" > > > source "package/tcf-agent/Config.in" > > > source "package/trace-cmd/Config.in" > > > source "package/trinity/Config.in" > > > diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in > > > new file mode 100644 > > > index 000000000000..d2a1405eb5e8 > > > --- /dev/null > > > +++ b/package/tbtools/Config.in > > > @@ -0,0 +1,9 @@ > > > +config BR2_PACKAGE_TBTOOLS > > > + bool "tbtools" > > > + depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS > > > > Tested this and theres a dependency on libudev which should be declared > > here. Also, currently the 32-bit build fails (for x86 at least), so I'd > > suggest BR2_ARCH_IS_64 for now to prevent breakage. > > Thanks for testing! I for some reason did not see issue with libudev but > okay :) That could be if you had already enabled udev in the buildroot config. The udev crate depends on libudev-sys, which is where the build fails as it's just FFI bindings for the system libudev. > If I add following in v2, would it work for you? Yes, with these changes: Reviewed-by: Aapo Vienamo <aapo.vienamo@linux.intel.com> > diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in > index d2a1405eb5..2627ea8bfc 100644 > --- a/package/tbtools/Config.in > +++ b/package/tbtools/Config.in > @@ -1,6 +1,8 @@ > config BR2_PACKAGE_TBTOOLS > bool "tbtools" > depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS > + depends on BR2_PACKAGE_HAS_UDEV > + depends on BR2_ARCH_IS_64 > select BR2_PACKAGE_HOST_RUSTC > help > tbtools is a collection of tools for Linux Thunderbolt/USB4 > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/Config.in b/package/Config.in index cdbf3577f8e1..e346917649a8 100644 --- a/package/Config.in +++ b/package/Config.in @@ -157,6 +157,7 @@ menu "Debugging, profiling and benchmark" source "package/stress-ng/Config.in" source "package/sysdig/Config.in" source "package/sysprof/Config.in" + source "package/tbtools/Config.in" source "package/tcf-agent/Config.in" source "package/trace-cmd/Config.in" source "package/trinity/Config.in" diff --git a/package/tbtools/Config.in b/package/tbtools/Config.in new file mode 100644 index 000000000000..d2a1405eb5e8 --- /dev/null +++ b/package/tbtools/Config.in @@ -0,0 +1,9 @@ +config BR2_PACKAGE_TBTOOLS + bool "tbtools" + depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + select BR2_PACKAGE_HOST_RUSTC + help + tbtools is a collection of tools for Linux Thunderbolt/USB4 + development, debugging and validation. + + https://github.com/intel/tbtools diff --git a/package/tbtools/tbtools.mk b/package/tbtools/tbtools.mk new file mode 100644 index 000000000000..61986ca8d311 --- /dev/null +++ b/package/tbtools/tbtools.mk @@ -0,0 +1,12 @@ +################################################################################ +# +# tbtools +# +################################################################################ + +TBTOOLS_VERSION = v0.3.2 +TBTOOLS_SITE = $(call github,intel,tbtools,$(TBTOOLS_VERSION)) +TBTOOLS_LICENSE = MIT +TBTOOLS_LICENSE_FILES = LICENSE + +$(eval $(cargo-package))
This is a collection of tools for Linux Thunderbolt/USB4 development, debugging and validation. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- package/Config.in | 1 + package/tbtools/Config.in | 9 +++++++++ package/tbtools/tbtools.mk | 12 ++++++++++++ 3 files changed, 22 insertions(+) create mode 100644 package/tbtools/Config.in create mode 100644 package/tbtools/tbtools.mk