| Message ID | 20240425213701.655540-11-eajames@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: aspeed: Add IBM P11 BMC Boards | expand |
Hi Eddie,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20240424]
[also build test WARNING on linus/master v6.9-rc5]
[cannot apply to robh/for-next broonie-spi/for-next andi-shyti/i2c/i2c-host v6.9-rc5 v6.9-rc4 v6.9-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eddie-James/dt-bindings-spi-Document-the-IBM-Power-SPI-controller/20240426-054336
base: next-20240424
patch link: https://lore.kernel.org/r/20240425213701.655540-11-eajames%40linux.ibm.com
patch subject: [PATCH v3 10/14] dt-bindings: i2c: i2c-fsi: Switch to yaml format
reproduce: (https://download.01.org/0day-ci/archive/20240426/202404260842.hNo9YEmT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404260842.hNo9YEmT-lkp@intel.com/
All warnings (new ones prefixed by >>):
Warning: Documentation/devicetree/bindings/power/wakeup-source.txt references a file that doesn't exist: Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
Warning: Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/qcom
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/exynos/
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/i2c-fsi.txt
Using alabaster theme
On 25/04/2024 23:36, Eddie James wrote: > Switch to yaml for the FSI-attached I2C controller. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. > --- > .../devicetree/bindings/i2c/i2c-fsi.txt | 40 ------------- > .../devicetree/bindings/i2c/ibm,i2c-fsi.yaml | 59 +++++++++++++++++++ > 2 files changed, 59 insertions(+), 40 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml > > - }; > diff --git a/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml > new file mode 100644 > index 000000000000..473a45de1b6c > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/ibm,i2c-fsi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IBM FSI-attached I2C controller > + > +maintainers: > + - Eddie James <eajames@linux.ibm.com> > + > +description: > + This I2C controller is an FSI CFAM engine, providing access to a number of > + I2C busses. Therefore this node will always be a child of an FSI CFAM node; > + see fsi.txt for details on FSI slave and CFAM nodes. Here and in all other schemas - remove reference to fsi.txt. You are going to drop this file once you convert everything, right? > + > +properties: > + compatible: > + enum: > + - ibm,i2c-fsi > + > + reg: > + items: > + - description: FSI slave address > + > +required: > + - compatible > + - reg > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c@1800 { So no wrapper node is needed. Drop the wrapper node in previous patchset where you introduced one with warning. Best regards, Krzysztof
On 4/26/24 01:29, Krzysztof Kozlowski wrote: > On 25/04/2024 23:36, Eddie James wrote: >> Switch to yaml for the FSI-attached I2C controller. >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > >> --- >> .../devicetree/bindings/i2c/i2c-fsi.txt | 40 ------------- >> .../devicetree/bindings/i2c/ibm,i2c-fsi.yaml | 59 +++++++++++++++++++ >> 2 files changed, 59 insertions(+), 40 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt >> create mode 100644 Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml >> > >> - }; >> diff --git a/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml >> new file mode 100644 >> index 000000000000..473a45de1b6c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml >> @@ -0,0 +1,59 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/i2c/ibm,i2c-fsi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: IBM FSI-attached I2C controller >> + >> +maintainers: >> + - Eddie James <eajames@linux.ibm.com> >> + >> +description: >> + This I2C controller is an FSI CFAM engine, providing access to a number of >> + I2C busses. Therefore this node will always be a child of an FSI CFAM node; >> + see fsi.txt for details on FSI slave and CFAM nodes. > Here and in all other schemas - remove reference to fsi.txt. You are > going to drop this file once you convert everything, right? Good point, yes. > >> + >> +properties: >> + compatible: >> + enum: >> + - ibm,i2c-fsi >> + >> + reg: >> + items: >> + - description: FSI slave address >> + >> +required: >> + - compatible >> + - reg >> + >> +allOf: >> + - $ref: /schemas/i2c/i2c-controller.yaml# >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + i2c@1800 { > So no wrapper node is needed. Drop the wrapper node in previous patchset > where you introduced one with warning. The other one is actually a child node of the equivalent spi controller, so it does need some sort of wrapper (address-cells and size-cells don't match). > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt deleted file mode 100644 index b1be2ceb7e69..000000000000 --- a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt +++ /dev/null @@ -1,40 +0,0 @@ -Device-tree bindings for FSI-attached I2C master and busses ------------------------------------------------------------ - -Required properties: - - compatible = "ibm,i2c-fsi"; - - reg = < address size >; : The FSI CFAM address and address - space size. - - #address-cells = <1>; : Number of address cells in child - nodes. - - #size-cells = <0>; : Number of size cells in child nodes. - - child nodes : Nodes to describe busses off the I2C - master. - -Child node required properties: - - reg = < port number > : The port number on the I2C master. - -Child node optional properties: - - child nodes : Nodes to describe devices on the I2C - bus. - -Examples: - - i2c@1800 { - compatible = "ibm,i2c-fsi"; - reg = < 0x1800 0x400 >; - #address-cells = <1>; - #size-cells = <0>; - - i2c-bus@0 { - reg = <0>; - }; - - i2c-bus@1 { - reg = <1>; - - eeprom@50 { - compatible = "vendor,dev-name"; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml new file mode 100644 index 000000000000..473a45de1b6c --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/ibm,i2c-fsi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IBM FSI-attached I2C controller + +maintainers: + - Eddie James <eajames@linux.ibm.com> + +description: + This I2C controller is an FSI CFAM engine, providing access to a number of + I2C busses. Therefore this node will always be a child of an FSI CFAM node; + see fsi.txt for details on FSI slave and CFAM nodes. + +properties: + compatible: + enum: + - ibm,i2c-fsi + + reg: + items: + - description: FSI slave address + +required: + - compatible + - reg + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +unevaluatedProperties: false + +examples: + - | + i2c@1800 { + compatible = "ibm,i2c-fsi"; + reg = <0x1800 0x400>; + #address-cells = <1>; + #size-cells = <0>; + + i2c-bus@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + + i2c-bus@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; + }; + };
Switch to yaml for the FSI-attached I2C controller. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- .../devicetree/bindings/i2c/i2c-fsi.txt | 40 ------------- .../devicetree/bindings/i2c/ibm,i2c-fsi.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 40 deletions(-) delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt create mode 100644 Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml