| Message ID | 20240425120822.2048012-11-c-vankar@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add support for Ethernet Boot on SK-AM62 | expand |
On 25/04/2024 15:08, Chintan Vankar wrote: > Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. > > Signed-off-by: Chintan Vankar <c-vankar@ti.com> > --- > > Changes from v1 to v2: > - This patch is newly added in this series to enable CPSW MAC's PHY > node "phy_gmii_sel". As per discussion at here: > https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ > changes made by this patch can be dropped in the future when the > DT-Sync is performed with am62-main.dtsi containing this change in > the Linux DT which will match U-Boot's DT. I don't think bootph-all exists in am62-main.dtsi. It should come from board.dts > > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > index fa778b0ff4..e9a1afde95 100644 > --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi > +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > @@ -46,3 +46,7 @@ > &cpsw_port2 { > status = "disabled"; > }; > + > +&phy_gmii_sel { > + bootph-all; > +};
On 25/04/24 18:01, Roger Quadros wrote: > > > On 25/04/2024 15:08, Chintan Vankar wrote: >> Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. >> >> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >> --- >> >> Changes from v1 to v2: >> - This patch is newly added in this series to enable CPSW MAC's PHY >> node "phy_gmii_sel". As per discussion at here: >> https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ >> changes made by this patch can be dropped in the future when the >> DT-Sync is performed with am62-main.dtsi containing this change in >> the Linux DT which will match U-Boot's DT. > > I don't think bootph-all exists in am62-main.dtsi. It should come from > board.dts > Yes, I am having the same discussion at here: https://lore.kernel.org/all/c13ac165-7cbd-4e53-914e-8c6bc28250e3@ti.com/ >> >> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> index fa778b0ff4..e9a1afde95 100644 >> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> @@ -46,3 +46,7 @@ >> &cpsw_port2 { >> status = "disabled"; >> }; >> + >> +&phy_gmii_sel { >> + bootph-all; >> +}; >
On 25/04/24 18:06, Chintan Vankar wrote: > > > On 25/04/24 18:01, Roger Quadros wrote: >> >> >> On 25/04/2024 15:08, Chintan Vankar wrote: >>> Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. >>> >>> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >>> --- >>> >>> Changes from v1 to v2: >>> - This patch is newly added in this series to enable CPSW MAC's PHY >>> node "phy_gmii_sel". As per discussion at here: >>> https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ >>> changes made by this patch can be dropped in the future when the >>> DT-Sync is performed with am62-main.dtsi containing this change in >>> the Linux DT which will match U-Boot's DT. >> >> I don't think bootph-all exists in am62-main.dtsi. It should come from >> board.dts >> > > Yes, I am having the same discussion at here: > https://lore.kernel.org/all/c13ac165-7cbd-4e53-914e-8c6bc28250e3@ti.com/ > Since I have posted patch which adds bootph-all property to "k3-am62x-sk-common.dtsi" at here: https://lore.kernel.org/r/20240430085048.3143665-1-c-vankar@ti.com/ and it has no open comments and this series also does not have any open comments, so can it be merged ? >>> >>> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> index fa778b0ff4..e9a1afde95 100644 >>> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> @@ -46,3 +46,7 @@ >>> &cpsw_port2 { >>> status = "disabled"; >>> }; >>> + >>> +&phy_gmii_sel { >>> + bootph-all; >>> +}; >>
On 20/05/2024 09:04, Chintan Vankar wrote: > > > On 25/04/24 18:06, Chintan Vankar wrote: >> >> >> On 25/04/24 18:01, Roger Quadros wrote: >>> >>> >>> On 25/04/2024 15:08, Chintan Vankar wrote: >>>> Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. >>>> >>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >>>> --- >>>> >>>> Changes from v1 to v2: >>>> - This patch is newly added in this series to enable CPSW MAC's PHY >>>> node "phy_gmii_sel". As per discussion at here: >>>> https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ >>>> changes made by this patch can be dropped in the future when the >>>> DT-Sync is performed with am62-main.dtsi containing this change in >>>> the Linux DT which will match U-Boot's DT. >>> >>> I don't think bootph-all exists in am62-main.dtsi. It should come from >>> board.dts >>> >> >> Yes, I am having the same discussion at here: >> https://lore.kernel.org/all/c13ac165-7cbd-4e53-914e-8c6bc28250e3@ti.com/ >> > > Since I have posted patch which adds bootph-all property to > "k3-am62x-sk-common.dtsi" at here: > https://lore.kernel.org/r/20240430085048.3143665-1-c-vankar@ti.com/ > and it has no open comments and this series > also does not have any open comments, so can it be merged ? Since bootph-all is being added to k3-am62x-sk-common.dtsi don't you have to drop patch 10 from this series? > >>>> >>>> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>> index fa778b0ff4..e9a1afde95 100644 >>>> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>> @@ -46,3 +46,7 @@ >>>> &cpsw_port2 { >>>> status = "disabled"; >>>> }; >>>> + >>>> +&phy_gmii_sel { >>>> + bootph-all; >>>> +}; >>>
On 20/05/24 17:43, Roger Quadros wrote: > > > On 20/05/2024 09:04, Chintan Vankar wrote: >> >> >> On 25/04/24 18:06, Chintan Vankar wrote: >>> >>> >>> On 25/04/24 18:01, Roger Quadros wrote: >>>> >>>> >>>> On 25/04/2024 15:08, Chintan Vankar wrote: >>>>> Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. >>>>> >>>>> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >>>>> --- >>>>> >>>>> Changes from v1 to v2: >>>>> - This patch is newly added in this series to enable CPSW MAC's PHY >>>>> node "phy_gmii_sel". As per discussion at here: >>>>> https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ >>>>> changes made by this patch can be dropped in the future when the >>>>> DT-Sync is performed with am62-main.dtsi containing this change in >>>>> the Linux DT which will match U-Boot's DT. >>>> >>>> I don't think bootph-all exists in am62-main.dtsi. It should come from >>>> board.dts >>>> >>> >>> Yes, I am having the same discussion at here: >>> https://lore.kernel.org/all/c13ac165-7cbd-4e53-914e-8c6bc28250e3@ti.com/ >>> >> >> Since I have posted patch which adds bootph-all property to >> "k3-am62x-sk-common.dtsi" at here: >> https://lore.kernel.org/r/20240430085048.3143665-1-c-vankar@ti.com/ >> and it has no open comments and this series >> also does not have any open comments, so can it be merged ? > > Since bootph-all is being added to k3-am62x-sk-common.dtsi don't you have to drop patch 10 > from this series? > Yes you are correct, but that patch is not merged yet. >> >>>>> >>>>> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>>> index fa778b0ff4..e9a1afde95 100644 >>>>> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>>> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>>>> @@ -46,3 +46,7 @@ >>>>> &cpsw_port2 { >>>>> status = "disabled"; >>>>> }; >>>>> + >>>>> +&phy_gmii_sel { >>>>> + bootph-all; >>>>> +}; >>>> >
diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index fa778b0ff4..e9a1afde95 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi @@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Add "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel. Signed-off-by: Chintan Vankar <c-vankar@ti.com> --- Changes from v1 to v2: - This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here: https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/ changes made by this patch can be dropped in the future when the DT-Sync is performed with am62-main.dtsi containing this change in the Linux DT which will match U-Boot's DT. arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)