mbox series

[SRU,F/J/M,0/1] Fix UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c

Message ID 20240402030445.48780-1-guoqing.jiang@canonical.com
Headers show
Series Fix UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c | expand

Message

Guoqing Jiang April 2, 2024, 3:04 a.m. UTC
SRU Justification

BugLink: https://bugs.launchpad.net/bugs/2058477

[Impact]
error message "UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c:1446:41" appears
multiple times during boot for a Hyper-V environment.

[Fix]
Clean cherry-pick commit bb9b0e46b84 for Focal, Jammy and Mantic.

[Test case]
check the dmesg to see if there is the error message "UBSAN: array-index-out-of-bounds"

[Regression Potential]
DPDK which processes netvsc packets, so it might incompatible with ancient DPDK, but modern DPDK
had already used flexible array member.

Saurabh Sengar (1):
  hv: hyperv.h: Replace one-element array with flexible-array member

 include/linux/hyperv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner April 4, 2024, 1:43 p.m. UTC | #1
On 4/1/24 9:04 PM, Guoqing Jiang wrote:
> SRU Justification
> 
> BugLink: https://bugs.launchpad.net/bugs/2058477
> 
> [Impact]
> error message "UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c:1446:41" appears
> multiple times during boot for a Hyper-V environment.
> 
> [Fix]
> Clean cherry-pick commit bb9b0e46b84 for Focal, Jammy and Mantic.
> 
> [Test case]
> check the dmesg to see if there is the error message "UBSAN: array-index-out-of-bounds"
> 
> [Regression Potential]
> DPDK which processes netvsc packets, so it might incompatible with ancient DPDK, but modern DPDK
> had already used flexible array member.
> 
> Saurabh Sengar (1):
>    hv: hyperv.h: Replace one-element array with flexible-array member
> 
>   include/linux/hyperv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Andrei Gherzan April 4, 2024, 5:13 p.m. UTC | #2
On 24/04/02 11:04AM, Guoqing Jiang wrote:
> SRU Justification
> 
> BugLink: https://bugs.launchpad.net/bugs/2058477
> 
> [Impact]
> error message "UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c:1446:41" appears
> multiple times during boot for a Hyper-V environment.
> 
> [Fix]
> Clean cherry-pick commit bb9b0e46b84 for Focal, Jammy and Mantic.
> 
> [Test case]
> check the dmesg to see if there is the error message "UBSAN: array-index-out-of-bounds"
> 
> [Regression Potential]
> DPDK which processes netvsc packets, so it might incompatible with ancient DPDK, but modern DPDK
> had already used flexible array member.
> 
> Saurabh Sengar (1):
>   hv: hyperv.h: Replace one-element array with flexible-array member
> 
>  include/linux/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Roxana Nicolescu April 23, 2024, 6:46 a.m. UTC | #3
On 02/04/2024 05:04, Guoqing Jiang wrote:
> SRU Justification
>
> BugLink: https://bugs.launchpad.net/bugs/2058477
>
> [Impact]
> error message "UBSAN: array-index-out-of-bounds in drivers/net/hyperv/netvsc.c:1446:41" appears
> multiple times during boot for a Hyper-V environment.
>
> [Fix]
> Clean cherry-pick commit bb9b0e46b84 for Focal, Jammy and Mantic.
>
> [Test case]
> check the dmesg to see if there is the error message "UBSAN: array-index-out-of-bounds"
>
> [Regression Potential]
> DPDK which processes netvsc packets, so it might incompatible with ancient DPDK, but modern DPDK
> had already used flexible array member.
>
> Saurabh Sengar (1):
>    hv: hyperv.h: Replace one-element array with flexible-array member
>
>   include/linux/hyperv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to mantic, jammy, focal master-next branches. Thanks!