diff mbox series

[v1,1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM

Message ID 20240420011840.23148-2-zhi.mao@mediatek.com
State Not Applicable
Headers show
Series media: i2c: Add support for GT97xx VCM | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Zhi Mao (毛智) April 20, 2024, 1:18 a.m. UTC 
Add YAML device tree binding for GT9768 & GT8769 VCM,
and the relevant MAINTAINERS entries.

Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
---
 .../bindings/media/i2c/giantec,gt9769.yaml    | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml

Comments

Krzysztof Kozlowski April 20, 2024, 11:21 a.m. UTC | #1 
On 20/04/2024 03:18, Zhi Mao wrote:
> Add YAML device tree binding for GT9768 & GT8769 VCM,
> and the relevant MAINTAINERS entries.
> 
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> ---

Sorry, there was v1. Please do not send same versions twice. BTW, use
patman or b4 for your submissions if versioning is tricky.

Best regards,
Krzysztof
Kieran Bingham April 20, 2024, 12:53 p.m. UTC | #2 
Quoting Krzysztof Kozlowski (2024-04-20 12:21:46)
> On 20/04/2024 03:18, Zhi Mao wrote:
> > Add YAML device tree binding for GT9768 & GT8769 VCM,
> > and the relevant MAINTAINERS entries.
> > 
> > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> > ---
> 
> Sorry, there was v1. Please do not send same versions twice. BTW, use
> patman or b4 for your submissions if versioning is tricky.
> 

Whats Patman? google returns false positives for me.
--
Kieran

> Best regards,
> Krzysztof
>
Kieran Bingham April 21, 2024, 11:35 a.m. UTC | #3 
Quoting Kieran Bingham (2024-04-20 13:53:01)
> Quoting Krzysztof Kozlowski (2024-04-20 12:21:46)
> > On 20/04/2024 03:18, Zhi Mao wrote:
> > > Add YAML device tree binding for GT9768 & GT8769 VCM,
> > > and the relevant MAINTAINERS entries.
> > > 
> > > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> > > ---
> > 
> > Sorry, there was v1. Please do not send same versions twice. BTW, use
> > patman or b4 for your submissions if versioning is tricky.
> > 
> 
> Whats Patman? google returns false positives for me.

Digging deeper, I've discovered patman comes from the u-boot project,
and is known as 'patch manager', and can work along side patchwork.

 - https://docs.u-boot.org/en/latest/develop/patman.html


For completeness, b4 (which I've already used myself) is more closely
associated with public inbox.

 - https://github.com/mricon/b4


> --
> Kieran
> 
> > Best regards,
> > Krzysztof
> >
Krzysztof Kozlowski April 21, 2024, 2 p.m. UTC | #4 
On 21/04/2024 13:35, Kieran Bingham wrote:
> Quoting Kieran Bingham (2024-04-20 13:53:01)
>> Quoting Krzysztof Kozlowski (2024-04-20 12:21:46)
>>> On 20/04/2024 03:18, Zhi Mao wrote:
>>>> Add YAML device tree binding for GT9768 & GT8769 VCM,
>>>> and the relevant MAINTAINERS entries.
>>>>
>>>> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
>>>> ---
>>>
>>> Sorry, there was v1. Please do not send same versions twice. BTW, use
>>> patman or b4 for your submissions if versioning is tricky.
>>>
>>
>> Whats Patman? google returns false positives for me.
> 
> Digging deeper, I've discovered patman comes from the u-boot project,
> and is known as 'patch manager', and can work along side patchwork.
> 
>  - https://docs.u-boot.org/en/latest/develop/patman.html

Patman is the tool brought for U-boot and used a lot within some of
Chromebook folks, quite powerful. Now most of the community uses b4, but
for completeness I proposed patman (which has few nice features not
present in b4). See Doug's talk from this EOSS.

Best regards,
Krzysztof
Zhi Mao (毛智) April 22, 2024, 1:49 a.m. UTC | #5 
Hi, Krzysztof

Thanks for your feedback.

On Sat, 2024-04-20 at 13:21 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 20/04/2024 03:18, Zhi Mao wrote:
> > Add YAML device tree binding for GT9768 & GT8769 VCM,
> > and the relevant MAINTAINERS entries.
> > 
> > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> > ---
> 
> Sorry, there was v1. Please do not send same versions twice. BTW, use
> patman or b4 for your submissions if versioning is tricky.
> 
Sorry, it make you confused.
As we create the version number from "0" base, they are supposed as
v0/v1/...
So, the previouse version is:
v0: 
https://lore.kernel.org/all/20240410104002.1197-1-zhi.mao@mediatek.com/

If necessary, I can send a new v2 patch.
Do we need do it?

> Best regards,
> Krzysztof
>
Krzysztof Kozlowski April 22, 2024, 3:18 a.m. UTC | #6 
On 22/04/2024 03:49, Zhi Mao (毛智) wrote:
> Hi, Krzysztof
> 
> Thanks for your feedback.
> 
> On Sat, 2024-04-20 at 13:21 +0200, Krzysztof Kozlowski wrote:
>>  	 
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>  On 20/04/2024 03:18, Zhi Mao wrote:
>>> Add YAML device tree binding for GT9768 & GT8769 VCM,
>>> and the relevant MAINTAINERS entries.
>>>
>>> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
>>> ---
>>
>> Sorry, there was v1. Please do not send same versions twice. BTW, use
>> patman or b4 for your submissions if versioning is tricky.
>>
> Sorry, it make you confused.
> As we create the version number from "0" base, they are supposed as

No, we don't. Use the tools if you cannot get it right.

> v0/v1/...
> So, the previouse version is:
> v0: 
> https://lore.kernel.org/all/20240410104002.1197-1-zhi.mao@mediatek.com/
> 
> If necessary, I can send a new v2 patch.
> Do we need do it?

When you look through the window outside and you see cars passing by, do
you count them from 0? Car drivers, I see 0 car. Next car drivers, I see
1 (first) car?

Please use b4 to version this properly.

No need for v2. I will get to review this.

Best regards,
Krzysztof
Krzysztof Kozlowski April 22, 2024, 3:26 a.m. UTC | #7 
On 20/04/2024 03:18, Zhi Mao wrote:
> Add YAML device tree binding for GT9768 & GT8769 VCM,
> and the relevant MAINTAINERS entries.
> 
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

If there is going to be any new version, then:

>  .../bindings/media/i2c/giantec,gt9769.yaml    | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)

> +title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
> +
> +maintainers:
> +  - Zhi Mao <zhi.mao@mediatek.com>
> +
> +description: |-

Drop |-

> +  The Giantec GT9768 & GT9768 is a 10-bit DAC with current sink capability.
> +  The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
> +  This chip integrates Advanced Actuator Control (AAC) technology
> +  and is intended for driving voice coil lens in camera modules.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - giantec,gt9768
> +      - giantec,gt9769
> +
> +  reg:
> +    maxItems: 1
> +
> +  vin-supply: true
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vin-supply
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +

Drop blank line

> +    i2c {



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml b/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml
new file mode 100644
index 000000000000..6a9f49539b35
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml
@@ -0,0 +1,56 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (c) 2020 MediaTek Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/giantec,gt9769.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
+
+maintainers:
+  - Zhi Mao <zhi.mao@mediatek.com>
+
+description: |-
+  The Giantec GT9768 & GT9768 is a 10-bit DAC with current sink capability.
+  The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
+  This chip integrates Advanced Actuator Control (AAC) technology
+  and is intended for driving voice coil lens in camera modules.
+
+properties:
+  compatible:
+    enum:
+      - giantec,gt9768
+      - giantec,gt9769
+
+  reg:
+    maxItems: 1
+
+  vin-supply: true
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vin-supply
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera-lens@c {
+            compatible = "giantec,gt9769";
+            reg = <0x0c>;
+
+            vin-supply = <&gt97xx_vin>;
+            vdd-supply = <&gt97xx_vdd>;
+        };
+    };
+
+...