diff mbox series

[v3,1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine

Message ID 20240419211143.1039868-2-eajames@linux.ibm.com
State Not Applicable
Headers show
Series fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Eddie James April 19, 2024, 9:11 p.m. UTC
The SBEFIFO engine provides an interface to the POWER processor
Self Boot Engine (SBE).

Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
Changes since v1:
 - Chance "ody" to "odyssey"
 - Fix typo in commit message
 - Reword description to describe the hardware only

Changes since v2:
 - Rename file
 - Remove '|' after description
 - Change generic node name to match fsi.txt

 .../bindings/fsi/ibm,p9-sbefifo.yaml          | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml

Comments

Conor Dooley April 20, 2024, 10:54 a.m. UTC | #1
On Fri, Apr 19, 2024 at 04:11:41PM -0500, Eddie James wrote:
> The SBEFIFO engine provides an interface to the POWER processor
> Self Boot Engine (SBE).
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Andrew Jeffery April 21, 2024, 11:02 p.m. UTC | #2
On Fri, 2024-04-19 at 16:11 -0500, Eddie James wrote:
> The SBEFIFO engine provides an interface to the POWER processor
> Self Boot Engine (SBE).
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Eddie James April 25, 2024, 9:38 p.m. UTC | #3
On 4/21/24 18:02, Andrew Jeffery wrote:
> On Fri, 2024-04-19 at 16:11 -0500, Eddie James wrote:
>> The SBEFIFO engine provides an interface to the POWER processor
>> Self Boot Engine (SBE).
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>


I'm sending this patch in my new series for P11 BMC systems, with an 
additional change for the OCC child nodes. Hopefully that's OK, I kept 
the tags.


Eddie
Andrew Jeffery April 26, 2024, 12:05 a.m. UTC | #4
On Thu, 2024-04-25 at 16:38 -0500, Eddie James wrote:
> On 4/21/24 18:02, Andrew Jeffery wrote:
> > On Fri, 2024-04-19 at 16:11 -0500, Eddie James wrote:
> > > The SBEFIFO engine provides an interface to the POWER processor
> > > Self Boot Engine (SBE).
> > > 
> > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> 
> 
> I'm sending this patch in my new series for P11 BMC systems, with an 
> additional change for the OCC child nodes. Hopefully that's OK, I kept 
> the tags.

From a quick look I think that's fine.

Thanks,

Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml
new file mode 100644
index 000000000000..5892902f533a
--- /dev/null
+++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml
@@ -0,0 +1,39 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fsi/ibm,p9-sbefifo.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: IBM FSI-attached SBEFIFO engine
+
+maintainers:
+  - Eddie James <eajames@linux.ibm.com>
+
+description:
+  The SBEFIFO is an FSI CFAM engine that provides an interface to the
+  POWER processor Self Boot Engine (SBE). This node will always be a child
+  of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM
+  nodes.
+
+properties:
+  compatible:
+    enum:
+      - ibm,p9-sbefifo
+      - ibm,odyssey-sbefifo
+
+  reg:
+    items:
+      - description: FSI slave address
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    fsi-slave-engine@2400 {
+        compatible = "ibm,p9-sbefifo";
+        reg = <0x2400 0x400>;
+    };