| Message ID | 20240418192525.97451-24-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | include/exec: Rework (part 2) | expand |
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: > "exec/log.h" doesn't require "disas/disas.h". Remove it, > including it in the sources when required. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/exec/log.h | 1 - > target/avr/translate.c | 1 + > target/hexagon/translate.c | 1 + > target/loongarch/tcg/translate.c | 1 + > target/rx/translate.c | 1 + > tcg/tcg.c | 1 + > 6 files changed, 5 insertions(+), 1 deletion(-) Most of these additions are obviated by https://patchew.org/QEMU/20240405102459.462551-1-richard.henderson@linaro.org/ r~
diff --git a/include/exec/log.h b/include/exec/log.h index e0ff778a10..ee33981aab 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -4,7 +4,6 @@ #include "qemu/log.h" #include "qemu/log-for-trace.h" #include "hw/core/cpu.h" -#include "disas/disas.h" /* cpu_dump_state() logging functions: */ /** diff --git a/target/avr/translate.c b/target/avr/translate.c index 87e2bd5ef1..b2005f3cbe 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -29,6 +29,7 @@ #include "exec/helper-gen.h" #include "exec/log.h" #include "exec/translator.h" +#include "disas/disas.h" #define HELPER_H "helper.h" #include "exec/helper-info.c.inc" diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 47a870f42d..6bec38404e 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -25,6 +25,7 @@ #include "exec/translation-block.h" #include "exec/cpu_ldst.h" #include "exec/log.h" +#include "disas/disas.h" #include "internal.h" #include "attribs.h" #include "insn.h" diff --git a/target/loongarch/tcg/translate.c b/target/loongarch/tcg/translate.c index 7567712655..ae87a68c69 100644 --- a/target/loongarch/tcg/translate.c +++ b/target/loongarch/tcg/translate.c @@ -14,6 +14,7 @@ #include "exec/helper-proto.h" #include "exec/helper-gen.h" #include "exec/log.h" +#include "disas/disas.h" #include "qemu/qemu-print.h" #include "fpu/softfloat.h" #include "translate.h" diff --git a/target/rx/translate.c b/target/rx/translate.c index f6e9e0ec90..4259ad6d74 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -27,6 +27,7 @@ #include "exec/helper-gen.h" #include "exec/translator.h" #include "exec/log.h" +#include "disas/disas.h" #define HELPER_H "helper.h" #include "exec/helper-info.c.inc" diff --git a/tcg/tcg.c b/tcg/tcg.c index 6a32656cd4..e7e0ab6846 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -51,6 +51,7 @@ #endif #include "elf.h" +#include "disas/disas.h" #include "exec/log.h" #include "tcg/tcg-ldst.h" #include "tcg/tcg-temp-internal.h"
"exec/log.h" doesn't require "disas/disas.h". Remove it, including it in the sources when required. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/exec/log.h | 1 - target/avr/translate.c | 1 + target/hexagon/translate.c | 1 + target/loongarch/tcg/translate.c | 1 + target/rx/translate.c | 1 + tcg/tcg.c | 1 + 6 files changed, 5 insertions(+), 1 deletion(-)