diff mbox series

[v21,5/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport

Message ID 20240420044901.884098-6-quic_kriskura@quicinc.com
State Not Applicable
Headers show
Series Add multiport support for DWC3 controllers | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Krishna Kurapati April 20, 2024, 4:48 a.m. UTC
Add the compatible string for SC8280 Multiport USB controller from
Qualcomm.

There are 4 power event interrupts supported by this controller
(one for each port of multiport controller). Add all the 4 as
non-optional interrupts for SC8280XP-MP

Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
IRQs related to 4 ports of SC8280XP Teritiary controller.

Also added SuperSpeed PHY interrupt for both Superspeed ports.

Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 .../devicetree/bindings/usb/qcom,dwc3.yaml    | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

Krzysztof Kozlowski April 20, 2024, 11:31 a.m. UTC | #1
On 20/04/2024 06:48, Krishna Kurapati wrote:
> Add the compatible string for SC8280 Multiport USB controller from
> Qualcomm.
> 
> There are 4 power event interrupts supported by this controller
> (one for each port of multiport controller). Add all the 4 as
> non-optional interrupts for SC8280XP-MP
> 
> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
> IRQs related to 4 ports of SC8280XP Teritiary controller.
> 
> Also added SuperSpeed PHY interrupt for both Superspeed ports.
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

v21 and suddenly you drop tags requiring everyone to re-review this. I
do not think this process is working. I will not re-review this.

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.



Best regards,
Krzysztof
Krishna Kurapati April 20, 2024, 1:53 p.m. UTC | #2
On 4/20/2024 5:01 PM, Krzysztof Kozlowski wrote:
> On 20/04/2024 06:48, Krishna Kurapati wrote:
>> Add the compatible string for SC8280 Multiport USB controller from
>> Qualcomm.
>>
>> There are 4 power event interrupts supported by this controller
>> (one for each port of multiport controller). Add all the 4 as
>> non-optional interrupts for SC8280XP-MP
>>
>> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
>> IRQs related to 4 ports of SC8280XP Teritiary controller.
>>
>> Also added SuperSpeed PHY interrupt for both Superspeed ports.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> v21 and suddenly you drop tags requiring everyone to re-review this. I
> do not think this process is working. I will not re-review this.
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 

Hi Krzysztof,

  There was a commit text change to fix minor nits:
  -> One minor spell check: /s/oen/one
  -> minor nits like: /s/ss/SuperSpeed

  So removed the tags and requested for a review.
  "Updated commit text in patches 2/5/6."

  Apologies, My intention was to just fix the spell check and minor nits.
.
  The changes in v21 were in patches 1/2/4/7/9.
  Patches 3 and 8 were left untouched.
  Made minor nit fixes to commit text in patches 5 and 6 so that it 
feels more accurate.

Regards,
Krishna,
Krzysztof Kozlowski April 21, 2024, 2:03 p.m. UTC | #3
On 20/04/2024 15:53, Krishna Kurapati PSSNV wrote:
> 
> 
> On 4/20/2024 5:01 PM, Krzysztof Kozlowski wrote:
>> On 20/04/2024 06:48, Krishna Kurapati wrote:
>>> Add the compatible string for SC8280 Multiport USB controller from
>>> Qualcomm.
>>>
>>> There are 4 power event interrupts supported by this controller
>>> (one for each port of multiport controller). Add all the 4 as
>>> non-optional interrupts for SC8280XP-MP
>>>
>>> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
>>> IRQs related to 4 ports of SC8280XP Teritiary controller.
>>>
>>> Also added SuperSpeed PHY interrupt for both Superspeed ports.
>>>
>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>>
>> v21 and suddenly you drop tags requiring everyone to re-review this. I
>> do not think this process is working. I will not re-review this.
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions, under or above your Signed-off-by tag. Tag is "received", when
>> provided in a message replied to you on the mailing list. Tools like b4
>> can help here. However, there's no need to repost patches *only* to add
>> the tags. The upstream maintainer will do that for tags received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
>>
> 
> Hi Krzysztof,
> 
>   There was a commit text change to fix minor nits:
>   -> One minor spell check: /s/oen/one
>   -> minor nits like: /s/ss/SuperSpeed
> 
>   So removed the tags and requested for a review.
>   "Updated commit text in patches 2/5/6."


Did you read the doc I linked? I am pretty sure I linked it many times
before as well...



Best regards,
Krzysztof
Johan Hovold April 22, 2024, 7:12 a.m. UTC | #4
On Sat, Apr 20, 2024 at 10:18:57AM +0530, Krishna Kurapati wrote:
> Add the compatible string for SC8280 Multiport USB controller from
> Qualcomm.
> 
> There are 4 power event interrupts supported by this controller
> (one for each port of multiport controller). Add all the 4 as
> non-optional interrupts for SC8280XP-MP
> 
> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
> IRQs related to 4 ports of SC8280XP Teritiary controller.
> 
> Also added SuperSpeed PHY interrupt for both Superspeed ports.
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan Hovold April 22, 2024, 7:13 a.m. UTC | #5
On Sat, Apr 20, 2024 at 10:18:57AM +0530, Krishna Kurapati wrote:
> Add the compatible string for SC8280 Multiport USB controller from
> Qualcomm.
> 
> There are 4 power event interrupts supported by this controller
> (one for each port of multiport controller). Add all the 4 as
> non-optional interrupts for SC8280XP-MP
> 
> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
> IRQs related to 4 ports of SC8280XP Teritiary controller.
> 
> Also added SuperSpeed PHY interrupt for both Superspeed ports.
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 38a3404ec71b..f55f601c0329 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -30,6 +30,7 @@  properties:
           - qcom,sc7180-dwc3
           - qcom,sc7280-dwc3
           - qcom,sc8280xp-dwc3
+          - qcom,sc8280xp-dwc3-mp
           - qcom,sdm660-dwc3
           - qcom,sdm670-dwc3
           - qcom,sdm845-dwc3
@@ -282,6 +283,7 @@  allOf:
           contains:
             enum:
               - qcom,sc8280xp-dwc3
+              - qcom,sc8280xp-dwc3-mp
               - qcom,x1e80100-dwc3
     then:
       properties:
@@ -470,6 +472,38 @@  allOf:
             - const: dm_hs_phy_irq
             - const: ss_phy_irq
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sc8280xp-dwc3-mp
+    then:
+      properties:
+        interrupts:
+          minItems: 18
+          maxItems: 18
+        interrupt-names:
+          items:
+            - const: pwr_event_1
+            - const: pwr_event_2
+            - const: pwr_event_3
+            - const: pwr_event_4
+            - const: hs_phy_1
+            - const: hs_phy_2
+            - const: hs_phy_3
+            - const: hs_phy_4
+            - const: dp_hs_phy_1
+            - const: dm_hs_phy_1
+            - const: dp_hs_phy_2
+            - const: dm_hs_phy_2
+            - const: dp_hs_phy_3
+            - const: dm_hs_phy_3
+            - const: dp_hs_phy_4
+            - const: dm_hs_phy_4
+            - const: ss_phy_1
+            - const: ss_phy_2
+
 additionalProperties: false
 
 examples: