| Message ID | 20240419-ad9467-new-features-v1-3-3e7628ff6d5e@analog.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | iio: ad9467: support interface tuning | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 19/04/2024 17:36, Nuno Sa via B4 Relay wrote: > From: Nuno Sa <nuno.sa@analog.com> > > Add a required clock property as we can't access the device registers if > the AXI bus clock is not properly enabled. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 19 Apr 2024 17:36:46 +0200 Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote: > From: Nuno Sa <nuno.sa@analog.com> > > Add a required clock property as we can't access the device registers if > the AXI bus clock is not properly enabled. > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> Fix, or doesn't matter until this series? Obviously should have been in the binding anyway, but whether it matters already affects whether this should go to stable or not. Jonathan > --- > Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > index 3d49d21ad33df..e1f450b80db27 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > @@ -28,6 +28,9 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > dmas: > maxItems: 1 > > @@ -48,6 +51,7 @@ required: > - compatible > - dmas > - reg > + - clocks > > additionalProperties: false > > @@ -58,6 +62,7 @@ examples: > reg = <0x44a00000 0x10000>; > dmas = <&rx_dma 0>; > dma-names = "rx"; > + clocks = <&axi_clk>; > #io-backend-cells = <0>; > }; > ... >
On Sat, 2024-04-20 at 16:04 +0100, Jonathan Cameron wrote: > On Fri, 19 Apr 2024 17:36:46 +0200 > Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote: > > > From: Nuno Sa <nuno.sa@analog.com> > > > > Add a required clock property as we can't access the device registers if > > the AXI bus clock is not properly enabled. > > > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > Fix, or doesn't matter until this series? > It does matter. But reality is that it's rare for you to catch this issue because such a fundamental clock is typically enabled pretty early during boot. But we did had some issues (on other cores) regarding this. Anyways, for correctness, I'll add a tag on v2. - Nuno Sá
On Mon, 22 Apr 2024 17:06:22 +0200 Nuno Sá <noname.nuno@gmail.com> wrote: > On Sat, 2024-04-20 at 16:04 +0100, Jonathan Cameron wrote: > > On Fri, 19 Apr 2024 17:36:46 +0200 > > Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote: > > > > > From: Nuno Sa <nuno.sa@analog.com> > > > > > > Add a required clock property as we can't access the device registers if > > > the AXI bus clock is not properly enabled. > > > > > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > > Fix, or doesn't matter until this series? > > > > It does matter. But reality is that it's rare for you to catch this issue because > such a fundamental clock is typically enabled pretty early during boot. But we did > had some issues (on other cores) regarding this. Anyways, for correctness, I'll add a > tag on v2. > Add that info as well so people can judge how important this is to backport. J > - Nuno Sá > >
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml index 3d49d21ad33df..e1f450b80db27 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml @@ -28,6 +28,9 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 1 + dmas: maxItems: 1 @@ -48,6 +51,7 @@ required: - compatible - dmas - reg + - clocks additionalProperties: false @@ -58,6 +62,7 @@ examples: reg = <0x44a00000 0x10000>; dmas = <&rx_dma 0>; dma-names = "rx"; + clocks = <&axi_clk>; #io-backend-cells = <0>; }; ...