| Message ID | 20231023-display-support-v3-0-53388f3ed34b@baylibre.com |
|---|---|
| Headers | show |
| Series | Add display support for the MT8365-EVK board | expand |
Il 18/04/24 16:17, Alexandre Mergnat ha scritto: > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. > Additionnaly, "vpll_dpix" isn't used/managed. > > Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel". > > The new clock tree is: > > clk26m > lvdspll > lvdspll_X (2, 4, 8, 16) > dpi0_sel > mm_dpi0_dpi0 > > Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC") > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> I wonder what CLK_TOP_VPLL_DPIX_EN is for, but since you've ruled it out by removing the dependency, this clock is 100% being disabled because unused and the DPI interface clearly still works. I also wonder if that clock is getting en/disabled by HW control mechanism... ...because that'd make sense, as this is .. well, a DPI clock. That's just out of curiosity though, as I'd really like to understand whenwhatwhy for stuff.... In any case, whether you have an answer or not, this commit is: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers!
Il 18/04/24 16:17, amergnat@baylibre.com ha scritto: > From: Fabien Parent <fparent@baylibre.com> > > Add DRM support for MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> There are two things that I want to point out. Please check below. The series that I've sent for adding OF Graphs [1] support to MediaTek DRM is not going to be picked in time for v6.10, but I think neither your MT8365 support series is, and that's why I'm telling you this. If your work was based off my series, you would not need to add the MT8365 ddp MAIN and EXT paths to mtk_drm_drv: you'd just add it to the bindings and then you would declare the paths in devicetree. [1]: https://lore.kernel.org/r/20240409120211.321153-1-angelogioacchino.delregno@collabora.com There's also one more comment.... > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 74832c213092..427b601309c4 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c ..snip.. > @@ -793,6 +821,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8188-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt8365-dpi", You removed the mt8365 specific compatible from the DPI driver - why did you keep it here?! that's not needed! :-) Cheers, Angelo > + .data = (void *)MTK_DPI }, > { } > }; > >
On 19/04/2024 10:01, AngeloGioacchino Del Regno wrote: > Il 18/04/24 16:17, amergnat@baylibre.com ha scritto: >> From: Fabien Parent <fparent@baylibre.com> >> >> Add DRM support for MT8365 SoC. >> >> Signed-off-by: Fabien Parent <fparent@baylibre.com> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > There are two things that I want to point out. Please check below. > > The series that I've sent for adding OF Graphs [1] support to MediaTek DRM is > not going to be picked in time for v6.10, but I think neither your MT8365 support > series is, and that's why I'm telling you this. > > If your work was based off my series, you would not need to add the MT8365 ddp > MAIN and EXT paths to mtk_drm_drv: you'd just add it to the bindings and then > you would declare the paths in devicetree. Ok then I will rebase my v4 on top of your serie > > > [1]: https://lore.kernel.org/r/20240409120211.321153-1-angelogioacchino.delregno@collabora.com > > There's also one more comment.... > >> --- >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> index 74832c213092..427b601309c4 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > ..snip.. > >> @@ -793,6 +821,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >> .data = (void *)MTK_DSI }, >> { .compatible = "mediatek,mt8188-dsi", >> .data = (void *)MTK_DSI }, >> + { .compatible = "mediatek,mt8365-dpi", > > You removed the mt8365 specific compatible from the DPI driver - why did you keep > it here?! that's not needed! :-) Sorry for that, I forgot to remove it in this driver too. Thanks to catched it. > > Cheers, > Angelo > >> + .data = (void *)MTK_DPI }, >> { } >> }; >> >
Quoting Alexandre Mergnat (2024-04-18 07:17:00) > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. > Additionnaly, "vpll_dpix" isn't used/managed. > > Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel". > > The new clock tree is: > > clk26m > lvdspll > lvdspll_X (2, 4, 8, 16) > dpi0_sel > mm_dpi0_dpi0 > > Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC") > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- Applied to clk-next
The purpose of this series is to add the display support for the mt8365-evk. This is the list of HWs / IPs support added: - Connectors (HW): - HDMI - MIPI DSI (Mobile Industry Processor Interface Display Serial Interface) - HDMI bridge (it66121) - DSI pannel (startek,kd070fhfid015) - SoC display blocks (IP): - OVL0 (Overlay) - RDMA0 (Data Path Read DMA) - Color0 - CCorr0 (Color Correction) - AAL0 (Adaptive Ambient Light) - GAMMA0 - Dither0 - DSI0 (Display Serial Interface) - RDMA1 (Data Path Read DMA) - DPI0 (Display Parallel Interface) The Mediatek DSI, DPI and DRM drivers are also improved. Regards, Alex Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Changes in v3: - Drop "drm/mediatek: add mt8365 dpi support" because it's the same config as mt8192 SoC - Drop "dt-bindings: pwm: mediatek,pwm-disp: add power-domains property" because an equivalent patch has been merge already. - Add DPI clock fix in a separate commit. - Improve DTS(I) readability. - Link to v2: https://lore.kernel.org/r/20231023-display-support-v2-0-33ce8864b227@baylibre.com Changes in v2: - s/binding/compatible/ in commit messages/titles. - Improve commit messages as Conor suggest. - pwm-disp: Set power domain property for MT8365. This one is optionnal and can be used for other SoC. - Fix mediatek,dsi.yaml issue. - Remove the extra clock in the DPI node/driver and fix the dpi clock parenting to be consistent with the DPI clock assignement. - Link to v1: https://lore.kernel.org/r/20231023-display-support-v1-0-5c860ed5c33b@baylibre.com --- Alexandre Mergnat (15): dt-bindings: display: mediatek: aal: add compatible for MT8365 SoC dt-bindings: display: mediatek: ccorr: add compatible for MT8365 SoC dt-bindings: display: mediatek: color: add compatible for MT8365 SoC dt-bindings: display: mediatek: dither: add compatible for MT8365 SoC dt-bindings: display: mediatek: dsi: add compatible for MT8365 SoC dt-bindings: display: mediatek: dpi: add compatible for MT8365 dt-bindings: display: mediatek: gamma: add compatible for MT8365 SoC dt-bindings: display: mediatek: ovl: add compatible for MT8365 SoC dt-bindings: display: mediatek: rdma: add compatible for MT8365 SoC dt-bindings: pwm: mediatek,pwm-disp: add compatible for mt8365 SoC clk: mediatek: mt8365-mm: fix DPI0 parent drm/mediatek: dsi: Improves the DSI lane setup robustness arm64: defconfig: enable display connector support arm64: dts: mediatek: add display blocks support for the MT8365 SoC arm64: dts: mediatek: add display support for mt8365-evk Fabien Parent (2): dt-bindings: display: mediatek: dpi: add power-domains property drm/mediatek: add MT8365 SoC support .../bindings/display/mediatek/mediatek,aal.yaml | 1 + .../bindings/display/mediatek/mediatek,ccorr.yaml | 3 + .../bindings/display/mediatek/mediatek,color.yaml | 1 + .../bindings/display/mediatek/mediatek,dither.yaml | 1 + .../bindings/display/mediatek/mediatek,dpi.yaml | 9 ++ .../bindings/display/mediatek/mediatek,dsi.yaml | 1 + .../bindings/display/mediatek/mediatek,gamma.yaml | 1 + .../bindings/display/mediatek/mediatek,ovl.yaml | 1 + .../bindings/display/mediatek/mediatek,rdma.yaml | 1 + .../devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 + arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 180 +++++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt8365.dtsi | 133 +++++++++++++++ arch/arm64/configs/defconfig | 1 + drivers/clk/mediatek/clk-mt8365-mm.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++++ drivers/gpu/drm/mediatek/mtk_dsi.c | 2 + 16 files changed, 367 insertions(+), 1 deletion(-) --- base-commit: be0c499a5c5ff8eab746f36e2aa1e920edcb7e37 change-id: 20231023-display-support-c6418b30e419 Best regards,