| Message ID | 20240418124815.31897-2-lvzhaoxiong@huaqin.corp-partner.google.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add ili2900 timing | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 18 Apr 2024 20:48:14 +0800, lvzhaoxiong wrote: > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts' Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240418124815.31897-2-lvzhaoxiong@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 18/04/2024 14:48, lvzhaoxiong wrote: > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> Except that this was not tested, please use full name, not login, if possible. Best regards, Krzysztof
Hi lvzhaoxiong, kernel test robot noticed the following build warnings: [auto build test WARNING on hid/for-next] [also build test WARNING on robh/for-next linus/master v6.9-rc4 next-20240418] [cannot apply to dtor-input/next dtor-input/for-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/lvzhaoxiong/dt-bindings-input-i2c-hid-Introduce-Ilitek-ili2900/20240418-205059 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next patch link: https://lore.kernel.org/r/20240418124815.31897-2-lvzhaoxiong%40huaqin.corp-partner.google.com patch subject: [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 compiler: loongarch64-linux-gcc (GCC) 13.2.0 dtschema version: 2024.3.dev14+g64b72b0 reproduce: (https://download.01.org/0day-ci/archive/20240419/202404190818.TnHkpNZd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202404190818.TnHkpNZd-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) -- Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/nvmem/xlnx,zynqmp-nvmem.yaml >> Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") -- >> Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file vim +/const +22 Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml 8 9 maintainers: 10 - Cong Yang <yangcong5@huaqin.corp-partner.google.com> 11 12 description: 13 Supports the Ilitek ili9882t touchscreen controller. 14 This touchscreen controller uses the i2c-hid protocol with a reset GPIO. 15 16 allOf: 17 - $ref: /schemas/input/touchscreen/touchscreen.yaml# 18 19 properties: 20 compatible: 21 const: ilitek,ili9882t > 22 const: ilitek,ili2900 23 24 reg: 25 const: 0x41 26 27 interrupts: 28 maxItems: 1 29 30 panel: true 31 32 reset-gpios: 33 maxItems: 1 34 description: Reset GPIO. 35 36 vccio-supply: 37 description: The 1.8V supply to the touchscreen. 38 39 required: 40 - compatible 41 - reg 42 - interrupts 43 - panel 44 - vccio-supply 45
diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml index c5d9e0e919f9..5063ea2c8375 100644 --- a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml @@ -19,6 +19,7 @@ allOf: properties: compatible: const: ilitek,ili9882t + const: ilitek,ili2900 reg: const: 0x41
The ili2900 touch screen chip same as ilitek ili9882t controller has a reset gpio. Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> --- Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + 1 file changed, 1 insertion(+)