| Message ID | 20240415150349.2207075-1-jonas@kwiboo.se |
|---|---|
| Headers | show |
| Series | arm64: dts: rockchip: Add Radxa ZERO 3W/3E | expand |
On Mon, 15 Apr 2024 15:03:42 +0000, Jonas Karlman wrote: > This series adds initial support for the Radxa ZERO 3W/3E boards. > > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board > computer based on the Rockchip RK3566, with a compact form factor and > rich interfaces. > > Schematic for ZERO 3W and ZERO 3E can be found at: > https://dl.radxa.com/zero3/docs/hw/3w/radxa_zero_3w_v1110_schematic.pdf > https://dl.radxa.com/zero3/docs/hw/3e/radxa_zero_3e_v1200_schematic.pdf > > Changes in v2: > - Collect acked-by tag > - Add to Makefile > - Add patch to fix #sound-dai-cells warning > > Changes in v3: > - Fix devicetree spelling > - Sort hdmi-con, leds, pmic@20 and regulator@40 nodes > - Change to regulator-off-in-suspend for vdd_logic > - Drop patch to fix #sound-dai-cells warning, similar patch [1] already > exists > > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/ > > Jonas Karlman (2): > dt-bindings: arm: rockchip: Add Radxa ZERO 3W/3E > arm64: dts: rockchip: Add Radxa ZERO 3W/3E > > .../devicetree/bindings/arm/rockchip.yaml | 7 + > arch/arm64/boot/dts/rockchip/Makefile | 2 + > .../dts/rockchip/rk3566-radxa-zero-3e.dts | 41 ++ > .../dts/rockchip/rk3566-radxa-zero-3w.dts | 26 + > .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++ > 5 files changed, 519 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > > -- > 2.43.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3566-radxa-zero-3e.dtb rockchip/rk3566-radxa-zero-3w.dtb' for 20240415150349.2207075-1-jonas@kwiboo.se: arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dtb: hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected) from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml# arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dtb: hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected) from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
On 2024-04-15 17:03, Jonas Karlman wrote: > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board > computer based on the Rockchip RK3566, with a compact form factor and > rich interfaces. > > The ZERO 3W and ZERO 3E are basically the same size and model, but > differ only in storage and network interfaces. > > - eMMC (3W) > - SD-card (both) > - Ethernet (3E) > - WiFi/BT (3W) > > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > --- > v2: Add to Makefile > v3: Sort hdmi-con and leds nodes alphabetically > v3: Sort pmic@20 and regulator@40 nodes by reg > v3: Change to regulator-off-in-suspend for vdd_logic > > Following issue is reported by dtbs_check and is fixed by patch at [1]: > > hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected) > from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml# > > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/ > --- > arch/arm64/boot/dts/rockchip/Makefile | 2 + > .../dts/rockchip/rk3566-radxa-zero-3e.dts | 41 ++ > .../dts/rockchip/rk3566-radxa-zero-3w.dts | 26 + > .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++ > 4 files changed, 512 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > [snip] > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > new file mode 100644 > index 000000000000..ea8ade3a4c99 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi [snip] > + > +&i2c0 { > + status = "okay"; > + [snip] > + vdd_cpu: regulator@40 { > + compatible = "silergy,syr827"; After checking once more on schematic and inspecting the board this is actually a RK860-0 regulator and should use following: compatible = "rockchip,rk8600"; Will send a v4 with this change later this week. Regards, Jonas > + reg = <0x40>; > + fcs,suspend-voltage-selector = <1>; > + regulator-name = "vdd_cpu"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <712500>; > + regulator-max-microvolt = <1390000>; > + regulator-ramp-delay = <2300>; > + vin-supply = <&vcc_sys>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > +}; [snip]
Am Dienstag, 16. April 2024, 10:05:09 CEST schrieb Jonas Karlman: > On 2024-04-15 17:03, Jonas Karlman wrote: > > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board > > computer based on the Rockchip RK3566, with a compact form factor and > > rich interfaces. > > > > The ZERO 3W and ZERO 3E are basically the same size and model, but > > differ only in storage and network interfaces. > > > > - eMMC (3W) > > - SD-card (both) > > - Ethernet (3E) > > - WiFi/BT (3W) > > > > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB. > > > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > > --- > > v2: Add to Makefile > > v3: Sort hdmi-con and leds nodes alphabetically > > v3: Sort pmic@20 and regulator@40 nodes by reg > > v3: Change to regulator-off-in-suspend for vdd_logic > > > > Following issue is reported by dtbs_check and is fixed by patch at [1]: > > > > hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected) > > from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml# > > > > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/ > > --- > > arch/arm64/boot/dts/rockchip/Makefile | 2 + > > .../dts/rockchip/rk3566-radxa-zero-3e.dts | 41 ++ > > .../dts/rockchip/rk3566-radxa-zero-3w.dts | 26 + > > .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++ > > 4 files changed, 512 insertions(+) > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > > > > [snip] > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > > new file mode 100644 > > index 000000000000..ea8ade3a4c99 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi > > [snip] > > > + > > +&i2c0 { > > + status = "okay"; > > + > > [snip] > > > + vdd_cpu: regulator@40 { > > + compatible = "silergy,syr827"; > > After checking once more on schematic and inspecting the board this is > actually a RK860-0 regulator and should use following: > > compatible = "rockchip,rk8600"; > > Will send a v4 with this change later this week. ok, will wait for that then. Heiko