| Message ID | 55ab78c9f2781b31278395f9e0066041f97b00f6.1713180904.git.michal.simek@amd.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Kconfig: some cleanups | expand |
On 15.04.24 13:35, Michal Simek wrote: > Some of Kconfigs are using utf-8 encoding because of used chars. Convert > all of them to ascii enconging. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > There are other files which are using utf-8 enconding and pretty much I > think we should convert all of them because there is no reason to use utf-8 > encoding. Hello Michal, The commit message does not explain why we should refrain from using UTF-8. > > --- > arch/arm/mach-rockchip/px30/Kconfig | 4 ++-- > arch/arm/mach-rockchip/rk3588/Kconfig | 6 +++--- > arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++-- > drivers/mtd/spi/Kconfig | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig > index 41893920cb4d..23f8f430c4ae 100644 > --- a/arch/arm/mach-rockchip/px30/Kconfig > +++ b/arch/arm/mach-rockchip/px30/Kconfig > @@ -36,9 +36,9 @@ config TARGET_PX30_CORE > 10.1" OF for creating complete PX30.Core C.TOUCH 2.0 10.1" Open Frame. > > config TARGET_RINGNECK_PX30 > - bool "Theobroma Systems PX30-µQ7 (Ringneck)" > + bool "Theobroma Systems PX30-uQ7 (Ringneck)" > help > - The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm, > + The PX30-uQ7 (Ringneck) SoM is a uQseven-compatible (40mmx70mm, > MXM-230 connector) system-on-module from Theobroma Systems[1], > featuring the Rockchip PX30. > > diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig b/arch/arm/mach-rockchip/rk3588/Kconfig > index eb956b097c74..39049ab35a9c 100644 > --- a/arch/arm/mach-rockchip/rk3588/Kconfig > +++ b/arch/arm/mach-rockchip/rk3588/Kconfig > @@ -66,7 +66,7 @@ config TARGET_NANOPCT6_RK3588 > HDMI2.0, and HDMI1.4 > 2x 4-lane MIPI-DSI, compatible with MIPI DPHY 2.0 or CPHY 1.1 > USB-A: USB 3.0, Type A > - USB-C: Full function USB Type‑C port, DP display up to 4Kp60, USB 3.0 > + USB-C: Full function USB Type-C port, DP display up to 4Kp60, USB 3.0 > 40-pin 2.54mm header connector: up to 2x SPIs, 6x UARTs, 1x I2Cs, > 8x PWMs, 2x I2Ss, 28x GPIOs > Debug UART: 3 Pin 2.54mm header, 3V level, 1500000bps > @@ -117,7 +117,7 @@ config TARGET_ROCK5A_RK3588 > Mali G610MC4 GPU > MIPI CSI 2 multiple lanes connector > 4-lane MIPI DSI connector > - Audio – 3.5mm earphone jack > + Audio - 3.5mm earphone jack > eMMC module connector > uSD slot (up to 128GB) > 2x USB 2.0, 2x USB 3.0 > @@ -197,7 +197,7 @@ config TARGET_TOYBRICK_RK3588 > 4x ARM Cortex-A76, 4x ARM Cortex-A55 > 8/16GB Memory LPDDR4x > Mali G610MC4 GPU > - 2× MIPI-CSI0 Connector > + 2x MIPI-CSI0 Connector > 1x 2Lanes PCIe3.0 Connector > 1x SATA3.0 Connector > 32GB eMMC Module > diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig > index ae323ee91235..64a70f61f894 100644 > --- a/arch/arm/mach-rockchip/rv1126/Kconfig > +++ b/arch/arm/mach-rockchip/rv1126/Kconfig > @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 > Neu2: > Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module > based on Rockchip RV1126 from Edgeble AI. > - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. > - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. > + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. > + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. C is the sign for coulomb which is the unit of electric charge. How about 'deg C'? Best regards Heinrich > > Neu2-IO: > Neural Compute Module 2(Neu2) IO board is an industrial form factor > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index d068b7860e1c..bedc4e970e43 100644 > --- a/drivers/mtd/spi/Kconfig > +++ b/drivers/mtd/spi/Kconfig > @@ -246,7 +246,7 @@ config SPI_FLASH_USE_4K_SECTORS > to erasing whole blocks (32/64 KiB). > Changing a small part of the flash's contents is usually faster with > small sectors. On the other hand erasing should be faster when using > - 64 KiB block instead of 16 × 4 KiB sectors. > + 64 KiB block instead of 16 x 4 KiB sectors. > > Please note that some tools/drivers/filesystems may not work with > 4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum).
On 4/15/24 14:22, Heinrich Schuchardt wrote: > On 15.04.24 13:35, Michal Simek wrote: >> Some of Kconfigs are using utf-8 encoding because of used chars. Convert >> all of them to ascii enconging. >> >> Signed-off-by: Michal Simek <michal.simek@amd.com> >> --- >> >> There are other files which are using utf-8 enconding and pretty much I >> think we should convert all of them because there is no reason to use utf-8 >> encoding. > > Hello Michal, > > The commit message does not explain why we should refrain from using UTF-8. that's a good point. I was thinking about the reason for it and pretty much wanted to get feedback from Tom about it. In doc/develop/sending_patches.rst is said that patches should be sent as plain text but encoding is not specified. Traditionally this was ASCII and I pretty much don't see the reason to use UTF encoding (even my name has special czech char which I am not using, the same is for Marek Vasut). Thanks, Michal
On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: > On 15.04.24 13:35, Michal Simek wrote: > > Some of Kconfigs are using utf-8 encoding because of used chars. Convert > > all of them to ascii enconging. > > > > Signed-off-by: Michal Simek <michal.simek@amd.com> [snip] > > diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig > > index ae323ee91235..64a70f61f894 100644 > > --- a/arch/arm/mach-rockchip/rv1126/Kconfig > > +++ b/arch/arm/mach-rockchip/rv1126/Kconfig > > @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 > > Neu2: > > Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module > > based on Rockchip RV1126 from Edgeble AI. > > - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. > > - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. > > + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. > > + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. > > C is the sign for coulomb which is the unit of electric charge. How > about 'deg C'? I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.
On Mon, Apr 15, 2024 at 02:49:13PM +0200, Michal Simek wrote: > > > On 4/15/24 14:22, Heinrich Schuchardt wrote: > > On 15.04.24 13:35, Michal Simek wrote: > > > Some of Kconfigs are using utf-8 encoding because of used chars. Convert > > > all of them to ascii enconging. > > > > > > Signed-off-by: Michal Simek <michal.simek@amd.com> > > > --- > > > > > > There are other files which are using utf-8 enconding and pretty much I > > > think we should convert all of them because there is no reason to use utf-8 > > > encoding. > > > > Hello Michal, > > > > The commit message does not explain why we should refrain from using UTF-8. > > that's a good point. I was thinking about the reason for it and pretty much > wanted to get feedback from Tom about it. > > In doc/develop/sending_patches.rst is said that patches should be sent as > plain text but encoding is not specified. Traditionally this was ASCII and I > pretty much don't see the reason to use UTF encoding (even my name has > special czech char which I am not using, the same is for Marek Vasut). My point of view is that I think ASCII should be used in general, with the exception being names (I won't force people to ASCII-ize their names, modern systems handle UTF-8 just fine). I actually don't know if we should also exclude rST doc files from this rule as well as UTF-8 should render fine and for example "°C" reads nicely in web/PDF/etc.
On 4/16/24 02:36, Tom Rini wrote: > On Mon, Apr 15, 2024 at 02:49:13PM +0200, Michal Simek wrote: >> >> >> On 4/15/24 14:22, Heinrich Schuchardt wrote: >>> On 15.04.24 13:35, Michal Simek wrote: >>>> Some of Kconfigs are using utf-8 encoding because of used chars. Convert >>>> all of them to ascii enconging. >>>> >>>> Signed-off-by: Michal Simek <michal.simek@amd.com> >>>> --- >>>> >>>> There are other files which are using utf-8 enconding and pretty much I >>>> think we should convert all of them because there is no reason to use utf-8 >>>> encoding. >>> >>> Hello Michal, >>> >>> The commit message does not explain why we should refrain from using UTF-8. >> >> that's a good point. I was thinking about the reason for it and pretty much >> wanted to get feedback from Tom about it. >> >> In doc/develop/sending_patches.rst is said that patches should be sent as >> plain text but encoding is not specified. Traditionally this was ASCII and I >> pretty much don't see the reason to use UTF encoding (even my name has >> special czech char which I am not using, the same is for Marek Vasut). > > My point of view is that I think ASCII should be used in general, with > the exception being names (I won't force people to ASCII-ize their > names, modern systems handle UTF-8 just fine). I actually don't know if > we should also exclude rST doc files from this rule as well as UTF-8 > should render fine and for example "°C" reads nicely in web/PDF/etc. > I think that people the most of time just simply don't know that they are using non ASCII chars. Anyway let me send v2 with also patch for .c and .h when appropriate. Thanks, Michal
On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: > On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: > > On 15.04.24 13:35, Michal Simek wrote: > > > Some of Kconfigs are using utf-8 encoding because of used chars. Convert > > > all of them to ascii enconging. > > > > > > Signed-off-by: Michal Simek <michal.simek@amd.com> > [snip] > > > diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig > > > index ae323ee91235..64a70f61f894 100644 > > > --- a/arch/arm/mach-rockchip/rv1126/Kconfig > > > +++ b/arch/arm/mach-rockchip/rv1126/Kconfig > > > @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 > > > Neu2: > > > Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module > > > based on Rockchip RV1126 from Edgeble AI. > > > - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. > > > - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. > > > + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. > > > + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. > > > > C is the sign for coulomb which is the unit of electric charge. How > > about 'deg C'? > > I'll note that in Linux there's seemingly nothing consistent, and I'm > fine with any of "deg C" or "degrees C" or "temperature range (-40 C to > +85 C)" as all of those should be clear in context. My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ... Francesco
On 4/16/24 08:59, Francesco Dolcini wrote: > On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: >> On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: >>> On 15.04.24 13:35, Michal Simek wrote: >>>> Some of Kconfigs are using utf-8 encoding because of used chars. Convert >>>> all of them to ascii enconging. >>>> >>>> Signed-off-by: Michal Simek <michal.simek@amd.com> >> [snip] >>>> diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig >>>> index ae323ee91235..64a70f61f894 100644 >>>> --- a/arch/arm/mach-rockchip/rv1126/Kconfig >>>> +++ b/arch/arm/mach-rockchip/rv1126/Kconfig >>>> @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 >>>> Neu2: >>>> Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module >>>> based on Rockchip RV1126 from Edgeble AI. >>>> - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. >>>> - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. >>>> + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. >>>> + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. >>> >>> C is the sign for coulomb which is the unit of electric charge. How >>> about 'deg C'? >> >> I'll note that in Linux there's seemingly nothing consistent, and I'm >> fine with any of "deg C" or "degrees C" or "temperature range (-40 C to >> +85 C)" as all of those should be clear in context. > > My 2 cents ... while I agree with Tom that the context will make it > clear, it is not making it correct nor nice. Using just "C" for Celsius > degrees is horrible ... I used deg C in v2 version. Thanks, Michal
On 2024-04-16 08:59, Francesco Dolcini wrote: > On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: >> On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: >> > On 15.04.24 13:35, Michal Simek wrote: >> > > Some of Kconfigs are using utf-8 encoding because of used chars. Convert >> > > all of them to ascii enconging. >> > > >> > > Signed-off-by: Michal Simek <michal.simek@amd.com> >> [snip] >> > > diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig >> > > index ae323ee91235..64a70f61f894 100644 >> > > --- a/arch/arm/mach-rockchip/rv1126/Kconfig >> > > +++ b/arch/arm/mach-rockchip/rv1126/Kconfig >> > > @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 >> > > Neu2: >> > > Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module >> > > based on Rockchip RV1126 from Edgeble AI. >> > > - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. >> > > - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. >> > > + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. >> > > + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. >> > >> > C is the sign for coulomb which is the unit of electric charge. How >> > about 'deg C'? >> >> I'll note that in Linux there's seemingly nothing consistent, and I'm >> fine with any of "deg C" or "degrees C" or "temperature range (-40 C >> to >> +85 C)" as all of those should be clear in context. > > My 2 cents ... while I agree with Tom that the context will make it > clear, it is not making it correct nor nice. Using just "C" for Celsius > degrees is horrible ... FWIW, I usually use "oC", which is far from perfect, but IMHO also far from horrible. :)
On Tue, Apr 16, 2024 at 03:18:08PM +0200, Dragan Simic wrote: > On 2024-04-16 08:59, Francesco Dolcini wrote: > > On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: > > > On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: > > > > C is the sign for coulomb which is the unit of electric charge. How > > > > about 'deg C'? > > > > > > I'll note that in Linux there's seemingly nothing consistent, and I'm > > > fine with any of "deg C" or "degrees C" or "temperature range (-40 C to > > > +85 C)" as all of those should be clear in context. > > > > My 2 cents ... while I agree with Tom that the context will make it > > clear, it is not making it correct nor nice. Using just "C" for Celsius > > degrees is horrible ... > > FWIW, I usually use "oC", which is far from perfect, but IMHO also > far from horrible. :) "oC" is also horrible, "deg C" or "degrees C" that Heinrich proposed are the way to go if you need something 7-bit ascii :-). Francesco
On 2024-04-16 16:51, Francesco Dolcini wrote: > On Tue, Apr 16, 2024 at 03:18:08PM +0200, Dragan Simic wrote: >> On 2024-04-16 08:59, Francesco Dolcini wrote: >> > On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: >> > > On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: >> > > > C is the sign for coulomb which is the unit of electric charge. How >> > > > about 'deg C'? >> > > >> > > I'll note that in Linux there's seemingly nothing consistent, and I'm >> > > fine with any of "deg C" or "degrees C" or "temperature range (-40 C to >> > > +85 C)" as all of those should be clear in context. >> > >> > My 2 cents ... while I agree with Tom that the context will make it >> > clear, it is not making it correct nor nice. Using just "C" for Celsius >> > degrees is horrible ... >> >> FWIW, I usually use "oC", which is far from perfect, but IMHO also >> far from horrible. :) > > "oC" is also horrible, "deg C" or "degrees C" that Heinrich proposed > are the > way to go if you need something 7-bit ascii :-). I agree, "deg C" or "degrees C" is the way to go, and my vote goes to "degrees C". Just to clarify, I use "oC" as some kind of a shorthand when having less to type outweighs the correctness. :)
diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig index 41893920cb4d..23f8f430c4ae 100644 --- a/arch/arm/mach-rockchip/px30/Kconfig +++ b/arch/arm/mach-rockchip/px30/Kconfig @@ -36,9 +36,9 @@ config TARGET_PX30_CORE 10.1" OF for creating complete PX30.Core C.TOUCH 2.0 10.1" Open Frame. config TARGET_RINGNECK_PX30 - bool "Theobroma Systems PX30-µQ7 (Ringneck)" + bool "Theobroma Systems PX30-uQ7 (Ringneck)" help - The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm, + The PX30-uQ7 (Ringneck) SoM is a uQseven-compatible (40mmx70mm, MXM-230 connector) system-on-module from Theobroma Systems[1], featuring the Rockchip PX30. diff --git a/arch/arm/mach-rockchip/rk3588/Kconfig b/arch/arm/mach-rockchip/rk3588/Kconfig index eb956b097c74..39049ab35a9c 100644 --- a/arch/arm/mach-rockchip/rk3588/Kconfig +++ b/arch/arm/mach-rockchip/rk3588/Kconfig @@ -66,7 +66,7 @@ config TARGET_NANOPCT6_RK3588 HDMI2.0, and HDMI1.4 2x 4-lane MIPI-DSI, compatible with MIPI DPHY 2.0 or CPHY 1.1 USB-A: USB 3.0, Type A - USB-C: Full function USB Type‑C port, DP display up to 4Kp60, USB 3.0 + USB-C: Full function USB Type-C port, DP display up to 4Kp60, USB 3.0 40-pin 2.54mm header connector: up to 2x SPIs, 6x UARTs, 1x I2Cs, 8x PWMs, 2x I2Ss, 28x GPIOs Debug UART: 3 Pin 2.54mm header, 3V level, 1500000bps @@ -117,7 +117,7 @@ config TARGET_ROCK5A_RK3588 Mali G610MC4 GPU MIPI CSI 2 multiple lanes connector 4-lane MIPI DSI connector - Audio – 3.5mm earphone jack + Audio - 3.5mm earphone jack eMMC module connector uSD slot (up to 128GB) 2x USB 2.0, 2x USB 3.0 @@ -197,7 +197,7 @@ config TARGET_TOYBRICK_RK3588 4x ARM Cortex-A76, 4x ARM Cortex-A55 8/16GB Memory LPDDR4x Mali G610MC4 GPU - 2× MIPI-CSI0 Connector + 2x MIPI-CSI0 Connector 1x 2Lanes PCIe3.0 Connector 1x SATA3.0 Connector 32GB eMMC Module diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig index ae323ee91235..64a70f61f894 100644 --- a/arch/arm/mach-rockchip/rv1126/Kconfig +++ b/arch/arm/mach-rockchip/rv1126/Kconfig @@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2 Neu2: Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module based on Rockchip RV1126 from Edgeble AI. - Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC. - Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC. + Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC. + Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC. Neu2-IO: Neural Compute Module 2(Neu2) IO board is an industrial form factor diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index d068b7860e1c..bedc4e970e43 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -246,7 +246,7 @@ config SPI_FLASH_USE_4K_SECTORS to erasing whole blocks (32/64 KiB). Changing a small part of the flash's contents is usually faster with small sectors. On the other hand erasing should be faster when using - 64 KiB block instead of 16 × 4 KiB sectors. + 64 KiB block instead of 16 x 4 KiB sectors. Please note that some tools/drivers/filesystems may not work with 4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum).
Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging. Signed-off-by: Michal Simek <michal.simek@amd.com> --- There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding. --- arch/arm/mach-rockchip/px30/Kconfig | 4 ++-- arch/arm/mach-rockchip/rk3588/Kconfig | 6 +++--- arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++-- drivers/mtd/spi/Kconfig | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-)