| Message ID | 20240409123556.34299-1-mike.looijmans@topic.nl |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: power: supply: ltc3350-charger: Add bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 09/04/2024 14:35, Mike Looijmans wrote: > The LTC3350 is a backup power controller that can charge and monitor > a series stack of one to four supercapacitors. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > > --- > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On Tue, 09 Apr 2024 14:35:54 +0200, Mike Looijmans wrote: > The LTC3350 is a backup power controller that can charge and monitor > a series stack of one to four supercapacitors. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > > --- > > Changes in v2: > Rename to lltc,ltc3350.yaml > Fix spaces and indentation > > .../bindings/power/supply/lltc,ltc3350.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/power/supply/ltc3350.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240409123556.34299-1-mike.looijmans@topic.nl The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 09-04-2024 15:31, Rob Herring wrote: > On Tue, 09 Apr 2024 14:35:54 +0200, Mike Looijmans wrote: >> The LTC3350 is a backup power controller that can charge and monitor >> a series stack of one to four supercapacitors. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> >> --- >> >> Changes in v2: >> Rename to lltc,ltc3350.yaml >> Fix spaces and indentation >> >> .../bindings/power/supply/lltc,ltc3350.yaml | 54 +++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml >> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename > $id: http://devicetree.org/schemas/power/supply/ltc3350.yaml > file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml Ah, should have run the test AFTER renaming... Need a v3 then.
diff --git a/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml b/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml new file mode 100644 index 000000000000..c8e36523c689 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) 2024 Topic Embedded Products +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/ltc3350.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Linear Technology (Analog Devices) LTC3350 Supercap Charger + +maintainers: + - Mike Looijmans <mike.looijmans@topic.nl> + +description: | + The LTC3350 is a High Current Supercapacitor Backup Controller and System + Monitor. + Specifications about the charger can be found at: + https://www.analog.com/en/products/ltc3350.html + +properties: + compatible: + enum: + - lltc,ltc3350 + + reg: + maxItems: 1 + + lltc,rsnsc-micro-ohms: + description: Capacitor charger sense resistor in microohm. + minimum: 1000 + + lltc,rsnsi-micro-ohms: + description: Input current sense resistor in microohm. + minimum: 1000 + +required: + - compatible + - reg + - lltc,rsnsc-micro-ohms + - lltc,rsnsi-micro-ohms + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + charger: battery-charger@9 { + compatible = "lltc,ltc3350"; + reg = <0x9>; + lltc,rsnsc-micro-ohms = <10000>; + lltc,rsnsi-micro-ohms = <10000>; + }; + };
The LTC3350 is a backup power controller that can charge and monitor a series stack of one to four supercapacitors. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- Changes in v2: Rename to lltc,ltc3350.yaml Fix spaces and indentation .../bindings/power/supply/lltc,ltc3350.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml