| Message ID | c5eb2644-8c05-47a5-84ef-07f8ef750e1a@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: i801: Fix missing Kconfig dependency | expand |
On 04.04.2024 17:21, Heiner Kallweit wrote: > The original change adds usage of i2c_root_adapter(), which is > implemented in i2c-mux.c. So we need I2C_MUX to avoid a linker error. > > Fixes: 71b494e043d2 ("i2c: i801: Call i2c_register_spd for muxed child segments") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404042206.MjAQC32x-lkp@intel.com/ > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 97989c914..201c5fc17 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -111,6 +111,7 @@ config I2C_I801 > select P2SB if X86 > select CHECK_SIGNATURE if X86 && DMI > select I2C_SMBUS > + select I2C_MUX > help > If you say yes to this option, support will be included for the Intel > 801 family of mainboard I2C interfaces. Specifically, the following Please disregard, I'll send an improved version shortly. Issue with this version is that I2C_MUX may be enabled even if I2C_MUX_GPIO is unset and the mux part is disabled.
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 97989c914..201c5fc17 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -111,6 +111,7 @@ config I2C_I801 select P2SB if X86 select CHECK_SIGNATURE if X86 && DMI select I2C_SMBUS + select I2C_MUX help If you say yes to this option, support will be included for the Intel 801 family of mainboard I2C interfaces. Specifically, the following
The original change adds usage of i2c_root_adapter(), which is implemented in i2c-mux.c. So we need I2C_MUX to avoid a linker error. Fixes: 71b494e043d2 ("i2c: i801: Call i2c_register_spd for muxed child segments") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404042206.MjAQC32x-lkp@intel.com/ Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+)