| Message ID | 20240402130221.58706-4-newtwen+github@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] lldpd: fixed interface(s) parsing | expand |
Hi, What's the purpose of this isolated comment? Either we're shipping version >= v1.0.15 so this code is guaranteed to work or we don't, in which case the code should not be there. We're not putting such comments next to all other option handling code either. ~ Jo
On 2024-04-03 01:15, Jo-Philipp Wich wrote: > Hi, > > What's the purpose of this isolated comment? Either we're shipping version >= v1.0.15 so this code is guaranteed to work or we don't, in which case the code should not be there. We're not putting such comments next to all other option handling code either. Evidence that people think in one direction only. > ~ Jo "What's the purpose of having code review at all?" Comments tell us things. They are *extremely* helpful for those cherry-picking: it is safe to drop such a commit into any older build which has at least that lldpd version. Hope you can see the value in that.
diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 0334156fee..284c37c2ef 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -120,6 +120,7 @@ write_lldpd_conf() local lldp_mgmt_ip config_get lldp_mgmt_ip 'config' 'lldp_mgmt_ip' + # Configurable capabilities in lldpd >= v1.0.15 local lldp_syscapabilities config_get lldp_syscapabilities 'config' 'lldp_syscapabilities'
only available from >= 1.0.15 Signed-off-by: Paul Donald <newtwen+github@gmail.com> --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+)