| Message ID | 137c184267faacdc3024f0b88e53889571165a84.1711715780.git.geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: timer: renesas,tmu: Make interrupt-names required | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29/03/2024 13:37, Geert Uytterhoeven wrote: > Now all in-tree users have been updated with interrupt-names properties > according to commit 0076a37a426b6c85 ("dt-bindings: timer: renesas,tmu: > Document input capture interrupt"), make interrupt-names required. Would be nice to see here *why* they should be required, e.g. "Linux driver needs them since commit foobar"). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/timer/renesas,tmu.yaml | 1 + > 1 file changed, 1 insertion(+) Anyway: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On Fri, Mar 29, 2024 at 6:42 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 29/03/2024 13:37, Geert Uytterhoeven wrote: > > Now all in-tree users have been updated with interrupt-names properties > > according to commit 0076a37a426b6c85 ("dt-bindings: timer: renesas,tmu: > > Document input capture interrupt"), make interrupt-names required. > > Would be nice to see here *why* they should be required, e.g. "Linux > driver needs them since commit foobar"). The driver doesn't use the names, nor the optional input capture interrupt yet. This is just part of the continuous improvement of Very Old and Immature DT Bindings, dating back to the days when most animals could still talk, and before DT became self-aware. I could add that (or something simpler ;-) for v2, but as the reason is basically the "for clarity" in the linked commit.... > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Documentation/devicetree/bindings/timer/renesas,tmu.yaml | 1 + > > 1 file changed, 1 insertion(+) > > Anyway: > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks! Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml index fde72eec7cb3cc8d..50b5225ceb10b64c 100644 --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml @@ -94,6 +94,7 @@ required: - compatible - reg - interrupts + - interrupt-names - clocks - clock-names - power-domains
Now all in-tree users have been updated with interrupt-names properties according to commit 0076a37a426b6c85 ("dt-bindings: timer: renesas,tmu: Document input capture interrupt"), make interrupt-names required. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/timer/renesas,tmu.yaml | 1 + 1 file changed, 1 insertion(+)