| Message ID | 20240327143044.1109911-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Fix acpi_power_meter accessing IPMI region before it's ready | expand |
On 3/27/24 22:30, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2059263 > > [Impact] > ACPI error can be found in kernel message: > [ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130) > > [Fix] > On Dell systems that have IPI0001 device, ensure IPMI region is ready > before acpi_power_meter invokes any ACPI method. > > [Test] > With the patch applied, no such error can be found in kernel message. > acpi_power_meter sysfs also works correctly. > > [Where problems could occur] > If asynchronous probe is disabled, the device drivers that probe after > acpi_power_meter needs to wait until the completion is done, hence the > boot time might be slower. > > Kai-Heng Feng (2): > ACPI: IPMI: Add helper to wait for when SMI is selected > hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell > systems > > drivers/acpi/acpi_ipmi.c | 23 ++++++++++++++++++++++- > drivers/hwmon/acpi_power_meter.c | 16 ++++++++++++++++ > include/acpi/acpi_bus.h | 5 +++++ > 3 files changed, 43 insertions(+), 1 deletion(-) Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>
On Wed, Mar 27, 2024 at 10:30:42PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2059263 > > [Impact] > ACPI error can be found in kernel message: > [ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130) > > [Fix] > On Dell systems that have IPI0001 device, ensure IPMI region is ready > before acpi_power_meter invokes any ACPI method. > > [Test] > With the patch applied, no such error can be found in kernel message. > acpi_power_meter sysfs also works correctly. > > [Where problems could occur] > If asynchronous probe is disabled, the device drivers that probe after > acpi_power_meter needs to wait until the completion is done, hence the > boot time might be slower. > > Kai-Heng Feng (2): > ACPI: IPMI: Add helper to wait for when SMI is selected > hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell > systems > > drivers/acpi/acpi_ipmi.c | 23 ++++++++++++++++++++++- > drivers/hwmon/acpi_power_meter.c | 16 ++++++++++++++++ > include/acpi/acpi_bus.h | 5 +++++ > 3 files changed, 43 insertions(+), 1 deletion(-) Acked-by: Portia Stephens <portia.stephens@canonical.com>
On Wed, Mar 27, 2024 at 10:30:42PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2059263
On 27/03/2024 15:30, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2059263 > > [Impact] > ACPI error can be found in kernel message: > [ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130) > > [Fix] > On Dell systems that have IPI0001 device, ensure IPMI region is ready > before acpi_power_meter invokes any ACPI method. > > [Test] > With the patch applied, no such error can be found in kernel message. > acpi_power_meter sysfs also works correctly. > > [Where problems could occur] > If asynchronous probe is disabled, the device drivers that probe after > acpi_power_meter needs to wait until the completion is done, hence the > boot time might be slower. > > Kai-Heng Feng (2): > ACPI: IPMI: Add helper to wait for when SMI is selected > hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell > systems > > drivers/acpi/acpi_ipmi.c | 23 ++++++++++++++++++++++- > drivers/hwmon/acpi_power_meter.c | 16 ++++++++++++++++ > include/acpi/acpi_bus.h | 5 +++++ > 3 files changed, 43 insertions(+), 1 deletion(-) Applied to mantic master-next branch. Thanks!
BugLink: https://bugs.launchpad.net/bugs/2059263 [Impact] ACPI error can be found in kernel message: [ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130) [Fix] On Dell systems that have IPI0001 device, ensure IPMI region is ready before acpi_power_meter invokes any ACPI method. [Test] With the patch applied, no such error can be found in kernel message. acpi_power_meter sysfs also works correctly. [Where problems could occur] If asynchronous probe is disabled, the device drivers that probe after acpi_power_meter needs to wait until the completion is done, hence the boot time might be slower. Kai-Heng Feng (2): ACPI: IPMI: Add helper to wait for when SMI is selected hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems drivers/acpi/acpi_ipmi.c | 23 ++++++++++++++++++++++- drivers/hwmon/acpi_power_meter.c | 16 ++++++++++++++++ include/acpi/acpi_bus.h | 5 +++++ 3 files changed, 43 insertions(+), 1 deletion(-)