| Message ID | 20240330111121.5935-1-Maxim.Moskalets@kaspersky.com |
|---|---|
| State | Accepted |
| Commit | 0ceb1f4cb7e4cab060da29215773d12dca1332ec |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | lib: add missing line breaks in debug messages | expand |
On 3/30/24 12:11, Maxim Moskalets wrote: > Add missing line breaks to improve debug log readability. > > Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > lib/rsa/rsa-verify.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c > index 1007b6979a..d3b4f71d6b 100644 > --- a/lib/rsa/rsa-verify.c > +++ b/lib/rsa/rsa-verify.c > @@ -342,7 +342,7 @@ static int rsa_verify_key(struct image_sign_info *info, > return -EINVAL; > } > > - debug("Checksum algorithm: %s", checksum->name); > + debug("Checksum algorithm: %s\n", checksum->name); > > /* Sanity check for stack size */ > if (sig_len > RSA_MAX_SIG_BITS / 8) { > @@ -444,13 +444,13 @@ static int rsa_verify_with_keynode(struct image_sign_info *info, > const char *algo; > > if (node < 0) { > - debug("%s: Skipping invalid node", __func__); > + debug("%s: Skipping invalid node\n", __func__); > return -EBADF; > } > > algo = fdt_getprop(blob, node, "algo", NULL); > if (strcmp(info->name, algo)) { > - debug("%s: Wrong algo: have %s, expected %s", __func__, > + debug("%s: Wrong algo: have %s, expected %s\n", __func__, > info->name, algo); > return -EFAULT; > } > @@ -470,7 +470,7 @@ static int rsa_verify_with_keynode(struct image_sign_info *info, > prop.rr = fdt_getprop(blob, node, "rsa,r-squared", NULL); > > if (!prop.num_bits || !prop.modulus || !prop.rr) { > - debug("%s: Missing RSA key info", __func__); > + debug("%s: Missing RSA key info\n", __func__); > return -EFAULT; > } >
On Sat, 30 Mar 2024 14:11:21 +0300, Maxim Moskalets wrote: > Add missing line breaks to improve debug log readability. > > Applied to u-boot/master, thanks!
diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index 1007b6979a..d3b4f71d6b 100644 --- a/lib/rsa/rsa-verify.c +++ b/lib/rsa/rsa-verify.c @@ -342,7 +342,7 @@ static int rsa_verify_key(struct image_sign_info *info, return -EINVAL; } - debug("Checksum algorithm: %s", checksum->name); + debug("Checksum algorithm: %s\n", checksum->name); /* Sanity check for stack size */ if (sig_len > RSA_MAX_SIG_BITS / 8) { @@ -444,13 +444,13 @@ static int rsa_verify_with_keynode(struct image_sign_info *info, const char *algo; if (node < 0) { - debug("%s: Skipping invalid node", __func__); + debug("%s: Skipping invalid node\n", __func__); return -EBADF; } algo = fdt_getprop(blob, node, "algo", NULL); if (strcmp(info->name, algo)) { - debug("%s: Wrong algo: have %s, expected %s", __func__, + debug("%s: Wrong algo: have %s, expected %s\n", __func__, info->name, algo); return -EFAULT; } @@ -470,7 +470,7 @@ static int rsa_verify_with_keynode(struct image_sign_info *info, prop.rr = fdt_getprop(blob, node, "rsa,r-squared", NULL); if (!prop.num_bits || !prop.modulus || !prop.rr) { - debug("%s: Missing RSA key info", __func__); + debug("%s: Missing RSA key info\n", __func__); return -EFAULT; }
Add missing line breaks to improve debug log readability. Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com> --- lib/rsa/rsa-verify.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)