| Message ID | 20240318171637.12664-3-othacehe@gnu.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | imx93-phyboard-segin: Add USB support. | expand |
On 3/18/24 6:16 PM, Mathieu Othacehe wrote: > Enable the `usb` command and some USB drivers. > > Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> > --- > configs/imx93-phyboard-segin_defconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configs/imx93-phyboard-segin_defconfig b/configs/imx93-phyboard-segin_defconfig > index 24f9bd553aa..5acb987b817 100644 > --- a/configs/imx93-phyboard-segin_defconfig > +++ b/configs/imx93-phyboard-segin_defconfig > @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 > CONFIG_SPL=y > CONFIG_ENV_OFFSET_REDUND=0x720000 > CONFIG_CMD_DEKBLOB=y > +CONFIG_CMD_USB=y > CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 > CONFIG_SYS_LOAD_ADDR=0x80400000 > CONFIG_SYS_MEMTEST_START=0x80000000 > @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y > CONFIG_SYSRESET_WATCHDOG=y > CONFIG_DM_THERMAL=y > CONFIG_IMX_TMU=y > +CONFIG_USB=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 > +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 Shouldn't this by Phytec or similar USB IDs ?
Hi Mathieu, On 18. 03. 24 18:16, Mathieu Othacehe wrote: > Enable the `usb` command and some USB drivers. > I would rephrase commit msg to something like this: Add USB support by enabling `usb` command and required USB drivers. > Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> > --- > configs/imx93-phyboard-segin_defconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configs/imx93-phyboard-segin_defconfig b/configs/imx93-phyboard-segin_defconfig > index 24f9bd553aa..5acb987b817 100644 > --- a/configs/imx93-phyboard-segin_defconfig > +++ b/configs/imx93-phyboard-segin_defconfig > @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 > CONFIG_SPL=y > CONFIG_ENV_OFFSET_REDUND=0x720000 > CONFIG_CMD_DEKBLOB=y > +CONFIG_CMD_USB=y Can you run $ make savedefconfig && cp defconfig configs/imx93-phyboard-segin_defconfig to re-order CONFIG_CMD_USB please? > CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 > CONFIG_SYS_LOAD_ADDR=0x80400000 > CONFIG_SYS_MEMTEST_START=0x80000000 > @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y > CONFIG_SYSRESET_WATCHDOG=y > CONFIG_DM_THERMAL=y > CONFIG_IMX_TMU=y > +CONFIG_USB=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 > +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 > +CONFIG_CI_UDC=y > CONFIG_ULP_WATCHDOG=y > CONFIG_LZO=y > CONFIG_BZIP2=y
Am 18.03.24 um 22:48 schrieb Marek Vasut: > On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >> Enable the `usb` command and some USB drivers. >> >> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> >> --- >> configs/imx93-phyboard-segin_defconfig | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/configs/imx93-phyboard-segin_defconfig >> b/configs/imx93-phyboard-segin_defconfig >> index 24f9bd553aa..5acb987b817 100644 >> --- a/configs/imx93-phyboard-segin_defconfig >> +++ b/configs/imx93-phyboard-segin_defconfig >> @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 >> CONFIG_SPL=y >> CONFIG_ENV_OFFSET_REDUND=0x720000 >> CONFIG_CMD_DEKBLOB=y >> +CONFIG_CMD_USB=y >> CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 >> CONFIG_SYS_LOAD_ADDR=0x80400000 >> CONFIG_SYS_MEMTEST_START=0x80000000 >> @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y >> CONFIG_SYSRESET_WATCHDOG=y >> CONFIG_DM_THERMAL=y >> CONFIG_IMX_TMU=y >> +CONFIG_USB=y >> +CONFIG_USB_EHCI_HCD=y >> +CONFIG_USB_GADGET=y >> +CONFIG_USB_GADGET_MANUFACTURER="FSL" >> +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 >> +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 > > Shouldn't this by Phytec or similar USB IDs ? AFAIK, PHYTEC does not have its own IDs registered yet. So the freescale IDs should be fine.
On 3/19/24 9:39 AM, Wadim Egorov wrote: > > Am 18.03.24 um 22:48 schrieb Marek Vasut: >> On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >>> Enable the `usb` command and some USB drivers. >>> >>> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> >>> --- >>> configs/imx93-phyboard-segin_defconfig | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/configs/imx93-phyboard-segin_defconfig >>> b/configs/imx93-phyboard-segin_defconfig >>> index 24f9bd553aa..5acb987b817 100644 >>> --- a/configs/imx93-phyboard-segin_defconfig >>> +++ b/configs/imx93-phyboard-segin_defconfig >>> @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 >>> CONFIG_SPL=y >>> CONFIG_ENV_OFFSET_REDUND=0x720000 >>> CONFIG_CMD_DEKBLOB=y >>> +CONFIG_CMD_USB=y >>> CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 >>> CONFIG_SYS_LOAD_ADDR=0x80400000 >>> CONFIG_SYS_MEMTEST_START=0x80000000 >>> @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y >>> CONFIG_SYSRESET_WATCHDOG=y >>> CONFIG_DM_THERMAL=y >>> CONFIG_IMX_TMU=y >>> +CONFIG_USB=y >>> +CONFIG_USB_EHCI_HCD=y >>> +CONFIG_USB_GADGET=y >>> +CONFIG_USB_GADGET_MANUFACTURER="FSL" >>> +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 >>> +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 >> >> Shouldn't this by Phytec or similar USB IDs ? > AFAIK, PHYTEC does not have its own IDs registered yet. So the freescale > IDs should be fine. Manufacturer can still be Phytec , can it not ?
Am 19.03.24 um 14:58 schrieb Marek Vasut: > On 3/19/24 9:39 AM, Wadim Egorov wrote: >> >> Am 18.03.24 um 22:48 schrieb Marek Vasut: >>> On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >>>> Enable the `usb` command and some USB drivers. >>>> >>>> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> >>>> --- >>>> configs/imx93-phyboard-segin_defconfig | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/configs/imx93-phyboard-segin_defconfig >>>> b/configs/imx93-phyboard-segin_defconfig >>>> index 24f9bd553aa..5acb987b817 100644 >>>> --- a/configs/imx93-phyboard-segin_defconfig >>>> +++ b/configs/imx93-phyboard-segin_defconfig >>>> @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 >>>> CONFIG_SPL=y >>>> CONFIG_ENV_OFFSET_REDUND=0x720000 >>>> CONFIG_CMD_DEKBLOB=y >>>> +CONFIG_CMD_USB=y >>>> CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 >>>> CONFIG_SYS_LOAD_ADDR=0x80400000 >>>> CONFIG_SYS_MEMTEST_START=0x80000000 >>>> @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y >>>> CONFIG_SYSRESET_WATCHDOG=y >>>> CONFIG_DM_THERMAL=y >>>> CONFIG_IMX_TMU=y >>>> +CONFIG_USB=y >>>> +CONFIG_USB_EHCI_HCD=y >>>> +CONFIG_USB_GADGET=y >>>> +CONFIG_USB_GADGET_MANUFACTURER="FSL" >>>> +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 >>>> +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 >>> >>> Shouldn't this by Phytec or similar USB IDs ? >> AFAIK, PHYTEC does not have its own IDs registered yet. So the >> freescale IDs should be fine. > > Manufacturer can still be Phytec , can it not ? Yes, we can use PHYTEC for manufacturer.
diff --git a/configs/imx93-phyboard-segin_defconfig b/configs/imx93-phyboard-segin_defconfig index 24f9bd553aa..5acb987b817 100644 --- a/configs/imx93-phyboard-segin_defconfig +++ b/configs/imx93-phyboard-segin_defconfig @@ -23,6 +23,7 @@ CONFIG_SPL_STACK=0x20519dd0 CONFIG_SPL=y CONFIG_ENV_OFFSET_REDUND=0x720000 CONFIG_CMD_DEKBLOB=y +CONFIG_CMD_USB=y CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x88000000 CONFIG_SYS_LOAD_ADDR=0x80400000 CONFIG_SYS_MEMTEST_START=0x80000000 @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y CONFIG_SYSRESET_WATCHDOG=y CONFIG_DM_THERMAL=y CONFIG_IMX_TMU=y +CONFIG_USB=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_MANUFACTURER="FSL" +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 +CONFIG_CI_UDC=y CONFIG_ULP_WATCHDOG=y CONFIG_LZO=y CONFIG_BZIP2=y
Enable the `usb` command and some USB drivers. Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> --- configs/imx93-phyboard-segin_defconfig | 8 ++++++++ 1 file changed, 8 insertions(+)