| Message ID | 20240318171637.12664-2-othacehe@gnu.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | imx93-phyboard-segin: Add USB support. | expand |
On 3/18/24 6:16 PM, Mathieu Othacehe wrote: > Enable both usbotg1 and usbotg2 ports. Drop fullstop from $subject end. > Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> > --- > arch/arm/dts/imx93-phyboard-segin.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/dts/imx93-phyboard-segin.dts b/arch/arm/dts/imx93-phyboard-segin.dts > index 85fb188b057..acf307a3192 100644 > --- a/arch/arm/dts/imx93-phyboard-segin.dts > +++ b/arch/arm/dts/imx93-phyboard-segin.dts > @@ -40,6 +40,19 @@ > status = "okay"; > }; > > +/* USB */ > +&usbotg1 { > + disable-over-current; Why is this needed ?
Hi Marek, On 18. 03. 24 22:48, Marek Vasut wrote: > On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >> Enable both usbotg1 and usbotg2 ports. > > Drop fullstop from $subject end. > >> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> >> --- >> arch/arm/dts/imx93-phyboard-segin.dts | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/dts/imx93-phyboard-segin.dts >> b/arch/arm/dts/imx93-phyboard-segin.dts >> index 85fb188b057..acf307a3192 100644 >> --- a/arch/arm/dts/imx93-phyboard-segin.dts >> +++ b/arch/arm/dts/imx93-phyboard-segin.dts >> @@ -40,6 +40,19 @@ >> status = "okay"; >> }; >> +/* USB */ >> +&usbotg1 { >> + disable-over-current; > > Why is this needed ? OC pins are not connected to the SoC thus disable OC to avoid warnings (c/p from kernel dts). BR, Primoz
On 3/19/24 9:26 AM, Primoz Fiser wrote: > Hi Marek, > > On 18. 03. 24 22:48, Marek Vasut wrote: >> On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >>> Enable both usbotg1 and usbotg2 ports. >> >> Drop fullstop from $subject end. >> >>> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> >>> --- >>> arch/arm/dts/imx93-phyboard-segin.dts | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/arch/arm/dts/imx93-phyboard-segin.dts >>> b/arch/arm/dts/imx93-phyboard-segin.dts >>> index 85fb188b057..acf307a3192 100644 >>> --- a/arch/arm/dts/imx93-phyboard-segin.dts >>> +++ b/arch/arm/dts/imx93-phyboard-segin.dts >>> @@ -40,6 +40,19 @@ >>> status = "okay"; >>> }; >>> +/* USB */ >>> +&usbotg1 { >>> + disable-over-current; >> >> Why is this needed ? > > OC pins are not connected to the SoC thus disable OC to avoid warnings > (c/p from kernel dts). Please add it to the commit message for posterity, thanks.
diff --git a/arch/arm/dts/imx93-phyboard-segin.dts b/arch/arm/dts/imx93-phyboard-segin.dts index 85fb188b057..acf307a3192 100644 --- a/arch/arm/dts/imx93-phyboard-segin.dts +++ b/arch/arm/dts/imx93-phyboard-segin.dts @@ -40,6 +40,19 @@ status = "okay"; }; +/* USB */ +&usbotg1 { + disable-over-current; + dr_mode = "otg"; + status = "okay"; +}; + +&usbotg2 { + disable-over-current; + dr_mode = "host"; + status = "okay"; +}; + /* eMMC */ &usdhc1 { no-1-8-v;
Enable both usbotg1 and usbotg2 ports. Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> --- arch/arm/dts/imx93-phyboard-segin.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)