| Message ID | ZeixBas1PNcz2Fbo@localhost.localdomain |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] riscv: Update nofpu libm test ulps | expand |
* Darius Rad: > Fix two test failures. > --- > Changes since v1: > - Rebase to master > - Fix corrupted diff line in patch > > sysdeps/riscv/nofpu/libm-test-ulps | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps > index 16106f10b0..bc7e615177 100644 > --- a/sysdeps/riscv/nofpu/libm-test-ulps > +++ b/sysdeps/riscv/nofpu/libm-test-ulps > @@ -1043,6 +1043,7 @@ ldouble: 8 > > Function: "hypot": > double: 1 > +float: 1 > ldouble: 1 > > Function: "hypot_downward": Looks okay. Reviewed-by: Florian Weimer <fweimer@redhat.com> Do you have sourceware commit access? If not, I can push the change for you. (ULP updates like this can also be pushed without review as obvious, I think.) Thanks, Florian
On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote: > * Darius Rad: > > > Fix two test failures. > > --- > > Changes since v1: > > - Rebase to master > > - Fix corrupted diff line in patch > > > > sysdeps/riscv/nofpu/libm-test-ulps | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps > > index 16106f10b0..bc7e615177 100644 > > --- a/sysdeps/riscv/nofpu/libm-test-ulps > > +++ b/sysdeps/riscv/nofpu/libm-test-ulps > > @@ -1043,6 +1043,7 @@ ldouble: 8 > > > > Function: "hypot": > > double: 1 > > +float: 1 > > ldouble: 1 > > > > Function: "hypot_downward": > > Looks okay. > > Reviewed-by: Florian Weimer <fweimer@redhat.com> > > Do you have sourceware commit access? If not, I can push the change for > you. I do not. If you could commit it, I would appreciate it. > > (ULP updates like this can also be pushed without review as obvious, I > think.) > > Thanks, > Florian >
* Darius Rad: > On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote: >> * Darius Rad: >> >> > Fix two test failures. >> > --- >> > Changes since v1: >> > - Rebase to master >> > - Fix corrupted diff line in patch >> > >> > sysdeps/riscv/nofpu/libm-test-ulps | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps >> > index 16106f10b0..bc7e615177 100644 >> > --- a/sysdeps/riscv/nofpu/libm-test-ulps >> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps >> > @@ -1043,6 +1043,7 @@ ldouble: 8 >> > >> > Function: "hypot": >> > double: 1 >> > +float: 1 >> > ldouble: 1 >> > >> > Function: "hypot_downward": >> >> Looks okay. >> >> Reviewed-by: Florian Weimer <fweimer@redhat.com> >> >> Do you have sourceware commit access? If not, I can push the change for >> you. > > I do not. If you could commit it, I would appreciate it. I pushed it on your behalf. Thanks, Florian
diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps index 16106f10b0..bc7e615177 100644 --- a/sysdeps/riscv/nofpu/libm-test-ulps +++ b/sysdeps/riscv/nofpu/libm-test-ulps @@ -1043,6 +1043,7 @@ ldouble: 8 Function: "hypot": double: 1 +float: 1 ldouble: 1 Function: "hypot_downward":