| Message ID | 20240221161909.40317-1-romain.naour@smile.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | support/testing: TestCheckPackage: update expected strings | expand |
Romain, All, On 2024-02-21 17:19 +0100, Romain Naour spake thusly: > Commit dfed5acb56 ("utils/check-package: use https for the manual URL") > replaced the default url to the Buildroot manual while it was used > by TestCheckPackage test. > > Update TestCheckPackage with https url. > > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243484 > > Cc: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Romain Naour <romain.naour@smile.fr> Applied to master, thanks for fixing my mess! Regards, Yann E. MORIN. > --- > support/testing/tests/utils/test_check_package.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/support/testing/tests/utils/test_check_package.py b/support/testing/tests/utils/test_check_package.py > index 9aa117d211..2125b34170 100644 > --- a/support/testing/tests/utils/test_check_package.py > +++ b/support/testing/tests/utils/test_check_package.py > @@ -200,13 +200,13 @@ class TestCheckPackage(unittest.TestCase): > self.WITH_UTILS_IN_PATH, abs_path) > self.assert_file_was_processed(m) > self.assert_warnings_generated_for_file(m) > - self.assertIn("{}:1: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)".format(rel_file), w) > + self.assertIn("{}:1: should be 80 hashes (https://nightly.buildroot.org/#writing-rules-mk)".format(rel_file), w) > > w, m = call_script(["check-package", "-b", abs_file], > self.WITH_UTILS_IN_PATH, infra.basepath()) > self.assert_file_was_processed(m) > self.assert_warnings_generated_for_file(m) > - self.assertIn("{}:1: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)".format(abs_file), w) > + self.assertIn("{}:1: should be 80 hashes (https://nightly.buildroot.org/#writing-rules-mk)".format(abs_file), w) > > # br2-external with ignore list > topdir_path = infra.filepath("tests/utils/br2-external") > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes: > Commit dfed5acb56 ("utils/check-package: use https for the manual URL") > replaced the default url to the Buildroot manual while it was used > by TestCheckPackage test. > Update TestCheckPackage with https url. > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243484 > Cc: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Romain Naour <romain.naour@smile.fr> Committed to 2023.02.x and 2023.11.x, thanks.
diff --git a/support/testing/tests/utils/test_check_package.py b/support/testing/tests/utils/test_check_package.py index 9aa117d211..2125b34170 100644 --- a/support/testing/tests/utils/test_check_package.py +++ b/support/testing/tests/utils/test_check_package.py @@ -200,13 +200,13 @@ class TestCheckPackage(unittest.TestCase): self.WITH_UTILS_IN_PATH, abs_path) self.assert_file_was_processed(m) self.assert_warnings_generated_for_file(m) - self.assertIn("{}:1: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)".format(rel_file), w) + self.assertIn("{}:1: should be 80 hashes (https://nightly.buildroot.org/#writing-rules-mk)".format(rel_file), w) w, m = call_script(["check-package", "-b", abs_file], self.WITH_UTILS_IN_PATH, infra.basepath()) self.assert_file_was_processed(m) self.assert_warnings_generated_for_file(m) - self.assertIn("{}:1: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)".format(abs_file), w) + self.assertIn("{}:1: should be 80 hashes (https://nightly.buildroot.org/#writing-rules-mk)".format(abs_file), w) # br2-external with ignore list topdir_path = infra.filepath("tests/utils/br2-external")
Commit dfed5acb56 ("utils/check-package: use https for the manual URL") replaced the default url to the Buildroot manual while it was used by TestCheckPackage test. Update TestCheckPackage with https url. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243484 Cc: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Romain Naour <romain.naour@smile.fr> --- support/testing/tests/utils/test_check_package.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)