diff mbox series

package/systemd: needs sulogin for emergency target support

Message ID 20240219183828.1289275-1-buildroot@bubu1.eu
State Accepted
Headers show
Series package/systemd: needs sulogin for emergency target support | expand

Commit Message

Marcus Hoffmann Feb. 19, 2024, 6:38 p.m. UTC
systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
emergency.service/emergency.target[2].

[1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
[2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
---
 package/systemd/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN Feb. 19, 2024, 9:06 p.m. UTC | #1
Marcus, All,

On 2024-02-19 19:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
> emergency.service/emergency.target[2].
> 
> [1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
> [2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

I thinks that, technically, it could be content with sulogin from
busybox, but since we already select a lot of util-linux' tools, adding
sulogin is not goign to add much to the target size.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
>  package/systemd/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 859332d9e4..58b4e51c6d 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -34,6 +34,7 @@ menuconfig BR2_PACKAGE_SYSTEMD
>  	select BR2_PACKAGE_UTIL_LINUX_AGETTY
>  	select BR2_PACKAGE_UTIL_LINUX_MOUNT
>  	select BR2_PACKAGE_UTIL_LINUX_FSCK
> +	select BR2_PACKAGE_UTIL_LINUX_SULOGIN # emergency target
>  	select BR2_PACKAGE_KMOD
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
>  	select BR2_PACKAGE_KMOD_TOOLS
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard March 16, 2024, 9:25 p.m. UTC | #2
>>>>> "Marcus" == Marcus Hoffmann via buildroot <buildroot@buildroot.org> writes:

 > systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
 > emergency.service/emergency.target[2].

 > [1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
 > [2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

 > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>

Committed to 2023.02.x and 2023.11.x, thanks.
diff mbox series

Patch

diff --git a/package/systemd/Config.in b/package/systemd/Config.in
index 859332d9e4..58b4e51c6d 100644
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -34,6 +34,7 @@  menuconfig BR2_PACKAGE_SYSTEMD
 	select BR2_PACKAGE_UTIL_LINUX_AGETTY
 	select BR2_PACKAGE_UTIL_LINUX_MOUNT
 	select BR2_PACKAGE_UTIL_LINUX_FSCK
+	select BR2_PACKAGE_UTIL_LINUX_SULOGIN # emergency target
 	select BR2_PACKAGE_KMOD
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
 	select BR2_PACKAGE_KMOD_TOOLS