| Message ID | 20240310-samsung-hlte-v1-0-e9b55bf98a48@z3ntu.xyz |
|---|---|
| Headers | show |
| Series | Add Samsung Galaxy Note 3 support | expand |
On Sun, 10 Mar 2024 15:13:35 +0100, Luca Weiss wrote: > Add the dts for "hlte" which is a phablet from 2013. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Adam Honse (1): > ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 > > Luca Weiss (1): > dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > 3 files changed, 405 insertions(+) > --- > base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 > change-id: 20240310-samsung-hlte-78d1a287b0a8 > > Best regards, > -- > Luca Weiss <luca@z3ntu.xyz> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qcom-msm8974-samsung-hlte.dtb' for 20240310-samsung-hlte-v1-0-e9b55bf98a48@z3ntu.xyz: arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} from schema $id: http://devicetree.org/schemas/root-node.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: l2-cache: Unevaluated properties are not allowed ('qcom,saw' was unexpected) from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: idle-states: 'spc' does not match any of the regexes: '^(cpu|cluster)-', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/cpu/idle-states.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: syscon@f9011000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'amd,pensando-elba-syscon', 'brcm,cru-clkset', 'freecom,fsg-cs2-system-controller', 'fsl,imx93-aonmix-ns-syscfg', 'fsl,imx93-wakeupmix-syscfg', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'hpe,gxp-sysreg', 'intel,lgm-syscon', 'loongson,ls1b-syscon', 'loongson,ls1c-syscon', 'marvell,armada-3700-usb2-host-misc', 'mediatek,mt8135-pctl-a-syscfg', 'mediatek,mt8135-pctl-b-syscfg', 'mediatek,mt8365-syscfg', 'microchip,lan966x-cpu-syscon', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'nuvoton,ma35d1-sys', 'nuvoton,wpcm450-shm', 'rockchip,px30-qos', 'rockchip,rk3036-qos', 'rockchip,rk3066-qos', 'rockchip,rk3128-qos', 'rockchip,rk3228-qos', 'rockchip,rk3288-qos', 'rockchip,rk3368-qos', 'rockchip,rk3399-qos', 'rockchip,rk3568-qos', ' rockchip,rk3588-qos', 'rockchip,rv1126-qos', 'starfive,jh7100-sysmain', 'ti,am62-usb-phy-ctrl', 'ti,am654-dss-oldi-io-ctrl', 'ti,am654-serdes-ctrl', 'ti,j784s4-pcie-ctrl'] from schema $id: http://devicetree.org/schemas/mfd/syscon.yaml#
On Montag, 11. März 2024 15:23:30 CET Rob Herring wrote: > > On Sun, 10 Mar 2024 15:13:35 +0100, Luca Weiss wrote: > > Add the dts for "hlte" which is a phablet from 2013. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > Adam Honse (1): > > ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 > > > > Luca Weiss (1): > > dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 > > > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > > arch/arm/boot/dts/qcom/Makefile | 1 + > > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > > 3 files changed, 405 insertions(+) > > --- > > base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 > > change-id: 20240310-samsung-hlte-78d1a287b0a8 > > > > Best regards, > > -- > > Luca Weiss <luca@z3ntu.xyz> > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y qcom/qcom-msm8974-samsung-hlte.dtb' for 20240310-samsung-hlte-v1-0-e9b55bf98a48@z3ntu.xyz: > > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} > from schema $id: http://devicetree.org/schemas/root-node.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: l2-cache: Unevaluated properties are not allowed ('qcom,saw' was unexpected) > from schema $id: http://devicetree.org/schemas/cache.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: idle-states: 'spc' does not match any of the regexes: '^(cpu|cluster)-', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/cpu/idle-states.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: syscon@f9011000: compatible: 'anyOf' conditional failed, one must be fixed: > ['syscon'] is too short > 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'amd,pensando-elba-syscon', 'brcm,cru-clkset', 'freecom,fsg-cs2-system-controller', 'fsl,imx93-aonmix-ns-syscfg', 'fsl,imx93-wakeupmix-syscfg', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'hpe,gxp-sysreg', 'intel,lgm-syscon', 'loongson,ls1b-syscon', 'loongson,ls1c-syscon', 'marvell,armada-3700-usb2-host-misc', 'mediatek,mt8135-pctl-a-syscfg', 'mediatek,mt8135-pctl-b-syscfg', 'mediatek,mt8365-syscfg', 'microchip,lan966x-cpu-syscon', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'nuvoton,ma35d1-sys', 'nuvoton,wpcm450-shm', 'rockchip,px30-qos', 'rockchip,rk3036-qos', 'rockchip,rk3066-qos', 'rockchip,rk3128-qos', 'rockchip,rk3228-qos', 'rockchip,rk3288-qos', 'rockchip,rk3368-qos', 'rockchip,rk3399-qos', 'rockchip,rk3568-qos', ' > rockchip,rk3588-qos', 'rockchip,rv1126-qos', 'starfive,jh7100-sysmain', 'ti,am62-usb-phy-ctrl', 'ti,am654-dss-oldi-io-ctrl', 'ti,am654-serdes-ctrl', 'ti,j784s4-pcie-ctrl'] > from schema $id: http://devicetree.org/schemas/mfd/syscon.yaml# Unfortunately all existing warnings from the .dtsi. Regards Luca
On 3/10/24 15:13, Luca Weiss wrote: > From: Adam Honse <calcprogrammer1@gmail.com> > > Add the devicetree for this "phablet" using the Snapdragon 800 SoC. > > Signed-off-by: Adam Honse <calcprogrammer1@gmail.com> > [luca@z3ntu.xyz: clean up, prepare for upstream] > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > 2 files changed, 404 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile > index 9cc1e14e6cd0..845af12d15a2 100644 > --- a/arch/arm/boot/dts/qcom/Makefile > +++ b/arch/arm/boot/dts/qcom/Makefile > @@ -39,6 +39,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-msm8960-cdp.dtb \ > qcom-msm8960-samsung-expressatt.dtb \ > qcom-msm8974-lge-nexus5-hammerhead.dtb \ > + qcom-msm8974-samsung-hlte.dtb \ > qcom-msm8974-sony-xperia-rhine-amami.dtb \ > qcom-msm8974-sony-xperia-rhine-honami.dtb \ > qcom-msm8974pro-fairphone-fp2.dtb \ > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts > new file mode 100644 > index 000000000000..e03227a49b67 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts > @@ -0,0 +1,403 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "qcom-msm8974.dtsi" > +#include "pm8841.dtsi" > +#include "pm8941.dtsi" > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > +/ { > + model = "Samsung Galaxy Note 3"; > + compatible = "samsung,hlte", "qcom,msm8974"; > + chassis-type = "handset"; > + > + aliases { > + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ > + mmc1 = &sdhc_3; /* SDC3 SD card slot */ > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_pin_a>; property-n property-names > + > + key-home { > + label = "home_key"; "Home Key" etc. > + > + pm8941_l20: l20 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + > + regulator-allow-set-load; > + regulator-system-load = <200000>; regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; regulator-system-load = <200000>; regulator-allow-set-load; [...] Konrad
Add the dts for "hlte" which is a phablet from 2013. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Adam Honse (1): ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 Luca Weiss (1): dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Documentation/devicetree/bindings/arm/qcom.yaml | 1 + arch/arm/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ 3 files changed, 405 insertions(+) --- base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 change-id: 20240310-samsung-hlte-78d1a287b0a8 Best regards,