mbox series

[v6,0/3] auxdisplay: 7-segment LED display

Message ID 20240307195053.1320538-1-chris.packham@alliedtelesis.co.nz
Headers show
Series auxdisplay: 7-segment LED display | expand

Message

Chris Packham March 7, 2024, 7:50 p.m. UTC 
This series adds a driver for a 7-segment LED display.

I think I've addressed all of Andy's feedback in this round. I haven't
heard from the ARM maintainers on any of the previous rounds. I can
submit the dts change separately if required, I've mostly been including
it so there is an in-tree user of the driver I'm adding.

Chris Packham (3):
  auxdisplay: Add 7-segment LED display driver
  dt-bindings: auxdisplay: Add bindings for generic 7-segment LED
  ARM: dts: marvell: Add 7-segment LED display on x530

 .../bindings/auxdisplay/gpio-7-segment.yaml   |  55 +++++++++
 .../boot/dts/marvell/armada-385-atl-x530.dts  |  13 +-
 drivers/auxdisplay/Kconfig                    |  11 ++
 drivers/auxdisplay/Makefile                   |   1 +
 drivers/auxdisplay/seg-led-gpio.c             | 112 ++++++++++++++++++
 5 files changed, 191 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml
 create mode 100644 drivers/auxdisplay/seg-led-gpio.c

Comments

Geert Uytterhoeven March 8, 2024, 8:17 a.m. UTC | #1 
On Thu, Mar 7, 2024 at 8:51 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Add a driver for a 7-segment LED display. At the moment only one
> character is supported but it should be possible to expand this to
> support more characters and/or 14-segment displays in the future.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
>     Changes in v6:
>     - Enforce maximum number of GPIOs
>     - Drop unnecessary 0 in initialiser

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert
Andy Shevchenko March 8, 2024, 12:14 p.m. UTC | #2 
On Fri, Mar 08, 2024 at 08:50:50AM +1300, Chris Packham wrote:
> This series adds a driver for a 7-segment LED display.

You were too fast to miss some tags, but they are related to the last patch
which according to Arnd's suggestion I'm not going to take right now.

So, the first two on their way, thanks!