mbox series

[SRU,J:linux-bluefield,v1,0/1] mlxbf_gige: pause frame counter support

Message ID cover.1709053128.git.davthompson@nvidia.com
Headers show
Series [SRU,J:linux-bluefield,v1,1/1] UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters | expand

Message

David Thompson Feb. 27, 2024, 5:10 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2055086

SRU Justification:

[Impact]

The BlueField-2 and BlueField-3 silicon designs include a
provision for reporting pause frame counters, but the driver
(mlxbf_gige) does not have software support yet.

[Fix]

The fix is to update the mlxbf_gige driver to support the
"get_pause_stats()" callback, which enables display of
pause frame counters via "ethtool -I -a ooob_net0".
The support of this callback was added to Linux kernel 5.9.0

[Test Case]

* Reboot BF platform, and configure oob_net0 interface
* Issue command "ethtool -I -a oob_net0" to display pause frame counters
* Send in multiple streams of traffic to oob_net0 interface, e.g. from
  two or three simultaneous SCP operations
* Re-issue "ethtool -I -a oob_net0" and note difference in output

[Regression Potential]

The changed logic extends the ethtool support, so low risk for any problem.

David Thompson (1):
  UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters

 .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 39 +++++++++++++++++++
 .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 22 +++++++++++
 2 files changed, 61 insertions(+)

Comments

Bartlomiej Zolnierkiewicz Feb. 29, 2024, 1:18 p.m. UTC | #1 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Tue, Feb 27, 2024 at 6:12 PM David Thompson <davthompson@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2055086
>
> SRU Justification:
>
> [Impact]
>
> The BlueField-2 and BlueField-3 silicon designs include a
> provision for reporting pause frame counters, but the driver
> (mlxbf_gige) does not have software support yet.
>
> [Fix]
>
> The fix is to update the mlxbf_gige driver to support the
> "get_pause_stats()" callback, which enables display of
> pause frame counters via "ethtool -I -a ooob_net0".
> The support of this callback was added to Linux kernel 5.9.0
>
> [Test Case]
>
> * Reboot BF platform, and configure oob_net0 interface
> * Issue command "ethtool -I -a oob_net0" to display pause frame counters
> * Send in multiple streams of traffic to oob_net0 interface, e.g. from
>   two or three simultaneous SCP operations
> * Re-issue "ethtool -I -a oob_net0" and note difference in output
>
> [Regression Potential]
>
> The changed logic extends the ethtool support, so low risk for any problem.
>
> David Thompson (1):
>   UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters
>
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 39 +++++++++++++++++++
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 22 +++++++++++
>  2 files changed, 61 insertions(+)
>
Andrei Gherzan Feb. 29, 2024, 1:36 p.m. UTC | #2 
On 24/02/27 12:10PM, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/2055086
> 
> SRU Justification:
> 
> [Impact]
> 
> The BlueField-2 and BlueField-3 silicon designs include a
> provision for reporting pause frame counters, but the driver
> (mlxbf_gige) does not have software support yet.
> 
> [Fix]
> 
> The fix is to update the mlxbf_gige driver to support the
> "get_pause_stats()" callback, which enables display of
> pause frame counters via "ethtool -I -a ooob_net0".
> The support of this callback was added to Linux kernel 5.9.0
> 
> [Test Case]
> 
> * Reboot BF platform, and configure oob_net0 interface
> * Issue command "ethtool -I -a oob_net0" to display pause frame counters
> * Send in multiple streams of traffic to oob_net0 interface, e.g. from
>   two or three simultaneous SCP operations
> * Re-issue "ethtool -I -a oob_net0" and note difference in output
> 
> [Regression Potential]
> 
> The changed logic extends the ethtool support, so low risk for any problem.
> 
> David Thompson (1):
>   UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters
> 
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 39 +++++++++++++++++++
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 22 +++++++++++
>  2 files changed, 61 insertions(+)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Bartlomiej Zolnierkiewicz March 6, 2024, 12:40 p.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Tue, Feb 27, 2024 at 6:12 PM David Thompson <davthompson@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2055086
>
> SRU Justification:
>
> [Impact]
>
> The BlueField-2 and BlueField-3 silicon designs include a
> provision for reporting pause frame counters, but the driver
> (mlxbf_gige) does not have software support yet.
>
> [Fix]
>
> The fix is to update the mlxbf_gige driver to support the
> "get_pause_stats()" callback, which enables display of
> pause frame counters via "ethtool -I -a ooob_net0".
> The support of this callback was added to Linux kernel 5.9.0
>
> [Test Case]
>
> * Reboot BF platform, and configure oob_net0 interface
> * Issue command "ethtool -I -a oob_net0" to display pause frame counters
> * Send in multiple streams of traffic to oob_net0 interface, e.g. from
>   two or three simultaneous SCP operations
> * Re-issue "ethtool -I -a oob_net0" and note difference in output
>
> [Regression Potential]
>
> The changed logic extends the ethtool support, so low risk for any problem.
>
> David Thompson (1):
>   UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters
>
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 39 +++++++++++++++++++
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 22 +++++++++++
>  2 files changed, 61 insertions(+)
>