| Message ID | 20240130090447.198103-1-Kelly_Hung@asus.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: aspeed: asus: Add ASUS X4TF BMC | expand |
On 30/01/2024 10:04, Kelly Hung wrote: > This initial device-tree provides the necessary configuration for > basic BMC functionality and work on ASUS X4TF production. > > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) I assume this is not a submission to mainline Linux kernel thus it is fine. However if by any chance it is submission to mainline Linux kernel, then: Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts_getmaintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, use mainline), work on fork of kernel (don't, use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
Hi, Krzysztof, I have already executed - `git log --oneline -- DIRECTORY_OR_FILE` - do scripts/get_maintainers.pl I tried correcting subject prefix and resent on 2/22. According this document: https://github.com/openbmc/docs/blob/master/kernel-development.md. "You should feel welcome to cc the OpenBMC list when sending upstream, so other kernel developers can provide input where appropriate." So, I also -cc to openbmc@lists.ozlabs.org. Thanks for review. Best Regards Kelly -----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Thursday, February 1, 2024 5:24 PM To: Kelly Hung <ppighouse@gmail.com>; openbmc@lists.ozlabs.org Cc: Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com> Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC External email : Ensure your email is secure before opening links and attachments. On 30/01/2024 10:04, Kelly Hung wrote: > This initial device-tree provides the necessary configuration for > basic BMC functionality and work on ASUS X4TF production. > > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) I assume this is not a submission to mainline Linux kernel thus it is fine. However if by any chance it is submission to mainline Linux kernel, then: Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts_getmaintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, use mainline), work on fork of kernel (don't, use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof <p></p> =================================================================================================================================== This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish. ===================================================================================================================================
On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: > Hi, Krzysztof, > > I have already executed > - `git log --oneline -- DIRECTORY_OR_FILE` > - do scripts/get_maintainers.pl > I tried correcting subject prefix and resent on 2/22. > According this document: https://github.com/openbmc/docs/blob/master/kernel-development.md. > "You should feel welcome to cc the OpenBMC list when sending upstream, so other kernel developers can provide input where appropriate." > So, I also -cc to openbmc@lists.ozlabs.org. > Please respond inline, instead of top-posting, because it makes your emails hard to follow. https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 You still ignored my tag. > =================================================================================================================================== > This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus I will just remove your messages. Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful). If you do not understand why, please also see: https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 Best regards, Krzysztof
-----Original Message----- > >On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: > > > Please respond inline, instead of top-posting, because it makes your emails hard to follow. > https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 > Thanks for reminding me many times, I understand now. > You still ignored my tag. > > > > ====================================================================== > > ============================================================= > > This email and any attachments to it contain confidential information > > and are intended solely for the use of the individual to whom it is > > addressed. If you are not the > Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus I will just remove your messages. > > Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful). > > If you do not understand why, please also see: > https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 > Hi, Krzysztof, I have already asked our company's IT, and because of security laws, IT cannot help me delete that confidential information. Best Regards Kelly =================================================================================================================================== This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish. ===================================================================================================================================
On 05/03/2024 10:42, Kelly Hung(洪嘉莉) wrote: > -----Original Message----- > >>> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: >>> >> Please respond inline, instead of top-posting, because it makes your emails hard to follow. >> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 >> > > Thanks for reminding me many times, I understand now. > >> You still ignored my tag. >> >> >>> ====================================================================== >>> ============================================================= >>> This email and any attachments to it contain confidential information >>> and are intended solely for the use of the individual to whom it is >>> addressed. If you are not the > >> Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus I will just remove your messages. >> >> Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful). >> >> If you do not understand why, please also see: >> https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 >> > Hi, Krzysztof, > I have already asked our company's IT, and because of security laws, IT cannot help me delete that confidential information. Well, this puts me in quite difficult spot because I might be legally obliged to delete your emails. I don't know how to proceed (and I don't care), so I recommend using different email provider, but if you do not want I will conform with the requirements and delete all emails from you. Best regards, Krzysztof
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午5:44寫道： > > -----Original Message----- > > > >> > >> Hi, Krzysztof, > >> I have already asked our company's IT, and because of security laws, IT > cannot help me delete that confidential information. > > >Well, this puts me in quite difficult spot because I might be legally > obliged to delete your emails. I don't know how to proceed (and I don't > care), so I recommend using different email provider, but if you do not > want I will conform with the requirements and delete all emails from you. > > >Best regards, > >Krzysztof > > Hi, Krzysztof, Yes, I replayed this email using my private Gmail account. I hope this patch continues to be successful. Please note that the email for my openbmc account is kelly_hung@asus.com. Thanks. Best Regards Kelly
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道： > On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: > > Hi, Krzysztof, > > > > I have already executed > > - `git log --oneline -- DIRECTORY_OR_FILE` > > - do scripts/get_maintainers.pl > > I tried correcting subject prefix and resent on 2/22. > > According this document: > https://github.com/openbmc/docs/blob/master/kernel-development.md. > > "You should feel welcome to cc the OpenBMC list when sending upstream, > so other kernel developers can provide input where appropriate." > > So, I also -cc to openbmc@lists.ozlabs.org. > > > > Please respond inline, instead of top-posting, because it makes your > emails hard to follow. > > https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 > > You still ignored my tag. > > I reply inline using my Gmail account, thanks for your comment. > > > > =================================================================================================================================== > > This email and any attachments to it contain confidential information > and are intended solely for the use of the individual to whom it is > addressed. If you are not the > > Maybe I am the intended recipient of your message, maybe not. I don't > want to have any legal questions regarding upstream, public > collaboration, thus I will just remove your messages. > > Please talk with your IT that such disclaimers in open-source are not > desired (and maybe even harmful). > > If you do not understand why, please also see: > https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 > > Best regards, > Krzysztof > > I reply using my Gmail account so no more confidential information. Best Regards, Kelly
On 26/03/2024 09:19, Chia Li Hung wrote: > Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道： > >> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: >>> Hi, Krzysztof, >>> >>> I have already executed >>> - `git log --oneline -- DIRECTORY_OR_FILE` >>> - do scripts/get_maintainers.pl >>> I tried correcting subject prefix and resent on 2/22. >>> According this document: >> https://github.com/openbmc/docs/blob/master/kernel-development.md. >>> "You should feel welcome to cc the OpenBMC list when sending upstream, >> so other kernel developers can provide input where appropriate." >>> So, I also -cc to openbmc@lists.ozlabs.org. >>> >> >> Please respond inline, instead of top-posting, because it makes your >> emails hard to follow. >> >> https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 >> >> You still ignored my tag. >> >> > I reply inline using my Gmail account, thanks for your comment. OK, and what about my tag? Did you read documentation I linked before? Best regards, Krzysztof
Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月26日 週二 下午4:43寫道： > On 26/03/2024 09:19, Chia Li Hung wrote: > > Krzysztof Kozlowski <krzk@kernel.org> 於 2024年3月5日 週二 下午3:09寫道： > > > >> On 05/03/2024 07:30, Kelly Hung(洪嘉莉) wrote: > >>> Hi, Krzysztof, > >>> > >>> I have already executed > >>> - `git log --oneline -- DIRECTORY_OR_FILE` > >>> - do scripts/get_maintainers.pl > >>> I tried correcting subject prefix and resent on 2/22. > >>> According this document: > >> https://github.com/openbmc/docs/blob/master/kernel-development.md. > >>> "You should feel welcome to cc the OpenBMC list when sending upstream, > >> so other kernel developers can provide input where appropriate." > >>> So, I also -cc to openbmc@lists.ozlabs.org. > >>> > >> > >> Please respond inline, instead of top-posting, because it makes your > >> emails hard to follow. > >> > >> > https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 > >> > >> You still ignored my tag. > >> > >> > > I reply inline using my Gmail account, thanks for your comment. > > OK, and what about my tag? Did you read documentation I linked before? > > Hi, Krzysztof, Regarding tags, I released the v6 patch and added Reviewed-by and Acked-by tags. Regarding the confidential information, ASUS has signed the CCLA, can we add confidential information? > Best regards, > Krzysztof > >
On 26/03/2024 11:53, Chia Li Hung wrote: >>> I reply inline using my Gmail account, thanks for your comment. >> >> OK, and what about my tag? Did you read documentation I linked before? >> >> Hi, Krzysztof, > Regarding tags, I released the v6 patch and added Reviewed-by and Acked-by > tags. Thank you. > Regarding the confidential information, ASUS has signed the CCLA, can we > add confidential information? No clue what is CCLA, but I did not sign it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 749ee54a3ff8..80009948e14a 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -74,6 +74,7 @@ properties: - ampere,mtmitchell-bmc - aspeed,ast2600-evb - aspeed,ast2600-evb-a1 + - asus,x4tf - facebook,bletchley-bmc - facebook,cloudripper-bmc - facebook,elbert-bmc
This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production. Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)